Add doc examples for std::alloc::{alloc,alloc_zeroed}. #53344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frewsxcv
force-pushed
the
frewsxcv-doc-ptr
branch
from
09d5b14 to
ced0b10
Compare
|
r? @rust-lang/docs |
|
Thanks! r=me once CI is ok. |
ollie27
suggested changes
Aug 14, 2018
src/liballoc/alloc.rs
Outdated
| /// use std::alloc::{alloc, dealloc, Layout}; | ||
| /// | ||
| /// unsafe { | ||
| /// let layout = Layout::from_size_align(2, 1).unwrap(); |
There was a problem hiding this comment.
u16 generally has an alignment of 2 not 1. Using Layout::new::<u16>() would be better here though.
src/liballoc/alloc.rs
Outdated
| /// use std::alloc::{alloc_zeroed, dealloc, Layout}; | ||
| /// | ||
| /// unsafe { | ||
| /// let layout = Layout::from_size_align(2, 1).unwrap(); |
There was a problem hiding this comment.
Again, this should be Layout::new::<u16>().
src/liballoc/alloc.rs
Outdated
| /// let layout = Layout::from_size_align(2, 1).unwrap(); | ||
| /// let ptr = alloc(layout); | ||
| /// | ||
| /// println!("Pointer {:p} has data: {:b}", ptr, *(ptr as *mut u16)); |
There was a problem hiding this comment.
This is reading uninitialised memory which is Undefined Behaviour. I suggest writing a value to it first and then reading that value back.
TimNN
added
the
S-waiting-on-author
frewsxcv
force-pushed
the
frewsxcv-doc-ptr
branch
from
ced0b10 to
d1193bf
Compare
|
@ollie27 Thanks for the feedback! Comments addressed in the latest force push |
|
Looks good now. @bors r+ rollup |
|
📌 Commit d1193bf has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 15, 2018
Add doc examples for std::alloc::{alloc,alloc_zeroed}.
None
bors
added a commit
that referenced
this pull request
Aug 15, 2018
Rollup of 8 pull requests Successful merges: - #52453 (improve diagnostics for tests with custom return values) - #53271 (use ? to simplify `TransitiveRelation.maybe_map`) - #53279 (Extend documentation of `rustc_on_unimplemented`) - #53342 (fix error for unsized packed struct field) - #53344 (Add doc examples for std::alloc::{alloc,alloc_zeroed}.) - #53368 (Ignore test that fails on stage1) - #53388 (Fix links' color) - #53396 (Fix since of Iterator::flatten to be a proper semver) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.