Make codegen_fn_attrs query cheap to clone
#53499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to recover a perf loss observed in rust-lang#52993 by making the result of the `codegen_fn_attrs` query cheap to clone as more and more parts of the compiler start to use this query.
|
@bors: try |
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
bors
added a commit
that referenced
this pull request
Aug 19, 2018
Make `codegen_fn_attrs` query cheap to clone This is an attempt to recover a perf loss observed in #52993 by making the result of the `codegen_fn_attrs` query cheap to clone as more and more parts of the compiler start to use this query.
|
☀️ Test successful - status-travis |
|
@rust-timer build c250010 |
|
Success: Queued c250010 with parent b355906, comparison URL. |
|
The regression I'm trying to fix was definitely not fixed in this perf run, so will need to keep looking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to recover a perf loss observed in #52993 by making the
result of the
codegen_fn_attrsquery cheap to clone as more and more parts ofthe compiler start to use this query.