Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 17 pull requests #53530

Merged
merged 45 commits into from
Aug 21, 2018
Merged

Rollup of 17 pull requests #53530

merged 45 commits into from
Aug 21, 2018

Commits on Aug 3, 2018

  1. Updated RELEASES.md for 1.29.0

    Aaron Power committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    3350eaf View commit details
    Browse the repository at this point in the history
  2. Update RELEASES.md

    Aaronepower authored Aug 3, 2018
    Configuration menu
    Copy the full SHA
    a646c10 View commit details
    Browse the repository at this point in the history
  3. Update RELEASES.md

    Aaronepower authored Aug 3, 2018
    Configuration menu
    Copy the full SHA
    96f50f1 View commit details
    Browse the repository at this point in the history
  4. Update RELEASES.md

    Aaronepower authored Aug 3, 2018
    Configuration menu
    Copy the full SHA
    b4924bf View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2018

  1. expand the documentation on the Unpin trait

    provides an overview of the Pin API which the trait is for,
    and show how it can be used in making self referencial structs
    
    part of rust-lang#49150
    nivkner committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    038ce65 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6845dc4 View commit details
    Browse the repository at this point in the history
  3. fix link to PinBox

    nivkner committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    9b7d710 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    87bbd2e View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2018

  1. Configuration menu
    Copy the full SHA
    68e766a View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2018

  1. Configuration menu
    Copy the full SHA
    687cc98 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2018

  1. Configuration menu
    Copy the full SHA
    e6244e5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bc900f5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e5e14d3 View commit details
    Browse the repository at this point in the history
  4. update recently moved tests

    estebank committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    cea73d6 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2018

  1. Configuration menu
    Copy the full SHA
    2075509 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    03530fa View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2018

  1. Configuration menu
    Copy the full SHA
    1540e8c View commit details
    Browse the repository at this point in the history
  2. Change target triple used to check for lldb in build-manifest

    The wrong target triple was used for lldb in build-manifest.  lldb is
    only built for macOS, so update the triple to reflect that.
    
    This is an attempt to fix bug#48168.
    tromey committed Aug 17, 2018
    Configuration menu
    Copy the full SHA
    c37787e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6ae915b View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2018

  1. Remove LinkMeta struct

    bjorn3 committed Aug 18, 2018
    Configuration menu
    Copy the full SHA
    d52047f View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2018

  1. update lld submodule to include RISCV patch

    This pulls in one new commit, to add support for linking static RISCV
    binaries, suitable for the new riscv32imac-unknown-none-elf target.
    See: rust-lang/lld#1
    danc86 committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    99bba34 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    71120ef View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    00920c0 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2018

  1. Configuration menu
    Copy the full SHA
    993fb93 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    de35b66 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b51723a View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#53213 - tmccombs:stable-ipconstructors, r=K…

    …odrAus
    
    Stabilize IP associated constants
    
    Fixes rust-lang#44582
    kennytm authored Aug 20, 2018
    Configuration menu
    Copy the full SHA
    fa3d56a View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#53296 - estebank:suggest-closure, r=KodrAus

    When closure with no arguments was expected, suggest wrapping
    
    Fix rust-lang#49694.
    kennytm authored Aug 20, 2018
    Configuration menu
    Copy the full SHA
    ffde96c View commit details
    Browse the repository at this point in the history
  6. syntax: Optimize some literal parsing

    Currently in the `wasm-bindgen` project we have a very very large crate that's
    procedurally generated, `web-sys`. To generate this crate we parse all of a
    browser's WebIDL and we then generate bindings for all of the APIs contained
    within.
    
    The resulting Rust file is 18MB large (wow!) and currently takes a very long
    time to compile in debug mode. On the nightly compiler a *debug* build takes 90s
    for the crate to finish. I was curious what was taking so long and upon
    investigating a *massive* portion of the time was spent in the `lit_token`
    method of the compiler, primarily formatting strings via `format!`.
    
    Upon some more investigation it looks like the `byte_str_lit` was allocating an
    error message once per byte, causing a very large number of allocations to
    happen for large literals, of which wasm-bindgen generates quite a few (some are
    MB large).
    
    This commit fixes the issue by lazily allocating the error message, only doing
    so if the error message is actually needed (which should be never). As a result,
    the debug mode compilation time for our `web-sys` crate decreased from 90s to
    20s, a very nice improvement! (although we've still got some work to do).
    alexcrichton committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    5bf2ad3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6b597ce View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2018

  1. Avoid some Place clones.

    This is a 0.5% speedup on ripgrep.
    nnethercote committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    c0636ab View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#53370 - jkozlowski:stabilize-macro_vis_matc…

    …her, r=cramertj
    
    Stabilize macro_vis_matcher
    
    This PR should stabilize [macro_vis_matcher](rust-lang#41022) feature.
    
    - [ ] "reference" book changes: rust-lang/reference#400
    - [ ] "Rust by example" book changes: rust-lang/rust-by-example#1096
    - [ ] "clippy" changes: rust-lang/rust-clippy#3055
    
    r? @cramertj
    kennytm committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    f9e3af7 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#53393 - BurntPizza:serialize-inlines, r=ale…

    …xcrichton
    
    Mark libserialize functions as inline
    
    Got to thinking: "what if that big pile of tiny functions isn't inlining as it should?"
    So a few `replace-regex` later the local perf run says this:
    <details>
    
    ![](https://i.imgur.com/gvdJEgG.png)
    </details>
    Not huge, but still a win, which is interesting. Want to verify with the real perf run, but I understand there's a backlog.
    
    I didn't notice any increase in compile time or binary sizes for rustc/libs.
    kennytm committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    b21e956 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#53405 - oconnor663:search_esc, r=GuillaumeG…

    …omez
    
    restore the page title after escaping out of a search
    
    Currently if I start a search in the docs, but then hit ESC, the "Results for..." title is still there in my browser tab. This is a simple attempt to fix that. I see that there's a separate `var previousTitle = document.title` thing happening in `startSearch()`, but as far as I can tell that's only related to the back stack? I'd also appreciate feedback on the right place to declare the `titleBeforeSearch` variable.
    
    Testing-wise, I've confirmed by hand that the tab title restores correctly after building with `./x.py doc --stage 1 src/libstd`, but nothing more involved than that. What else should I test?
    kennytm committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    2a0d720 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#53452 - tromey:lldb-manifest-fix, r=alexcri…

    …chton
    
    Change target triple used to check for lldb in build-manifest
    
    The wrong target triple was used for lldb in build-manifest.  lldb is
    only built for macOS, so update the triple to reflect that.
    
    This is an attempt to fix bug#48168.
    kennytm committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    c980ba7 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#53465 - bjorn3:remove_link_meta_struct, r=v…

    …arkor
    
    Remove LinkMeta struct
    
    Fixes rust-lang#53291
    kennytm committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    5d4a25d View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#53492 - danc86:lld-riscv, r=alexcrichton

    update lld submodule to include RISCV patch
    
    This pulls in one new commit, to add support for linking static RISCV
    binaries, suitable for the new riscv32imac-unknown-none-elf target.
    See: rust-lang/lld#1
    kennytm committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    0834a1a View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#53496 - matthiaskrgr:codespell_08_2018, r=v…

    …arkor
    
    Fix typos found by codespell.
    kennytm committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    b5519db View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#53521 - alexcrichton:optimize-lit-token, r=…

    …michaelwoerister
    
    syntax: Optimize some literal parsing
    
    Currently in the `wasm-bindgen` project we have a very very large crate that's
    procedurally generated, `web-sys`. To generate this crate we parse all of a
    browser's WebIDL and we then generate bindings for all of the APIs contained
    within.
    
    The resulting Rust file is 18MB large (wow!) and currently takes a very long
    time to compile in debug mode. On the nightly compiler a *debug* build takes 90s
    for the crate to finish. I was curious what was taking so long and upon
    investigating a *massive* portion of the time was spent in the `lit_token`
    method of the compiler, primarily formatting strings via `format!`.
    
    Upon some more investigation it looks like the `byte_str_lit` was allocating an
    error message once per byte, causing a very large number of allocations to
    happen for large literals, of which wasm-bindgen generates quite a few (some are
    MB large).
    
    This commit fixes the issue by lazily allocating the error message, only doing
    so if the error message is actually needed (which should be never). As a result,
    the debug mode compilation time for our `web-sys` crate decreased from 90s to
    20s, a very nice improvement! (although we've still got some work to do).
    kennytm committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    4457180 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#53363 - llogiq:num-individual-nonzero-docs,…

    … r=steveklabnik
    
    add individual docs to `core::num::NonZero*`
    kennytm committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    7896ac3 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#53462 - estk:doc-Box_into_raw, r=steveklabnik

    Document Box::into_raw returns non-null ptr
    
    Closes  rust-lang#52806.
    kennytm committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    fed4298 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#53104 - nivkner:unpin_doc, r=RalfJung

    expand the documentation on the `Unpin` trait
    
    provides an overview of the Pin API which the trait is for,
    and show how it can be used in making self referencial structs
    
    part of rust-lang#49150
    kennytm committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    dc8e9fb View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#53540 - TheDarkula:move-test, r=oli-obk

    Moved issue-53157.rs into src/test/ui/consts/const-eval/
    kennytm committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    9bbab65 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#53329 - frewsxcv:frewsxcv-ptr-add-sub, r=Ra…

    …lfJung
    
    Replace usages of ptr::offset with ptr::{add,sub}.
    
    Rust provides these helper methods – so let's use them!
    kennytm committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    0dd88c9 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#53551 - nnethercote:access_place_error_repo…

    …rted, r=varkor
    
    Avoid some Place clones.
    
    This is a 0.5% speedup on ripgrep.
    kennytm committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    e3887e6 View commit details
    Browse the repository at this point in the history