Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve: Recover from indeterminate macro resolutions more agressively #53587

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/librustc_resolve/macros.rs
Original file line number Diff line number Diff line change
Expand Up @@ -611,6 +611,7 @@ impl<'a, 'cl> Resolver<'a, 'cl> {
);
self.current_module = orig_current_module;
binding.map(|binding| (binding, FromPrelude(false)))
.map_err(|d| Determinacy::determined(d == Determinacy::Determined || force))
}
WhereToResolve::MacroPrelude => {
match self.macro_prelude.get(&ident.name).cloned() {
Expand Down Expand Up @@ -756,7 +757,7 @@ impl<'a, 'cl> Resolver<'a, 'cl> {
Err(Determinacy::Determined) => {
continue_search!();
}
Err(Determinacy::Undetermined) => return Err(Determinacy::determined(force)),
Err(Determinacy::Undetermined) => return Err(Determinacy::Undetermined),
}
}

Expand Down
22 changes: 22 additions & 0 deletions src/test/ui-fulldeps/proc-macro/auxiliary/issue-53481.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// no-prefer-dynamic

#![crate_type = "proc-macro"]

extern crate proc_macro;

use proc_macro::*;

#[proc_macro_derive(MyTrait, attributes(my_attr))]
pub fn foo(_: TokenStream) -> TokenStream {
TokenStream::new()
}
32 changes: 32 additions & 0 deletions src/test/ui-fulldeps/proc-macro/issue-53481.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// compile-pass
// aux-build:issue-53481.rs

#[macro_use]
extern crate issue_53481;

mod m1 {
use m2::MyTrait;

#[derive(MyTrait)]
struct A {}
}

mod m2 {
pub type MyTrait = u8;

#[derive(MyTrait)]
#[my_attr]
struct B {}
}

fn main() {}