Commits on Aug 22, 2018

1. 52985: better cycle error for existential types …

     - Original cycle error diagnostics PR'd against this issue caught
   panic-causing error while resolving std::mem::transmute calls
     - Now, catch invalid use case of not providing a concrete sized type
   behind existential type in definining use case.
     - Update relevant test to reflect this new error
   
   52985: revert normalize query changes
         - PR 53588 invalidates 53316, causing a correct cycle error to occur
       with a good span.
         - Don't need to revert the whole merge as the test files are
       still fine, just need to revert the normalize query changes.
         - It should now be correct that infinite recursion detected during
       normalize query type folding is a bug, should have been caught earlier
       (when resolving the existential type's defining use cases).
   
   52985: code review impl
     - Only cause cycle error if anonymous type resolves to anonymous type
   that has the same def id (is the same type) as the original (parent)
   type.
     - Add test case to cover this case for existential types.
   
   52985: remove Ty prefix from TyAnon
     - To align with changes per commit 6f637da

   

   tristanburgess committed Aug 22, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 3045ffa
   • Browse repository at this point

   Copy the full SHA

   3045ffa View commit details

   Browse the repository at this point in the history

2. 52985: formatting PR files

   

   tristanburgess committed Aug 22, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 7440125
   • Browse repository at this point

   Copy the full SHA

   7440125 View commit details

   Browse the repository at this point in the history