Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clippy #53638

Merged
merged 2 commits into from
Aug 24, 2018
Merged

Update clippy #53638

merged 2 commits into from
Aug 24, 2018

Conversation

flip1995
Copy link
Member

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 23, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Aug 23, 2018

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Aug 23, 2018

📌 Commit 65c0ebd has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:11:50] Verifying status of rustfmt...
[01:11:50] Verifying status of clippy-driver...
[01:11:50] This PR updated 'src/tools/clippy', verifying if status is 'test-pass'...
[01:11:50] 
[01:11:50] ⚠️ We detected that this PR updated 'clippy-driver', but its tests failed.
[01:11:50] 
[01:11:50] If you do intend to update 'clippy-driver', please check the error messages above and
[01:11:50] commit another update.
[01:11:50] 
[01:11:50] If you do NOT intend to update 'clippy-driver', please ensure you did not accidentally
[01:11:50] change the submodule at 'src/tools/clippy'. You may ask your reviewer for the
[01:11:50] proper steps.

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 3.
travis_time:start:02765622
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:299fe835:start=1535037367143821111,finish=1535037367151604476,duration=7783365
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:168643bc
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0b556cff
travis_time:start:0b556cff
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1bc992cd
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm
Copy link
Member

kennytm commented Aug 23, 2018

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 23, 2018
@matthiaskrgr
Copy link
Member

Ok, looks like clippy broke again due to #52602

Should be fixed with rust-lang/rust-clippy#3077 :)

@nrc
Copy link
Member

nrc commented Aug 23, 2018

@bors r+ p=10

@bors
Copy link
Contributor

bors commented Aug 23, 2018

📌 Commit cd8fcb6 has been approved by nrc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 23, 2018
Xanewok added a commit to Xanewok/rls that referenced this pull request Aug 23, 2018
This should fix RLS toolstate in Rust master, see
rust-lang/rust#53638 (comment)
for more details.
@bors
Copy link
Contributor

bors commented Aug 23, 2018

⌛ Testing commit cd8fcb6 with merge 63d6649...

bors added a commit that referenced this pull request Aug 23, 2018
@bors
Copy link
Contributor

bors commented Aug 24, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nrc
Pushing 63d6649 to master...

@bors bors merged commit cd8fcb6 into rust-lang:master Aug 24, 2018
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #53638!

Tested on commit 63d6649.
Direct link to PR: #53638

🎉 clippy-driver on windows: build-fail → test-pass.
🎉 clippy-driver on linux: build-fail → test-pass.

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Aug 24, 2018
Tested on commit rust-lang/rust@63d6649.
Direct link to PR: <rust-lang/rust#53638>

🎉 clippy-driver on windows: build-fail → test-pass.
🎉 clippy-driver on linux: build-fail → test-pass.
@flip1995 flip1995 deleted the clippy branch August 24, 2018 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants