The Genesis of Generic Germination #53645
Conversation
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #53662) made this pull request unmergeable. Please resolve the merge conflicts. |
|
(Somehow I read the title as "Genesis of Germanic Germination" and thought why we're adding i18n into rustc itself 😐) |
src/libsyntax/parse/parser.rs
Outdated
| // parsing problem. Either mark all const args with const (or | ||
| // something else, it doesn't really matter) or merge const args | ||
| // and type args together at the AST level and separate them | ||
| // later on, probably when lowering to the HIR. |
There was a problem hiding this comment.
If S<MY_CONST> is supposed to work, then it can use same approach as identifiers in patterns.
In AST it's PatKind::Ident, but in HIR it's turned into a proper pattern based on resolution, for const arguments it would be something like ast::GenericArg::Ident.
I agree this is not necessary to do in this PR though.
|
(Note for triage: I'm going to get around to addressing these comments and hopefully fixing the existing crashes soon.) |
TimNN
added
S-waiting-on-author
|
Ping from triage! Since it's been I while, I was wondering if you could give us a small update on the status of this PR? |
|
I'm going to start investigating the ICE again soon (been busier than I expected). I think @eddyb's going to be leaving some comments soon as well. |
|
Ping from triage! Since it's been I while, I was wondering if you could give us a small update on the status of this PR? |
|
I've made progress in my local branch since last time, though not quite ready to push. I think a full review will be unlikely before the 2018 edition though, as things are getting busy close to the deadline. |
varkor
force-pushed
the
const-generics-redux
branch
from
f0bae41 to
bfc4b41
Compare
|
@vakor: Thanks for the update! |
Co-Authored-By: Gabriel Smith <yodaldevoid@users.noreply.github.com>
Co-Authored-By: Gabriel Smith <yodaldevoid@users.noreply.github.com>
Co-Authored-By: Gabriel Smith <yodaldevoid@users.noreply.github.com>
Co-Authored-By: Gabriel Smith <yodaldevoid@users.noreply.github.com>
varkor
force-pushed
the
const-generics-redux
branch
from
ed69aa2 to
32965a7
Compare
varkor
changed the title
|
I've resolved several remaining r? @eddyb |
| ConstValue::Param(ParamConst { name, .. }) => { | ||
| write!(output, "{}", name).unwrap(); | ||
| ConstValue::Scalar(..) | ConstValue::Slice(..) | ConstValue::ByRef(..) => { | ||
| // FIXME(const_generics): we could probably do a better job here. |
There was a problem hiding this comment.
This whole infrastructure should be rewritten to use ty::print, can you open an issue about that?
it was rebased, the inevitable conclusion of all epic journeys in the land of git. And thus concluded the Genesis of Generic Germination. |
Co-Authored-By: Gabriel Smith <yodaldevoid@users.noreply.github.com>
varkor
force-pushed
the
const-generics-redux
branch
from
32965a7 to
9a2772a
Compare
|
@bors r+ |
|
📌 Commit 9a2772a has been approved by |
bors
added
S-waiting-on-bors
The Genesis of Generic Germination *Long had its coming been foretold: a collaborative effort with @yodaldevoid, set in motion by @jplatte, to beget a new Kind: one of a very different Sort to those that come before it. Amidst promises of ineffable powers previously thought unobtainable, few dared believe that the prophecies were true. But as they gazed upon that which claimed to be the Beginning, a few gentle sparks of hope fluttered deep within. It was not Time yet. But it was a Sign. And maybe, for some, that was enough.* There's a long way to go, but we're at the point where we would benefit from GitHub's reviewing capabilities. r? @eddyb
|
☀️ Test successful - checks-travis, status-appveyor |
Tested on commit rust-lang/rust@a19cf18. Direct link to PR: <rust-lang/rust#53645> 💔 rls on windows: test-pass → test-fail (cc @Xanewok, @rust-lang/infra).
Long had its coming been foretold: a collaborative effort with @yodaldevoid, set in motion by @jplatte, to beget a new Kind: one of a very different Sort to those that come before it. Amidst promises of ineffable powers previously thought unobtainable, few dared believe that the prophecies were true. But as they gazed upon that which claimed to be the Beginning, a few gentle sparks of hope fluttered deep within. It was not Time yet. But it was a Sign. And maybe, for some, that was enough.
There's a long way to go, but we're at the point where we would benefit from GitHub's reviewing capabilities.
r? @eddyb