Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RLS to latest version. #53649

Closed
wants to merge 1 commit into from
Closed

Conversation

staktrace
Copy link
Contributor

Fixes #53440.

r? @nrc

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 23, 2018
@matthiaskrgr
Copy link
Member

Hi, I think this might not work because clippy is still not building with current master at the moment #53610

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:12:17] Verifying status of rust-by-example...
[01:12:17] Verifying status of rls...
[01:12:17] This PR updated 'src/tools/rls', verifying if status is 'test-pass'...
[01:12:17] 
[01:12:17] ⚠️ We detected that this PR updated 'rls', but its tests failed.
[01:12:17] 
[01:12:17] If you do intend to update 'rls', please check the error messages above and
[01:12:17] commit another update.
[01:12:17] 
[01:12:17] If you do NOT intend to update 'rls', please ensure you did not accidentally
[01:12:17] change the submodule at 'src/tools/rls'. You may ask your reviewer for the
[01:12:17] proper steps.

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 3.
travis_time:start:112e1596
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:02d0c378:start=1535061914806517539,finish=1535061914814243149,duration=7725610
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:12b77004
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:26bf9115
travis_time:start:26bf9115
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:066c47f0
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@nrc
Copy link
Member

nrc commented Aug 23, 2018

Am I right that this is subsumed by #53610 and can be closed?

@staktrace
Copy link
Contributor Author

Yeah, I didn't see that one, looks like they are basically the same thing.

@staktrace staktrace closed this Aug 23, 2018
@staktrace staktrace deleted the rlsbump branch August 24, 2018 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants