-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve where clauses in types in impls #53748
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
LGTM. Thanks for looking into this! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, feel free to disregard the nitpick
@@ -0,0 +1,27 @@ | |||
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that #53617 was merged I think the copyright notice can just be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confess that I hate those licenses so much I make a point of leaving the Copyright year untouched (it doesn't matter a whit legally, from what I understand).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woah, I knew nothing about #53617!
@bors r=estebank |
📌 Commit 23372af has been approved by |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This change causes I figured that it wouldn't affect any tests, let alone this many.
|
@bors r- ICEs in many UI tests. |
Fascinating. I also did not expect that. =) |
Ping from triage, @nikomatsakis: What are your plans for this PR? |
☔ The latest upstream changes (presumably #54051) made this pull request unmergeable. Please resolve the merge conflicts. |
Haven't had a chance to get back to it. Will soon. |
Ping from triage, @nikomatsakis! |
Ping from triage @nikomatsakis! I'm closing this PR as inactive for the moment, per https://forge.rust-lang.org/triage-procedure.html. Please feel free to re-open in the future, when you work on this again. |
Fixes #47206
cc @sunjay