Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve: Relax shadowing restrictions on macro-expanded macros #53778

Merged
merged 11 commits into from
Sep 9, 2018
Merged

resolve: Relax shadowing restrictions on macro-expanded macros #53778

merged 11 commits into from
Sep 9, 2018

Commits on Sep 8, 2018

  1. resolve: Partially unify bindings from macro_rules and from other items

    @petrochenkov
    petrochenkov committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    4e5e045 View commit details
    Browse the repository at this point in the history

  2. resolve: Model resolve_legacy_scope after `resolve_lexical_macro_pa… 

    …th_segment`
    @petrochenkov
    petrochenkov committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    83a51de View commit details
    Browse the repository at this point in the history

  3. resolve: Model shadowing restriction for macro_rules after modern macros 

    This is a regression for legacy macros that will be fixed in the next commit
    @petrochenkov
    petrochenkov committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    f34ac26 View commit details
    Browse the repository at this point in the history

  4. resolve: Cleanup two main macro resolution functions, tweak some comm… 

    …ents
    @petrochenkov
    petrochenkov committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    9a539ad View commit details
    Browse the repository at this point in the history

  5. resolve: Introduce "may appear after" abstraction for macro path reso… 

    …lutions
    @petrochenkov
    petrochenkov committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    2723569 View commit details
    Browse the repository at this point in the history

  6. resolve: Relax shadowing restriction on macro-expanded macros 

    ... for both legacy and modern macros.
Fix previously introduced regressions, add tests.
    @petrochenkov
    petrochenkov committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    c057d57 View commit details
    Browse the repository at this point in the history

  7. resolve: Rename some fields related to legacy macro scopes

    @petrochenkov
    petrochenkov committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    d26ae20 View commit details
    Browse the repository at this point in the history

  8. Add test cases for possible restricted shadowing configurations 

    Whitelist `#[rustc_transparent_macro]` so it's not interpreted as a potential attribute macro
    @petrochenkov
    petrochenkov committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    e00993a View commit details
    Browse the repository at this point in the history

  9. resolve: Further simplify legacy scopes, add comments

    @petrochenkov
    petrochenkov committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    ae2e5aa View commit details
    Browse the repository at this point in the history

  10. Add checks for expected macro output in restricted shadowing tests

    @petrochenkov
    petrochenkov committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    9beb5c3 View commit details
    Browse the repository at this point in the history

  11. resolve: More precise spans for ambiguous resolution errors 

    Add labels to ambiguous resolution errors
    @petrochenkov
    petrochenkov committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    2dce377 View commit details
    Browse the repository at this point in the history