Fix manifests for broken tools: take 2 #53803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietroalbini
added
the
T-infra
rust-highfive
added
the
S-waiting-on-review
pietroalbini
added
S-waiting-on-author
pietroalbini
added
S-waiting-on-review
|
@bors: r+ 👍 |
|
📌 Commit 38e2d00 has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=1 |
bors
added a commit
that referenced
this pull request
Aug 30, 2018
Fix manifests for broken tools: take 2 This is a follow up of #53715, to avoid stripping unavailable components from the extensions list. This time I also figured out how to test the changes, so the produced manifest is correct. Along with the fix I added a README with instructions on how to test the tool, and a new `BUILD_MANIFEST_DISABLE_SIGNING` env var to avoid dealing with gpg while testing the tool. I chose an env var instead of a flag because it's more difficult to have it slip in by accident on CI, and there is also another protection that panics if that env var is set on CI, just to be sure we don't release unsigned artifacts. r? @alexcrichton cc rust-lang/rustup#1486
|
☀️ Test successful - status-appveyor, status-travis |
jens1o
reviewed
Sep 1, 2018
| // The CI environment variable is set by both Travis and AppVeyor | ||
| if !should_sign && env::var("CI").is_ok() { | ||
| println!("The 'BUILD_MANIFEST_DISABLE_SIGNING' env var can't be enabled on CI."); | ||
| println!("If you're not running this on CI, unset the 'CI' env var."); |
There was a problem hiding this comment.
You're right, but I don't think it's worth doing a follow-up PR for this. The code inside that if should never be executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #53715, to avoid stripping unavailable components from the extensions list. This time I also figured out how to test the changes, so the produced manifest is correct.
Along with the fix I added a README with instructions on how to test the tool, and a new
BUILD_MANIFEST_DISABLE_SIGNINGenv var to avoid dealing with gpg while testing the tool. I chose an env var instead of a flag because it's more difficult to have it slip in by accident on CI, and there is also another protection that panics if that env var is set on CI, just to be sure we don't release unsigned artifacts.r? @alexcrichton
cc rust-lang/rustup#1486