Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mk: If NO_REBUILD is set then don't rebuild core/std before testing #5386

Closed
wants to merge 1 commit into from
Closed

mk: If NO_REBUILD is set then don't rebuild core/std before testing #5386

wants to merge 1 commit into from

Conversation

brson
Copy link
Contributor

@brson brson commented Mar 14, 2013

r? Can make turnaround of testing changes to core/std/syntax much faster.

e.g. make check-stage1-core NO_REBUILD=1

@brson
mk: If NO_REBUILD is set then don't rebuild core/std before testing
6ea70d5 
Can make turnaround of testing changes to core/std/syntax much faster.
@brson
Copy link
Contributor Author

brson commented Mar 14, 2013

@jbclements points out that rust test core, etc. pretty much work now and we don't necessarily need to be using the makefiles for local testing. rust test does need support for --cfg though so we can pass the correct stage config.

@brson
Copy link
Contributor Author

brson commented Mar 16, 2013

I have this in another branch that I'm going to submit, so I'll close this.

@brson brson closed this Mar 16, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jan 2, 2021
@bors
Auto merge of rust-lang#6483 - xFrednet:5386-github-ticket-search, r=…
5c98135 
…killercup

Website issue tracker link and better search performance

This PR implements some improvements to the website:
1. Added a "Search on Github" link to the "Known problems" section (Closes rust-lang#5386)
    ![example_3](https://user-images.githubusercontent.com/17087237/102718215-e9f12500-42de-11eb-8c1b-487f8184aaf7.png)
    <details>
    <summary>Another mock up I created with the GitHub logo</summary>

    ![example_2](https://user-images.githubusercontent.com/17087237/102718281-3472a180-42df-11eb-99b8-7f6d76da2b55.png)

    </details>

2. Only starting the search after three letters and improving the search performance in general. (Followup rust-lang#6477)

### Testing
These changes can be tested locally by:
1. Clone this branch
2. Download the current lint index from the [gh-pages branch](https://github.com/rust-lang/rust-clippy/blob/gh-pages/master/lints.json)
3. Put it next to the `util/gh-pages/index.html` and open the html file. Make sure that it can load the lint data. (Browsers can be a bit iffy when opening a local html page and loading data)

### Sources for search performance:
1. [A stackoverflow about angular filter performance](https://stackoverflow.com/questions/26876514/optimize-angular-filter-performance)
    * I selected a search debounce of 50ms that's fast enough to catch fast deletion and typing but responsive enough to not bother the user
2. [A stackoverflow about string comparison speeds](https://stackoverflow.com/questions/5296268/fastest-way-to-check-a-string-contain-another-substring-in-javascript)
3. [JS benchmarks for string search performance (`indexOf` seams to be the best)](https://jsben.ch/9cwLJ)

Note: The performance is still a bit poor when going from a specific lint to no search filter. I suspect that angular is recreating all lint items when the filter is cleared causing a major lag spike. The filter functions is at least optimized for little to no search.

---

changelog: Added a "Search on GitHub" link to the website
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brson