NLL regresses diagnostic for impl-trait/static-return-lifetime-infered.rs #53900

davidtwco · 2018-09-02T09:12:36Z

Fixes #53771.

r? @nikomatsakis
cc @pnkfelix @estebank

src/test/ui/impl-trait/must_outlive_least_region_or_bound.nll.stderr

src/test/ui/impl-trait/static-return-lifetime-infered.nll.stderr

src/librustc_mir/borrow_check/nll/region_infer/error_reporting/mod.rs

nikomatsakis

Looks mostly good. Left a few nits.

src/librustc_mir/borrow_check/nll/region_infer/error_reporting/mod.rs

nikomatsakis · 2018-09-06T19:13:53Z

@bors r+

bors · 2018-09-06T19:13:58Z

📌 Commit cd19ce4ad0273ae7dcc0634499fc883609bf95df has been approved by nikomatsakis

bors · 2018-09-07T20:30:32Z

☔ The latest upstream changes (presumably #53327) made this pull request unmergeable. Please resolve the merge conflicts.

davidtwco · 2018-09-07T23:06:54Z

Rebased.

nikomatsakis · 2018-09-11T13:03:41Z

src/librustc_mir/borrow_check/nll/region_infer/error_reporting/mod.rs

Hmm, I just noticed this; it is not always going to be correct, right?

e.g., in this example

fn foo(x: &[i32], y: &[i32]) -> impl Iterator<Item = i32> { y.iter().cloned() }

but we should probably just file a follow-up issue.

We currently get the following for that example:

error[E0621]: explicit lifetime required in the type of `y` --> test.rs:2:5 | 1 | fn foo(x: &[i32], y: &[i32]) -> impl Iterator<Item = i32> { | ------ help: add explicit lifetime `'static` to the type of `y`: `&'static [i32]` 2 | y.iter().cloned() | ^^^^^^^^^^^^^^^^^ lifetime `'static` required error: unsatisfied lifetime constraints --> test.rs:2:5 | 1 | fn foo(x: &[i32], y: &[i32]) -> impl Iterator<Item = i32> { | - - let's call the lifetime of this reference `'1` | | | let's call the lifetime of this reference `'2` 2 | y.iter().cloned() | ^^^^^^^^ requires that `'1` must outlive `'2`

nikomatsakis · 2018-09-11T13:04:04Z

@bors r+

bors · 2018-09-11T13:04:05Z

📌 Commit b1e7c635c877c048a1b13087d19eee7cf96ba7f4 has been approved by nikomatsakis

bors · 2018-09-12T15:14:40Z

⌛ Testing commit b1e7c635c877c048a1b13087d19eee7cf96ba7f4 with merge d0d3b809ab3cc7ddeca8caa7f79c56a6ff5b8385...

bors · 2018-09-12T15:34:22Z

💔 Test failed - status-appveyor

rust-highfive · 2018-09-12T15:36:22Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

Checking out files: 100% (16613/16613), done.
travis_time:end:00666138:start=1536766485573499000,finish=1536766494741996000,duration=9168497000
$ cd rust-lang/rust
$ git checkout -qf d0d3b809ab3cc7ddeca8caa7f79c56a6ff5b8385
fatal: reference is not a tree: d0d3b809ab3cc7ddeca8caa7f79c56a6ff5b8385
The command "git checkout -qf d0d3b809ab3cc7ddeca8caa7f79c56a6ff5b8385" failed and exited with 128 during .
Your build has been stopped.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2018-09-13T00:44:27Z

⌛ Testing commit b1e7c635c877c048a1b13087d19eee7cf96ba7f4 with merge ce7917c3f41561c8b662faf0b7598a837b825174...

rust-highfive · 2018-09-13T01:00:08Z

The job armhf-gnu of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:12:34]    Compiling rustc_typeck v0.0.0 (file:///checkout/src/librustc_typeck)
[00:12:34]    Compiling rustc_mir v0.0.0 (file:///checkout/src/librustc_mir)
[00:12:35] [RUSTC-TIMING] rustc_metadata_utils test:false 0.731
[00:12:35]    Compiling rustc_traits v0.0.0 (file:///checkout/src/librustc_traits)
[00:12:40] error[E0599]: no variant named `Anon` found for type `rustc::ty::TyKind<'_>` in the current scope
[00:12:40]    --> librustc_mir/borrow_check/nll/region_infer/error_reporting/mod.rs:492:22
[00:12:40]     |
[00:12:40] 492 |                 sty: ty::TyKind::Anon(did, substs),
[00:12:40] 
[00:12:48] error: aborting due to previous error
[00:12:48] 
[00:12:48] For more information about this error, try `rustc --explain E0599`.
[00:12:48] For more information about this error, try `rustc --explain E0599`.
[00:12:48] [RUSTC-TIMING] rustc_mir test:false 14.150
[00:12:48] error: Could not compile `rustc_mir`.
[00:12:48] 
[00:12:48] Caused by:
[00:12:48]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name rustc_mir librustc_mir/lib.rs --color always --error-format json --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C opt-level=2 -C metadata=9389ef21a7981207 -C extra-filename=-9389ef21a7981207 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/release/deps --extern arena=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libarena-93ff3b002b18b7ed.so --extern bitflags=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbitflags-5a39798fe03e47f4.rlib --extern byteorder=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbyteorder-8246be02936c9b1b.rlib --extern either=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libeither-0a515e87c8afea9e.rlib --extern graphviz=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libgraphviz-45ae4394366d07fd.so --extern log=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog-c55d6c95192e4906.rlib --extern log_settings=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog_settings-87ec950697a15ed0.rlib --extern polonius_engine=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libpolonius_engine-218f3033f29f5493.rlib --extern rustc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc-09c0f3a89ad0d6b5.so --extern rustc_apfloat=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_apfloat-96aac12abd62414d.rlib --extern rustc_data_structures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_data_structures-05301c67193a930e.so --extern rustc_errors=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_errors-f4ac364f854372fe.so --extern rustc_target=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_target-4a08b81d2b6640c1.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-8d84add221c0f710.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-8d84add221c0f710.rlib --extern smallvec=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsmallvec-cb741677cd0e0351.rlib --extern syntax=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax-0651ffc5a9129db1.so --extern syntax_pos=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax_pos-47b99ffec2efbd05.so -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/backtrace-sys-ee16f6821aef40e9/out -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/miniz-sys-52504d5ed57fefc2/out` (exit code: 1)
[00:13:04] [RUSTC-TIMING] rustc_traits test:false 28.615
[00:13:23] [RUSTC-TIMING] rustc_incremental test:false 49.088
[00:13:57] [RUSTC-TIMING] rustc_typeck test:false 83.116
[00:13:57] error: build failed
[00:13:57] error: build failed
[00:13:57] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" " jemalloc" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json"
[00:13:57] expected success, got: exit code: 101
[00:13:57] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1155:9
[00:13:57] travis_fold:end:stage0-rustc

[00:13:57] travis_time:end:stage0-rustc:start=1536799845921628135,finish=1536800395025321501,duration=549103693366

---
travis_time:end:0a23c238:start=1536800395853058268,finish=1536800395860147998,duration=7089730
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:00163726
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:06e528dc
travis_time:start:06e528dc
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:01eb6ee6
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2018-09-13T01:00:08Z

💔 Test failed - status-travis

… return type.

davidtwco · 2018-09-13T10:08:01Z

Rebased this.

nikomatsakis · 2018-09-17T15:42:22Z

@bors r+

bors · 2018-09-17T15:42:23Z

📌 Commit 18c1374 has been approved by nikomatsakis

nikomatsakis · 2018-09-17T15:42:44Z

@davidtwco btw, as you have r+ now, you can feel free to do r=whomever after a rebase (where whomever is the person that gave the original r+)

bors · 2018-09-18T06:25:02Z

⌛ Testing commit 18c1374 with merge 36c0ee9...

@nikomatsakis

NLL regresses diagnostic for impl-trait/static-return-lifetime-infered.rs Fixes #53771. r? @nikomatsakis cc @pnkfelix @estebank

bors · 2018-09-18T09:06:36Z

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 36c0ee9 to master...

rust-highfive assigned nikomatsakis Sep 2, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 2, 2018

davidtwco commented Sep 2, 2018

View reviewed changes

src/test/ui/impl-trait/must_outlive_least_region_or_bound.nll.stderr Outdated Show resolved Hide resolved

memoryruins added the A-NLL Area: Non-lexical lifetimes (NLL) label Sep 2, 2018

estebank reviewed Sep 3, 2018

View reviewed changes

src/test/ui/impl-trait/static-return-lifetime-infered.nll.stderr Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

davidtwco force-pushed the issue-53771 branch from c30710f to df4b196 Compare September 4, 2018 17:44

pnkfelix reviewed Sep 4, 2018

View reviewed changes

src/librustc_mir/borrow_check/nll/region_infer/error_reporting/mod.rs Outdated Show resolved Hide resolved

nikomatsakis requested changes Sep 5, 2018

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2018

nikomatsakis approved these changes Sep 7, 2018

View reviewed changes

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 7, 2018

davidtwco force-pushed the issue-53771 branch from cd19ce4 to b1e7c63 Compare September 7, 2018 23:05

nikomatsakis reviewed Sep 11, 2018

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 11, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 12, 2018

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 12, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 13, 2018

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2018

davidtwco added 6 commits September 13, 2018 10:01

Moved helper functions from NiceRegionError to TyCtxt.

78b2164

Added help message for impl trait static constraint.

6bf131f

Don't suggest adding a synthesized region name.

65e2539

Emit appropriate suggestion when there's already 'static bound on the…

7a89e93

… return type.

Updated suggestion/help messages.

37e18b1

Update from TyKind::Anon to TyKind::Opaque

18c1374

davidtwco force-pushed the issue-53771 branch from b1e7c63 to 18c1374 Compare September 13, 2018 10:07

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 17, 2018

bors added a commit that referenced this pull request Sep 18, 2018

Auto merge of #53900 - davidtwco:issue-53771, r=nikomatsakis

36c0ee9

NLL regresses diagnostic for impl-trait/static-return-lifetime-infered.rs Fixes #53771. r? @nikomatsakis cc @pnkfelix @estebank

bors merged commit 18c1374 into rust-lang:master Sep 18, 2018

davidtwco deleted the issue-53771 branch September 18, 2018 09:09

This was referenced Sep 18, 2018

[nll] borrows that must be valid for a free lifetime should explain why #54229

Merged

[NLL] Record more infomation on free region constraints in typeck #54262

Merged

pnkfelix mentioned this pull request Oct 5, 2018

NLL: need a (new) round of review of deltas between .stderr and .nll.stderr output #52663

Closed

NLL regresses diagnostic for impl-trait/static-return-lifetime-infered.rs #53900

NLL regresses diagnostic for impl-trait/static-return-lifetime-infered.rs #53900

Uh oh!

Conversation

davidtwco commented Sep 2, 2018

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

nikomatsakis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nikomatsakis commented Sep 6, 2018

Uh oh!

bors commented Sep 6, 2018

Uh oh!

bors commented Sep 7, 2018

Uh oh!

davidtwco commented Sep 7, 2018

Uh oh!

nikomatsakis Sep 11, 2018

Choose a reason for hiding this comment

Uh oh!

davidtwco Sep 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nikomatsakis commented Sep 11, 2018

Uh oh!

bors commented Sep 11, 2018

Uh oh!

bors commented Sep 12, 2018

Uh oh!

bors commented Sep 12, 2018

Uh oh!

rust-highfive commented Sep 12, 2018

Uh oh!

bors commented Sep 13, 2018

Uh oh!

rust-highfive commented Sep 13, 2018

Uh oh!

bors commented Sep 13, 2018

Uh oh!

davidtwco commented Sep 13, 2018

Uh oh!

nikomatsakis commented Sep 17, 2018

Uh oh!

bors commented Sep 17, 2018

Uh oh!

nikomatsakis commented Sep 17, 2018

Uh oh!

bors commented Sep 18, 2018

Uh oh!

bors commented Sep 18, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

davidtwco Sep 11, 2018 •

edited

Loading