-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve: Split macro prelude into built-in and user-defined parts #53936
Conversation
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
@bors: r+ |
📌 Commit 01a255a6442d821785c0ccf8fc8a3bfb95f445d4 has been approved by |
☔ The latest upstream changes (presumably #53410) made this pull request unmergeable. Please resolve the merge conflicts. |
01a255a
to
4e97cd2
Compare
Updated with a second commit removing |
@bors r=alexcrichton p=1 |
📌 Commit 4e97cd26732bb8191eaa876312d6ca1e2a8e401a has been approved by |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit 4e97cd26732bb8191eaa876312d6ca1e2a8e401a has been approved by |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
☔ The latest upstream changes (presumably #53778) made this pull request unmergeable. Please resolve the merge conflicts. |
4e97cd2
to
62c7d78
Compare
@bors r=alexcrichton |
📌 Commit 62c7d78 has been approved by |
resolve: Split macro prelude into built-in and user-defined parts This is a refactoring that will help to remove `unshadowable_attrs` when #53410 lands. UPDATE: The second commit actually removes `unshadowable_attrs`.
☀️ Test successful - status-appveyor, status-travis |
This is a refactoring that will help to remove
unshadowable_attrs
when #53410 lands.UPDATE: The second commit actually removes
unshadowable_attrs
.