Provide a condition in string-based IO routines #5399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| const strict: uint = 1; | ||
| const replacement: uint = 2; | ||
| const ignore: uint = 3; |
There was a problem hiding this comment.
This is probably better as an enum (enum UTF8Mode { Strict, Replacement, Ignore }), unless there was a particular reason for using the constants?
|
Thank you for your comment. I will do that according to your comment. |
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 2, 2020
Add lint named implicit_saturating_sub Fixes: rust-lang#5399 I've made a basic skeleton of the lint, would love more feedback on how to make it better. changelog: Add lint [`implicit_saturating_sub`]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of Issue #4837
Rust's string-based IO routines should provide a condition for hooking in different behavior when presented with malformed UTF-8.