Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship libLLVM.dylib on OSX #54018

Merged
merged 1 commit into from
Sep 7, 2018
Merged

Conversation

alexcrichton
Copy link
Member

Previously we just weren't shipping this at all as we were only looking for the
Linux version!

Previously we just weren't shipping this at all as we were only looking for the
Linux version!
@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 7, 2018
@alexcrichton
Copy link
Member Author

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

@bors r+ p=1 - want to make sure this lands before beta cut off

@bors
Copy link
Collaborator

bors commented Sep 7, 2018

📌 Commit bd1fb60 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2018
@bors
Copy link
Collaborator

bors commented Sep 7, 2018

⌛ Testing commit bd1fb60 with merge 2ae11a9...

bors added a commit that referenced this pull request Sep 7, 2018
Ship libLLVM.dylib on OSX

Previously we just weren't shipping this at all as we were only looking for the
Linux version!
@bors
Copy link
Collaborator

bors commented Sep 7, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 2ae11a9 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants