-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warn about keywords in macro invocations #54111
warn about keywords in macro invocations #54111
Conversation
@bors p=1 -- Edition RC blocker |
@@ -90,7 +90,7 @@ pub fn register_builtins(store: &mut lint::LintStore, sess: Option<&Session>) { | |||
macro_rules! add_pre_expansion_builtin { | |||
($sess:ident, $($name:ident),*,) => ( | |||
{$( | |||
store.register_early_pass($sess, false, box $name); | |||
store.register_pre_expansion_pass($sess, box $name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, I had all of this PR awhile back except this line, I'm glad you knew this existed!
@bors: r+ |
📌 Commit 5adbdf8 has been approved by |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
3 similar comments
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
⌛ Testing commit 5adbdf8 with merge 16a8a3c03257926e6158393b539f592601539be8... |
💔 Test failed - status-appveyor |
@bors r=alexcrichton |
📌 Commit 0cd8e0d has been approved by |
@bors p=2 Edition critical |
…r=alexcrichton warn about keywords in macro invocations Fixes #53686 r? @alexcrichton
☀️ Test successful - status-appveyor, status-travis |
Fixes #53686
r? @alexcrichton