Make rustc::middle::region::Scope's fields public

[maxdeviant]

This PR makes the following changes to rustc::middle::region::Scope:

• Makes region::Scope's fields public
• Removes the impl Scope block with constructors (as per this comment)
• Updates call sites throughout the compiler

Closes #54122.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[petrochenkov]

@bors r+

[bors]

📌 Commit fa1868d has been approved by petrochenkov

[rust-highfive]

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:57:19] ....................................................................................................
[00:57:22] ....................................................i...............................................
[00:57:25] ....................................................................................................
[00:57:28] ....................................................................................................
[00:57:31] iiiiiiiii...........................................................................................
[00:57:37] ....................................................................................................
[00:57:40] .................................................................................i..................
[00:57:43] ....................................................................................................
[00:57:46] ...................................i.i..ii..........................................................
---
[01:23:32] 
[01:23:32] To learn more, run the command again with --verbose.
[01:23:32] 
[01:23:32] 
[01:23:32] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" " jemalloc" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "rustc_driver" "--" "--quiet"
[01:23:32] 
[01:23:32] 
[01:23:32] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:23:32] Build completed unsuccessfully in 0:35:14
[01:23:32] Build completed unsuccessfully in 0:35:14
[01:23:32] Makefile:58: recipe for target 'check' failed
[01:23:32] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:06dc3821
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[maxdeviant]

@bors retry

[bors]

@maxdeviant: 🔑 Insufficient privileges: not in try users

[maxdeviant]

@petrochenkov CI passed. Does @bors need to be told to do anything (this is my first time contributing to Rust, still getting used to how everything works)?

[petrochenkov]

@maxdeviant
Yes, PRs need to be re-approved after changes, but bors listens only to people from the reviewers list.

@bors r+

[bors]

📌 Commit 2d7176f has been approved by petrochenkov

[bors]

⌛ Testing commit 2d7176f with merge ed94397...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing ed94397 to master...