[beta] Cancel warning for tool_lints

[flip1995]

For the discussion about this, see: rust-lang/rust-clippy#3159

clippy-preview is available on stable since 1.29. So when running cargo +beta clippy on a crate with #![allow(clippy_lint)] a warning is produced, which tells the programmer to change this to #![allow(clippy::clippy_lint)]. But since tool_lints aren't stable yet, this would require a #![feature(tool_lints)]. Features aren't available on stable or beta, so we cannot do this. Even wrapping cfg_attr(clippy) around this won't help, since Clippy can also be run from stable or beta toolchain.

r? @Manishearth

[rust-highfive]

⚠️ Warning ⚠️

• Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

[Manishearth]

Should we instead introduce a check to see if we're on nightly? r=me either way

[flip1995]

I introduced a nightly check to only cancel the warning, if we're not on nightly. Is there a way to test this? I didn't find a compiletest flag for something like "pretend to be a stable build".

We should do this also on the master branch.

[flip1995]

ping @Manishearth is there something else for me to do here?

[Manishearth]

cc @Mark-Simulacrum

I'm not sure, I don't want to approve beta uplifts without knowing the process.

This is r=me for landing on master and beta, just need someone from the release team to look at it

[Mark-Simulacrum]

I would prefer that the patch just unconditionally cancel the warning since this is a beta-only patch (the master patch can be equivalent to the current state, I think).

Feel free to merge with the is_nightly check removed.

[Manishearth]

Sounds good, r=me with the is_nightly check removed (and make a PR to master with the check in place)

[flip1995]

Ok, I changed it to unconditionally cancel the error message again.

I will add the nightly check to master ASAP. I'm planning on making a stabilization PR for the tool_lints until the next 1.31.beta release, so hopefully this can also be removed again soon.

[Manishearth]

@bors r+

sounds good. don't bother with the nightly thing if it's going to be stabilized soon anyway

[bors]

📌 Commit 4e5eba5 has been approved by Manishearth

[bors]

⌛ Testing commit 4e5eba5 with merge 400378d44564e498bbac210378cd97b225e26d50...

[bors]

💔 Test failed - status-travis

[rust-highfive]

The job dist-x86_64-apple of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:05:10]       Memory: 8 GB
[00:05:10]       Boot ROM Version: VMW71.00V.0.B64.1704110547
[00:05:10]       Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
[00:05:10]       SMC Version (system): 2.8f0
[00:05:10]       Serial Number (system): VMNvGv7MQMCs
[00:05:10] 
[00:05:10] hw.ncpu: 4
[00:05:10] hw.byteorder: 1234
[00:05:10] hw.memsize: 8589934592
---
travis_time:start:0a034991
make -j 4 tidy
[00:05:11]     Finished dev [unoptimized] target(s) in 0.51s
[00:05:13] fatal: unable to access 'https://github.com/rust-lang/rust.git/': Could not resolve host: github.com
[00:05:13] thread 'main' panicked at 'command did not execute successfully: "git" "ls-remote" "origin" "beta"
[00:05:13] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:05:13] failed to run: /Users/travis/build/rust-lang/rust/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:05:13] Build completed unsuccessfully in 0:00:02
[00:05:13] Build completed unsuccessfully in 0:00:02
[00:05:13] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:04ceb502
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_fold:start:after_failure.2
travis_time:start:029fe515
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
total 0
drwx------+ 15 travis  staff  510 Jan 25  2018 ..
drwx------   2 travis  staff   68 Dec  6  2017 .
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:06f1c132
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
travis_time:end:06f1c132:start=1538405784833458000,finish=1538405784854431000,duration=20973000
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0c94915e
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:006e9d54
travis_time:start:006e9d54
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:02bdc73a
$ dmesg | grep -i kill
$ dmesg | grep -i kill
Unable to obtain kernel buffer: Operation not permitted
usage: sudo dmesg
travis_fold:end:after_failure.6

Done. Your build exited with 1.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[flip1995]

fatal: unable to access 'https://github.com/rust-lang/rust.git/': Could not resolve host: github.com
sounds unrelated.

[kennytm]

@bors retry

[bors]

⌛ Testing commit 4e5eba5 with merge 779fd2163fa33448d469bdcd28ab4f1122a0618a...

[bors]

💔 Test failed - status-travis

[rust-highfive]

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

Attempting to download s3://rust-lang-ci-sccache2/docker/8824d7134d9785bac81093c3bdbdecd3d0198a4aadd8eb1c9a5343216c92e12b433e1c1817fc2fe06303f24b4d12df9e838e5833274493aa7d10694d0f0a3706
[00:01:35] Attempting with retry: curl -f -L -C - -o /tmp/rustci_docker_cache https://s3-us-west-1.amazonaws.com/rust-lang-ci-sccache2/docker/8824d7134d9785bac81093c3bdbdecd3d0198a4aadd8eb1c9a5343216c92e12b433e1c1817fc2fe06303f24b4d12df9e838e5833274493aa7d10694d0f0a3706
[00:01:35]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[00:01:35]                                  Dload  Upload   Total   Spent    Left  Speed
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[kennytm]

@bors retry #40474

[bors]

⌛ Testing commit 4e5eba5 with merge f11dae2...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: Manishearth
Pushing f11dae2 to beta...