Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UI test for deref recursion limit printing twice #54413

Merged
merged 2 commits into from
Sep 22, 2018
Merged

Add UI test for deref recursion limit printing twice #54413

merged 2 commits into from
Sep 22, 2018

Conversation

memoryruins
Copy link
Contributor

@memoryruins memoryruins commented Sep 21, 2018 •
edited
Loading

Closes #38940

Does NOTE in the test need to be changed to HELP if its in the stderr?
help: consider adding a `#![recursion_limit="20"]` attribute to your crate

It doesn't appear to complaining locally that the line isn't set to HELP in the test, and the guide says

HELP and SUGGESTION*

  • Note: SUGGESTION must follow immediately after HELP.

yet there's no concrete suggestion emitted.

r? @estebank

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2018
@estebank
Copy link
Contributor

It doesn't appear to complaining locally that the line isn't set to HELP in the test, and the guide says

That is odd. Regardless, in order to keep the test file clean it'd be better to remove all the NOTE checks. If the test doesn't include any, it will accept it, but if you add one it will complain about any missing checks (there might be a bug now on this and that's why it's not complaining about the NOTE/HELP distinction). In this case in particular what we want to assure is that the third ERROR doesn't appear, the notes are incidental.

In summary, remove the the NOTE lines. r=me assuming Travis CI is happy.

Thanks for helping with this!

@memoryruins
Copy link
Contributor Author

memoryruins commented Sep 21, 2018 •
edited
Loading

Good to know its the error notes that are essential. Looks like travis caught the notes, so no bug exists other than the environment I was working on ^^ (which has had its own unrelated share of issues recently)

@memoryruins
Copy link
Contributor Author

@bors r=estebank rollup

@bors

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@estebank
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 21, 2018

📌 Commit 70da203 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Sep 21, 2018
@kennytm
Rollup merge of rust-lang#54413 - memoryruins:deref-error-twice, r=es…
eca7b5f 
…tebank

Add UI test for deref recursion limit printing twice

Closes rust-lang#38940

Does ``NOTE`` in the test need to be changed to ``HELP`` if its in the stderr?
``help: consider adding a `#![recursion_limit="20"]` attribute to your crate``

It doesn't appear to complaining locally that the line isn't set to ``HELP`` in the test, and the guide says
 > HELP and SUGGESTION*
> * Note: SUGGESTION must follow immediately after HELP.

yet there's no concrete suggestion emitted.

r? @estebank
@kennytm kennytm mentioned this pull request Sep 21, 2018
Closed
bors added a commit that referenced this pull request Sep 21, 2018
@bors
Auto merge of #54432 - kennytm:rollup, r=kennytm
efaf8bf 
Rollup of 10 pull requests

Successful merges:

 - #53652 (define copy_within on slices)
 - #54261 (Make `dyn` a keyword in the 2018 edition)
 - #54317 (Implement the dbg!(..) macro)
 - #54323 (rustbuild: drop color handling)
 - #54371 (add -Zui-testing to rustdoc)
 - #54374 (Make 'proc_macro::MultiSpan' public.)
 - #54402 (Use no_default_libraries for all NetBSD flavors)
 - #54412 (add applicability to span_suggestion call)
 - #54413 (Add UI test for deref recursion limit printing twice)
 - #54422 (Simplify slice's first(_mut) and last(_mut) with get)
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Sep 22, 2018
@pietroalbini
Rollup merge of rust-lang#54413 - memoryruins:deref-error-twice, r=es…
0bf52b3 
…tebank

Add UI test for deref recursion limit printing twice

Closes rust-lang#38940

Does ``NOTE`` in the test need to be changed to ``HELP`` if its in the stderr?
``help: consider adding a `#![recursion_limit="20"]` attribute to your crate``

It doesn't appear to complaining locally that the line isn't set to ``HELP`` in the test, and the guide says
 > HELP and SUGGESTION*
> * Note: SUGGESTION must follow immediately after HELP.

yet there's no concrete suggestion emitted.

r? @estebank
@pietroalbini pietroalbini mentioned this pull request Sep 22, 2018
Merged
bors added a commit that referenced this pull request Sep 22, 2018
@bors
Auto merge of #54457 - pietroalbini:rollup, r=pietroalbini
5929185 
Rollup of 16 pull requests

Successful merges:

 - #53652 (define copy_within on slices)
 - #54261 (Make `dyn` a keyword in the 2018 edition)
 - #54280 (remove (more) CAS API from Atomic* types where not natively supported)
 - #54323 (rustbuild: drop color handling)
 - #54350 (Support specifying edition in doc test)
 - #54370 (Improve handling of type bounds in `bit_set.rs`.)
 - #54371 (add -Zui-testing to rustdoc)
 - #54374 (Make 'proc_macro::MultiSpan' public.)
 - #54402 (Use no_default_libraries for all NetBSD flavors)
 - #54409 (Detect `for _ in in bar {}` typo)
 - #54412 (add applicability to span_suggestion call)
 - #54413 (Add UI test for deref recursion limit printing twice)
 - #54415 (parser: Tweak function parameter parsing to avoid rollback on succesfull path)
 - #54420 (Compress `Liveness` data some more.)
 - #54422 (Simplify slice's first(_mut) and last(_mut) with get)
 - #54446 (Unify christianpoveda's emails)

Failed merges:

 - #54058 (Introduce the partition_dedup/by/by_key methods for slices)

r? @ghost
bors added a commit that referenced this pull request Sep 22, 2018
@bors
Auto merge of #54457 - pietroalbini:rollup, r=pietroalbini
af50e38 
Rollup of 16 pull requests

Successful merges:

 - #53652 (define copy_within on slices)
 - #54261 (Make `dyn` a keyword in the 2018 edition)
 - #54280 (remove (more) CAS API from Atomic* types where not natively supported)
 - #54323 (rustbuild: drop color handling)
 - #54350 (Support specifying edition in doc test)
 - #54370 (Improve handling of type bounds in `bit_set.rs`.)
 - #54371 (add -Zui-testing to rustdoc)
 - #54374 (Make 'proc_macro::MultiSpan' public.)
 - #54402 (Use no_default_libraries for all NetBSD flavors)
 - #54409 (Detect `for _ in in bar {}` typo)
 - #54412 (add applicability to span_suggestion call)
 - #54413 (Add UI test for deref recursion limit printing twice)
 - #54415 (parser: Tweak function parameter parsing to avoid rollback on succesfull path)
 - #54420 (Compress `Liveness` data some more.)
 - #54422 (Simplify slice's first(_mut) and last(_mut) with get)
 - #54446 (Unify christianpoveda's emails)

Failed merges:

 - #54058 (Introduce the partition_dedup/by/by_key methods for slices)

r? @ghost
@bors bors merged commit 70da203 into rust-lang:master Sep 22, 2018
@memoryruins memoryruins deleted the deref-error-twice branch September 22, 2018 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@memoryruins @estebank @bors @rust-highfive