Lower type ascriptions to HAIR and MIR #54447

KiChjang · 2018-09-21T19:04:08Z

nikomatsakis · 2018-09-21T20:40:30Z

src/librustc_mir/build/expr/stmt.rs

@@ -161,6 +162,41 @@ impl<'a, 'gcx, 'tcx> Builder<'a, 'gcx, 'tcx> {
                );
                block.unit()
            }
+            ExprKind::PlaceTypeAscription { source, user_ty } => {


This code is not in the right place, I don't think. It should go into expr_as_place:

rust/src/librustc_mir/build/expr/as_place.rs

Lines 45 to 50 in 1002e40

fn expr_as_place(

&mut self,

mut block: BasicBlock,

expr: Expr<'tcx>,

mutability: Mutability,

) -> BlockAnd<Place<'tcx>> {

The idea is that each expr kind is implemented in exactly one place, whereever is the "best fit". This particular spot is for "statements" -- control-flow like things.

nikomatsakis · 2018-09-21T20:42:29Z

src/librustc_mir/build/expr/stmt.rs

+                );
+                block.unit()
+            }
+            ExprKind::ValueTypeAscription { source, user_ty } => {


Similarly this should go into as_rvalue, I think?

rust/src/librustc_mir/build/expr/as_rvalue.rs

Lines 49 to 54 in 1002e40

fn expr_as_rvalue(

&mut self,

mut block: BasicBlock,

scope: Option<region::Scope>,

expr: Expr<'tcx>,

) -> BlockAnd<Rvalue<'tcx>> {

Or maybe, actually, it too should go into as_place, and it should just evaluate its argument into a temp and yield the temp as a place (sort of like it does today).

nikomatsakis · 2018-09-21T20:42:51Z

src/librustc_mir/build/expr/stmt.rs

+                let source_span = source.span;
+                let source_ty = source.ty.clone();
+                let temp = this.temp(source_ty.clone(), source_span);
+                unpack!(block = this.into(&temp, block, source));


Here I think you would call as_temp instead of calling into yourself:

rust/src/librustc_mir/build/expr/as_temp.rs

Lines 19 to 27 in 1002e40

/// Compile `expr` into a fresh temporary. This is used when building

/// up rvalues so as to freeze the value that will be consumed.

pub fn as_temp<M>(

&mut self,

block: BasicBlock,

temp_lifetime: Option<region::Scope>,

expr: M,

mutability: Mutability,

) -> BlockAnd<Local>

nikomatsakis · 2018-09-21T20:43:38Z

src/librustc_mir/build/expr/category.rs

-            ExprKind::Scope { .. } => None,
+            ExprKind::Scope { .. }
+            | ExprKind::PlaceTypeAscription { .. }
+            | ExprKind::ValueTypeAscription { .. } => None,


These should not return None -- rather I think they should both return Some(Category::Place).

KiChjang · 2018-09-22T08:36:13Z

So, something is wrong with type ascriptions in const contexts... this simple program would overflow its stack:

#![feature(type_ascription)]

const C1: u8 = 10: u8;

fn main() {}

I'm not exactly sure how to debug this.

eddyb · 2018-09-22T09:03:37Z

src/librustc_mir/hair/mod.rs

+    },
+    ValueTypeAscription {
+        source: ExprRef<'tcx>,
+        /// Type that the user gave to this expression


This is on only one variant.

rust-highfive · 2018-09-22T10:25:37Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:53:57] ....................................................................................................
[00:54:00] .....................................................i..............................................
[00:54:03] ....................................................................................................
[00:54:07] ....................................................................................................
[00:54:09] .iiiiiiiii..........................................................................................
[00:54:16] ....................................................................................................
[00:54:19] .....................................................................................i..............
[00:54:21] ....................................................................................................
[00:54:24] ........................................i.i..ii.....................................................
---
[00:59:47] ........................................i...........................................................
[00:59:58] ....................................................................................................
[01:00:12] ....................................................................................................
[01:00:22] ....................................................................................................
[01:00:37] ................i.....................................................F.............................

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1b9b4a3c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:0851c9b9:start=1537611933172747007,finish=1537611933177792663,duration=5045656
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:06b9dfc3
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; ttravis_fold:start:crashlog
obj/cores/core.21434.!checkout!obj!build!x86_64-unknown-linux-gnu!stage2!bin!rustc
[New LWP 21434]
warning: Could not load shared library symbols for 14 libraries, e.g. /lib/x86_64-linux-gnu/libc.so.6.
Use the "info sharedlibrary" command to see the complete listing.
Do you need "set solib-search-path" or "set sysroot"?

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

nikomatsakis

Looks like we need some tests! Do you need help to write up a few tests?

nikomatsakis · 2018-09-25T18:07:18Z

@KiChjang when you get a chance, can you add some tests into src/test/ui/nll/user-annotations/ for this feature?

Did you plan to support casts, too?

KiChjang · 2018-09-25T18:52:13Z

@nikomatsakis Just added a UI test for user ascribed types, going to be working on casts next.

nikomatsakis

Looks good so far! will wait for the cast stuff

KiChjang · 2018-09-29T16:58:58Z

src/librustc_mir/hair/cx/expr.rs

@@ -718,7 +718,23 @@ fn make_mirror_unadjusted<'a, 'gcx, 'tcx>(cx: &mut Cx<'a, 'gcx, 'tcx>,
                ExprKind::Cast { source }
            }
        }
-        hir::ExprKind::Type(ref source, _) => return source.make_mirror(cx),
+        hir::ExprKind::Type(ref source, ref ty) => {
+            if let Some(user_ty) = cx.tables.user_provided_tys().get(ty.hir_id) {


I think I should use expect here instead of silently returning the mirror of the source expression when we can't find the user_ty in the table.

rust-highfive · 2018-10-02T17:21:48Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:44:04] .................................................................................................... 300/4320
[00:44:07] .................................................................................................... 400/4320
[00:44:10] .................................................................................................... 500/4320
[00:44:13] .......................i............................................................................ 600/4320
[00:44:18] ..........................F...............................................F......................... 700/4320
[00:44:26] ...................................................iiiii............................................ 900/4320
[00:44:29] .................................................................................................... 1000/4320
[00:44:31] .................................................................................................... 1100/4320
[00:44:33] .................................................................................................... 1200/4320
---
[00:45:16] .................................................................................................... 2700/4320
[00:45:18] i................................................................................................... 2800/4320
[00:45:21] ............................................................i.i..ii................................. 2900/4320
[00:45:25] .................................................................................................... 3000/4320
[00:45:28] ..............................................................F.................................i... 3100/4320
[00:45:34] .................................................................................................... 3300/4320
[00:45:36] .................................................................................................... 3400/4320
[00:45:39] .................................................................................................... 3500/4320
[00:45:43] ......................................i............................................................. 3600/4320
---
[00:46:06] 
[00:46:06] ---- [ui] ui/consts/const-eval/conditional_array_execution.rs stdout ----
[00:46:06] diff of stderr:
[00:46:06] 
[00:46:06] 21 LL |     println!("{}", FOO);
[00:46:06] 23 
[00:46:06] - error[E0080]: erroneous constant used
[00:46:06] + error[E0080]: could not evaluate constant
[00:46:06] 25   --> $DIR/conditional_array_execution.rs:19:20
[00:46:06] 25   --> $DIR/conditional_array_execution.rs:19:20
[00:46:06] 26    |
[00:46:06] 27 LL |     println!("{}", FOO);
[00:46:06] 
[00:46:06] 28    |                    ^^^ referenced constant has errors
[00:46:06] - error: aborting due to 2 previous errors
[00:46:06] + error[E0080]: constant evaluation error
[00:46:06] +   --> $DIR/conditional_array_execution.rs:15:1
[00:46:06] +    |
[00:46:06] +    |
[00:46:06] + LL | const FOO: u32 = [X - Y, Y - X][(X < Y) as usize];
[00:46:06] +    |                   |
[00:46:06] +    |                   attempt to subtract with overflow
[00:46:06] + 
[00:46:06] + error: aborting due to 3 previous errors
[00:46:06] + error: aborting due to 3 previous errors
[00:46:06] 31 
[00:46:06] 32 For more information about this error, try `rustc --explain E0080`.
[00:46:06] 33 
[00:46:06] 
[00:46:06] 
[00:46:06] The actual stderr differed from the expected stderr.
[00:46:06] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/tnLL |     println!(\"{}\", FOO);\n   |                    ^^^\n\n"}
[00:46:06] {"message":"could not evaluate constant","code":{"code":"E0080","explanation":"\nThis error indicates that the compiler was unable to sensibly evaluate an\nconstant expression that had to be evaluated. Attempting to divide by 0\nor causing integer overflow are two ways to induce this error. For example:\n\n```compile_fail,E0080\nenum Enum {\n    X = (1 << 500),\n    Y = (1 / 0)\n}\n```\n\nEnsure that the expressions given can be evaluated as the desired integer type.\nSee the FFI section of the Reference for more information about using a custom\ninteger type:\n\nhttps://doc.rust-lang.org/reference.html#ffi-attributes\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/consts/const-eval/conditional_array_execution.rs","byte_start":646,"byte_end":649,"line_start":19,"line_end":19,"column_start":20,"column_end":23,"is_primary":true,"text":[{"text":"    println!(\"{}\", FOO);","highlight_start":20,"highlight_end":23}],"label":"referenced constant has errors","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0080]: could not evaluate constant\n  --> /checkout/src/test/ui/consts/const-eval/conditional_array_execution.rs:19:20\n   |\nLL |     println!(\"{}\", FOO);\n   |                    ^^^ referenced constant has errors\n\n"}
[00:46:06] {"message":"constant evaluation error","code":{"code":"E0080","explanation":"\nThis error indicates that the compiler was unable to sensibly evaluate an\nconstant expression that had to be evaluated. Attempting to divide by 0\nor causing integer overflow are two ways to induce this error. For example:\n\n```compile_fail,E0080\nenum Enum {\n    X = (1 << 500),\n    Y = (1 / 0)\n}\n```\n\nEnsure that the expressions given can be evaluated as the desired integer type.\nSee the FFI section of the Reference for more information about using a custom\ninteger type:\n\nhttps://doc.rust-lang.org/reference.html#ffi-attributes\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/consts/const-eval/conditional_array_execution.rs","byte_start":542,"byte_end":547,"line_start":15,"line_end":15,"column_start":19,"column_end":24,"is_primary":false,"text":[{"text":"const FOO: u32 = [X - Y, Y - X][(X < Y) as usize];","highlight_start":19,"highlight_end":24}],"label":"attempt to subtract with overflow","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/consts/const-eval/conditional_array_execution.rs","byte_start":524,"byte_end":574,"line_start":15,"line_end":15,"column_start":1,"column_end":51,"is_primary":true,"text":[{"text":"const FOO: u32 = [X - Y, Y - X][(X < Y) as usize];","highlight_start":1,"highlight_end":51}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0080]: constant evaluation error\n  --> /checkout/src/test/ui/consts/const-eval/conditional_array_execution.rs:15:1\n   |\nLL | const FOO: u32 = [X - Y, Y - X][(X < Y) as usize];\n   | ^^^^^^^^^^^^^^^^^^-----^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   |                   |\n   |                   attempt to subtract with overflow\n\n"}
[00:46:06] {"message":"aborting due to 3 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 3 previous errors\n\n"}
[00:46:06] {"message":"For more information about this error, try `rustc --explain E0080`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0080`.\n"}
[00:46:06] ------------------------------------------
[00:46:06] 
[00:46:06] thread '[ui] ui/consts/const-eval/conditional_array_execution.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3267:9
[00:46:06] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:46:06] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:46:06] 
[00:46:06] ---- [ui] ui/consts/const-eval/promoted_errors.rs stdout ----
[00:46:06] diff of stderr:
[00:46:06] 
[00:46:06] 34 LL |     println!("{}", 1/(false as u32));
[00:46:06] 36 
[00:46:06] + warning: this expression will panic at runtime
[00:46:06] +   --> $DIR/promoted_errors.rs:24:20
[00:46:06] +    |
[00:46:06] +    |
[00:46:06] + LL |     println!("{}", 1/(false as u32));
[00:46:06] +    |                    ^^^^^^^^^^^^^^^^ attempt to divide by zero
[00:46:06] + 
[00:46:06] 37 warning: attempt to divide by zero
[00:46:06] 39    |
[00:46:06] 
[00:46:06] 
[00:46:06] The actual stderr differed from the expected stderr.
[00:46:06] The actual stderr differed from the expected stderr.
[00:46:06] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/promoted_errors/promoted_errors.stderr
[00:46:06] To update references, rerun the tests and pass the `--bless` flag
[00:46:06] To only update this sprrors.rs","byte_start":475,"byte_end":484,"line_start":11,"line_end":11,"column_start":9,"column_end":18,"is_primary":true,"text":[{"text":"#![warn(const_err)]","highlight_start":9,"highlight_end":18}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null}],"rendered":"warning: this expression will panic at runtime\n  --> /checkout/src/test/ui/consts/const-eval/promoted_errors.rs:17:14\n   |\nLL |     let _x = 0u32 - 1;\n   |              ^^^^^^^^ attempt to subtract with overflow\n   |\nnote: lint level defined here\n  --> /checkout/src/test/ui/consts/const-eval/promoted_errors.rs:11:9\n   |\nLL | #![warn(const_err)]\n   |         ^^^^^^^^^\n\n"}
[00:46:06] {"message":"attempt to divide by zero","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/consts/const-eval/promoted_errors.rs","byte_start":633,"byte_end":640,"line_start":19,"line_end":19,"column_start":20,"column_end":27,"is_primary":true,"text":[{"text":"    println!(\"{}\", 1/(1-1));","highlight_start":20,"highlight_end":27}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: attempt to divide by zero\n  --> /checkout/src/test/ui/consts/const-eval/promoted_errors.rs:19:20\n   |\nLL |     println!(\"{}\", 1/(1-1));\n   |                    ^^^^^^^\n\n"}
[00:46:06] {"message":"attempt to divide by zero","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/consts/const-eval/promoted_errors.rs","byte_start":680,"byte_end":687,"line_start":21,"line_end":21,"column_start":14,"column_end":21,"is_primary":true,"text":[{"text":"    let _x = 1/(1-1);","highlight_start":14,"highlight_end":21}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: attempt to divide by zero\n  --> /checkout/src/test/ui/consts/const-eval/promoted_errors.rs:21:14\n   |\nLL |     let _x = 1/(1-1);\n   |              ^^^^^^^\n\n"}
[00:46:06] {"message":"this expression will panic at runtime","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/consts/const-eval/promoted_errors.rs","byte_start":680,"byte_end":687,"line_start":21,"line_end":21,"column_start":14,"column_end":21,"is_primary":true,"text":[{"text":"    let _x = 1/(1-1);","highlight_start":14,"highlight_end":21}],"label":"attempt to divide by zero","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: this expression will panic at runtime\n  --> /checkout/src/test/ui/consts/const-eval/promoted_errors.rs:21:14\n   |\nLL |     let _x = 1/(1-1);\n   |              ^^^^^^^ attempt to divide by zero\n\n"}
[00:46:06] {"message":"attempt to divide by zero","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/consts/const-eval/promoted_errors.rs","byte_start":756,"byte_end":772,"line_start":24,"line_end":24,"column_start":20,"column_end":36,"is_primary":true,"text":[{"text":"    println!(\"{}\", 1/(false as u32));","highlight_start":20,"highlight_end":36}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: attempt to divide by zero\n  --> /checkout/src/test/ui/consts/const-eval/promoted_errors.rs:24:20\n   |\nLL |     println!(\"{}\", 1/(false as u32));\n   |                    ^^^^^^^^^^^^^^^^\n\n"}
[00:46:06] {"message":"this expression will panic at runtime","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/consts/const-eval/promoted_errors.rs","byte_start":756,"byte_end":772,"line_start":24,"line_end":24,"column_start":20,"column_end":36,"is_primary":true,"text":[{"text":"    println!(\"{}\", 1/(false as u32));","highlight_start":20,"highlight_end":36}],"label":"attempt to divide by zero","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: this expression will panic at runtime\n  --> /checkout/src/test/ui/consts/const-eval/promoted_errors.rs:24:20\n   |\nLL |     println!(\"{}\", 1/(false as u32));\n   |                    ^^^^^^^^^^^^^^^^ attempt to divide by zero\n\n"}
[00:46:06] {"message":"attempt to divide by zero","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/consts/const-eval/promoted_errors.rs","byte_start":812,"byte_end":828,"line_start":26,"line_end":26,"column_start":14,"column_end":30,"is_primary":true,"text":[{"text":"    let _x = 1/(false as u32);","highlight_start":14,"highlight_end":30}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: attempt to divide by zero\n  --> /checkout/src/test/ui/consts/const-eval/promoted_errors.rs:26:14\n   |\nLL |     let _x = 1/(false as u32);\n   |              ^^^^^^^^^^^^^^^^\n\n"}
[00:46:06] {"message":"this expression will panic at runtime","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/consts/const-eval/promoted_errors.rs","byte_start":812,"byte_end":828,"line_start":26,"line_end":26,"column_start":14,"column_end":30,"is_primary":true,"text":[{"text":"    let _x = 1/(false as u32);","highlight_start":14,"highlight_end":30}],"label":"attempt to divide by zero","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: this expression will panic at runtime\n  --> /checkout/src/test/ui/consts/const-eval/promoted_errors.rs:26:14\n   |\nLL |     let _x = 1/(false as u32);\n   |              ^^^^^^^^^^^^^^^^ attempt to divide by zero\n\n"}
[00:46:06] ------------------------------------------
[00:46:06] 
[00:46:06] thread '[ui] ui/consts/const-eval/promoted_errors.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3267:9
[00:46:06] 
[00:46:06] 
[00:46:06] ---- [ui] ui/nll/user-annotations/cast_static_lifetime.rs stdout ----
[00:46:06] 
[00:46:06] error: ui test compiled successfully!
[00:46:06] status: exit code: 0
[00:46:06] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/nll/user-annotations/cast_static_lifetime.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/nll/user-annotations/cast_static_lifetime/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/nll/user-annotations/cast_static_lifetime/auxiliary" "-A" "unused"
[00:46:06] ------------------------------------------
[00:46:06] 
[00:46:06] ------------------------------------------
[00:46:06] stderr:
---
[00:46:06] 
[00:46:06] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:499:22
[00:46:06] 
[00:46:06] 
[00:46:06] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-5.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "5.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:46:06] 
[00:46:06] 
[00:46:06] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:46:06] Build completed unsuccessfully in 0:03:07
[00:46:06] Build completed unsuccessfully in 0:03:07
[00:46:06] Makefile:58: recipe for target 'check' failed
[00:46:06] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:06d9a55c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

nikomatsakis · 2018-10-03T20:28:44Z

@bors r+

bors · 2018-10-03T20:28:45Z

📌 Commit 8380b25 has been approved by nikomatsakis

bors · 2018-10-04T00:26:11Z

⌛ Testing commit 8380b25 with merge d078728...

@nikomatsakis

Lower type ascriptions to HAIR and MIR Fixes #54331. r? @nikomatsakis

bors · 2018-10-04T03:08:17Z

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing d078728 to master...

Move is_place_expr to be a method on hir::Expr

8132d4e

rust-highfive assigned nikomatsakis Sep 21, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2018

KiChjang changed the title ~~Issue 54331~~ Lower type ascriptions to HAIR and MIR Sep 21, 2018

This comment has been minimized.

Sign in to view

nikomatsakis requested changes Sep 21, 2018

View reviewed changes

KiChjang force-pushed the issue-54331 branch from 0e94459 to ca114d6 Compare September 21, 2018 21:41

This comment has been minimized.

Sign in to view

memoryruins added the A-NLL Area: Non-lexical lifetimes (NLL) label Sep 21, 2018

eddyb reviewed Sep 22, 2018

View reviewed changes

KiChjang force-pushed the issue-54331 branch from ca114d6 to 1c731df Compare September 22, 2018 09:22

nikomatsakis reviewed Sep 24, 2018

View reviewed changes

nikomatsakis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2018

nikomatsakis approved these changes Sep 27, 2018

View reviewed changes

KiChjang commented Sep 29, 2018

View reviewed changes

KiChjang and others added 3 commits September 29, 2018 10:34

Lower type ascriptions to HAIR and MIR

fba9d14

avoid infinite loop in MIR lowering

4a293a3

Add UI test for preserving user types in type ascriptions

8380b25

KiChjang force-pushed the issue-54331 branch from 7a94ed2 to 8380b25 Compare September 29, 2018 17:34

KiChjang force-pushed the issue-54331 branch from df48a62 to 8380b25 Compare October 3, 2018 20:17

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 3, 2018

bors added a commit that referenced this pull request Oct 4, 2018

Auto merge of #54447 - KiChjang:issue-54331, r=nikomatsakis

d078728

Lower type ascriptions to HAIR and MIR Fixes #54331. r? @nikomatsakis

bors merged commit 8380b25 into rust-lang:master Oct 4, 2018

KiChjang deleted the issue-54331 branch October 4, 2018 18:51

pnkfelix mentioned this pull request Nov 9, 2018

apint fails to compile on beta #55806

Closed

spastorino mentioned this pull request Jun 10, 2020

Regression: Not well-formed HRTB doesn't compile #55498

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lower type ascriptions to HAIR and MIR #54447

Lower type ascriptions to HAIR and MIR #54447

KiChjang commented Sep 21, 2018

This comment has been minimized.

nikomatsakis Sep 21, 2018

nikomatsakis Sep 21, 2018

nikomatsakis Sep 21, 2018

nikomatsakis Sep 21, 2018

This comment has been minimized.

KiChjang commented Sep 22, 2018

eddyb Sep 22, 2018

KiChjang Sep 22, 2018

rust-highfive commented Sep 22, 2018

nikomatsakis left a comment

nikomatsakis commented Sep 25, 2018

KiChjang commented Sep 25, 2018

nikomatsakis left a comment

KiChjang Sep 29, 2018

rust-highfive commented Oct 2, 2018

nikomatsakis commented Oct 3, 2018

bors commented Oct 3, 2018

bors commented Oct 4, 2018

bors commented Oct 4, 2018

	fn expr_as_place(
	&mut self,
	mut block: BasicBlock,
	expr: Expr<'tcx>,
	mutability: Mutability,
	) -> BlockAnd<Place<'tcx>> {

	fn expr_as_rvalue(
	&mut self,
	mut block: BasicBlock,
	scope: Option<region::Scope>,
	expr: Expr<'tcx>,
	) -> BlockAnd<Rvalue<'tcx>> {

	/// Compile `expr` into a fresh temporary. This is used when building
	/// up rvalues so as to freeze the value that will be consumed.
	pub fn as_temp<M>(
	&mut self,
	block: BasicBlock,
	temp_lifetime: Option<region::Scope>,
	expr: M,
	mutability: Mutability,
	) -> BlockAnd<Local>

Lower type ascriptions to HAIR and MIR #54447

Lower type ascriptions to HAIR and MIR #54447

Conversation

KiChjang commented Sep 21, 2018

This comment has been minimized.

nikomatsakis Sep 21, 2018

Choose a reason for hiding this comment

nikomatsakis Sep 21, 2018

Choose a reason for hiding this comment

nikomatsakis Sep 21, 2018

Choose a reason for hiding this comment

nikomatsakis Sep 21, 2018

Choose a reason for hiding this comment

This comment has been minimized.

KiChjang commented Sep 22, 2018

eddyb Sep 22, 2018

Choose a reason for hiding this comment

KiChjang Sep 22, 2018

Choose a reason for hiding this comment

rust-highfive commented Sep 22, 2018

nikomatsakis left a comment

Choose a reason for hiding this comment

nikomatsakis commented Sep 25, 2018

KiChjang commented Sep 25, 2018

nikomatsakis left a comment

Choose a reason for hiding this comment

KiChjang Sep 29, 2018

Choose a reason for hiding this comment

rust-highfive commented Oct 2, 2018

nikomatsakis commented Oct 3, 2018

bors commented Oct 3, 2018

bors commented Oct 4, 2018

bors commented Oct 4, 2018