Removed slice <-> view distinction in vec and str #5466
Closed
+151
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renamed str::slice -> slice_DBG_UNIQ changed vec slice method -> to_owned() renamed vec view method -> slice_V_DBG_BRWD
…Q -> slice_unique
bors
added a commit
that referenced
this pull request
Mar 21, 2013
A slice now always refers to something that returns an borrowed pointer, views don't exist anymore. If you want to have an explictit copy of a slice, use `to_owned()`
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 2, 2020
…=flip1995 large_enum_variant: Report sizes of variants This reports the sizes of the largest and second-largest variants. Closes rust-lang#5459 changelog: `large_enum_variant`: Report the sizes of the largest and second-largest variants.
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 2, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#5226 (Add lint for explicit deref and deref_mut method calls) - rust-lang#5248 (Add lint on large non scalar const) - rust-lang#5430 (Disallow bit-shifting in integer_arithmetic) - rust-lang#5466 (large_enum_variant: Report sizes of variants) - rust-lang#5468 (Zero single char names) Failed merges: r? @ghost changelog: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A slice now always refers to something that returns an borrowed pointer, views don't exist anymore. If you want to have an explictit copy of a slice, use
to_owned()