Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for some E-needstest issues #54823

Merged
merged 3 commits into from
Oct 7, 2018
Merged

Conversation

euclio
Copy link
Contributor

@euclio euclio commented Oct 4, 2018

Fixes #28134.
Fixes #24338.
Fixes #29743.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2018
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 4, 2018

📌 Commit 0501ee2 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2018
@bors
Copy link
Contributor

bors commented Oct 7, 2018

⌛ Testing commit 0501ee2 with merge 987a50b...

bors added a commit that referenced this pull request Oct 7, 2018
Add tests for some E-needstest issues

Fixes #28134.
Fixes #24338.
Fixes #29743.
@bors
Copy link
Contributor

bors commented Oct 7, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 987a50b to master...

@bors bors merged commit 0501ee2 into rust-lang:master Oct 7, 2018
@euclio euclio deleted the needs-test branch October 7, 2018 16:34
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2021
…enkov

Move some tests to more reasonable directories - 2

All tests with a score equal or greater than 1.0 were moved to their respective directories by issuing

```bash
cat FILE | tr -s " " | tr -d '():' | sort -k3 | awk '$3 >= 1' | cut -d " " -f1-2 | sed 's;\\;/;g' | xargs -n2 git mv
```
**Observation**: The first column values is the only column with results greater zero

To attest the confidentiality of the model, some manual revision of at least of tests is needed and this process will be tracked in the following list:

* `src/test/ui/abi/issue-28676.rs` OK rust-lang#28676
* `src/test/ui/array-slice-vec/issue-15730.rs` OK
* `src/test/ui/associated-types/issue-24338.rs` OK rust-lang#54823
* `src/test/ui/associated-types/issue-48551.rs` Looks OK rust-lang#48551
* `src/test/ui/associated-types/issue-50301.rs` Looks OK rust-lang#63577

...

cc rust-lang#73494
r? `@petrochenkov`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants