A handful of random string-related improvements #54932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Thanks! |
alexcrichton
reviewed
Oct 9, 2018
src/build_helper/lib.rs
Outdated
| @@ -91,13 +92,13 @@ pub fn try_run_suppressed(cmd: &mut Command) -> bool { | |||
| output.status.success() | |||
| } | |||
|
|
|||
| pub fn gnu_target(target: &str) -> String { | |||
| pub fn gnu_target(target: &str) -> Cow<str> { | |||
There was a problem hiding this comment.
This can just be &str I believe without the need for cow. This isn't ever really hot code anyway
There was a problem hiding this comment.
Oh yeah, silly me; fixed. The code is not hot for sure, but I don't mind improving it anyway ^^.
ljedrz
force-pushed
the
a_handful_of_string_improvements
branch
from
0821630 to
a01a994
Compare
|
@bors: r+ |
|
📌 Commit a01a994 has been approved by |
bors
added
S-waiting-on-bors
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Oct 11, 2018
…ents, r=alexcrichton A handful of random string-related improvements - remove a few allocations in `errors/diagnostic` - make `build_helper::gnu_target` return `Cow<str>`
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 12, 2018
…ents, r=alexcrichton A handful of random string-related improvements - remove a few allocations in `errors/diagnostic` - make `build_helper::gnu_target` return `Cow<str>`
bors
added a commit
that referenced
this pull request
Oct 12, 2018
Rollup of 16 pull requests Successful merges: - #54755 (Documents reference equality by address (#54197)) - #54811 (During rustc bootstrap, make default for `optimize` independent of `debug`) - #54825 (NLL says "borrowed content" instead of more precise "dereference of raw pointer") - #54860 (Add doc comments about safest way to initialize a vector of zeros) - #54869 (Fix mobile docs) - #54891 (Fix tracking issue for Once::is_completed) - #54913 (doc fix: it's auto traits that make for automatic implementations) - #54920 (Fix handling of #[must_use] on unit and uninhabited types) - #54932 (A handful of random string-related improvements) - #54936 (impl Eq+Hash for TyLayout) - #54950 (std: Synchronize global allocator on wasm32) - #54956 ("(using ..." doesn't have the matching ")") - #54958 (add a macro for static (compile-time) assertions) - #54967 (Remove incorrect span for second label inner macro invocation) - #54983 (Fix slice's benchmarks) - #54989 (Fix spelling in the documentation to htmldocck.py) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
errors/diagnosticbuild_helper::gnu_targetreturnCow<str>