Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add is_sorted to Iterator and [T] #55045

Merged
merged 7 commits into from
Jan 21, 2019
Merged

Add is_sorted to Iterator and [T] #55045

merged 7 commits into from
Jan 21, 2019

Commits on Jan 18, 2019

  1. Add initial impl of is_sorted to Iterator

    @kleimkuhler
    kleimkuhler committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    8dea0d0 View commit details
    Browse the repository at this point in the history

  2. Add is_sorted impl for [T]

    @kleimkuhler
    kleimkuhler committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    02477f6 View commit details
    Browse the repository at this point in the history

  3. Add is_sorted unstable documentation

    @kleimkuhler
    kleimkuhler committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    ce47dde View commit details
    Browse the repository at this point in the history

  4. Improve documentation and slice impl

    @kleimkuhler
    kleimkuhler committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    ccc027e View commit details
    Browse the repository at this point in the history

  5. Compare pairs with slice::windows

    @kleimkuhler
    kleimkuhler committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    67729b4 View commit details
    Browse the repository at this point in the history

  6. Override Iterator::is_sorted_by in slice::Iter impl 

    Additionally, the root implementation was changed a bit: it now uses
`all` instead of coding that logic manually.

To avoid duplicate code, the inherent `[T]::is_sorted_by` method now
calls `self.iter().is_sorted_by(...)`. This should always be inlined
and not result in overhead.
    @LukasKalbertodt @kleimkuhler
    LukasKalbertodt authored and kleimkuhler committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    54f1124 View commit details
    Browse the repository at this point in the history

  7. Correct error location indicated by comments

    @kleimkuhler
    kleimkuhler committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    b4766f8 View commit details
    Browse the repository at this point in the history