turn std::oldmap into a wrapper around LinearMap #5509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A test fails because the crate hash depends on the order of the dependencies in a |
Closed
bors
added a commit
that referenced
this pull request
Mar 26, 2013
The reasoning for doing it this way is that it's much easier to transition method-by-method to the `Map` API than trying to do the migration all at once. I found an issue unrelated to my changes in one of the run-fail tests - if it uses `LinearMap`, it still fails but exits with 0. I xfailed it for now and opened [an issue](#5512), because it's not caused by these changes.
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 2, 2020
…hiaskrgr Use more diagnostic items In particular for: * `VecDeque` * `String` * `Mutex` * `HashMap` * `HashSet` cc rust-lang#71414 rust-lang#5393 --- changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reasoning for doing it this way is that it's much easier to transition method-by-method to the
MapAPI than trying to do the migration all at once.I found an issue unrelated to my changes in one of the run-fail tests - if it uses
LinearMap, it still fails but exits with 0. I xfailed it for now and opened an issue, because it's not caused by these changes.