[WIP] Bump system LLVM version to 7 #55176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Started thread: https://internals.rust-lang.org/t/rust-vs-llvm/8604 Don't merge. |
kennytm
added
S-blocked
nikomatsakis
changed the title
|
Tagging as |
Merged
|
☔ The latest upstream changes (presumably #56642) made this pull request unmergeable. Please resolve the merge conflicts. |
|
It does not appear that there is any more discussion on the linked thread. There doesn’t appear to be any sort of consensus... |
|
@glandium is this PR still necessary ? |
|
Probably not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My immediate goal with this PR is to see if the change works on Travis. There is much discussion to have related to system LLVM, Travis, and the minimum supported version of system LLVM, and I'm not sure this is the right avenue. I'll probably post something on internals.rust-lang.org.