Skip to content

pick a reference issue for absolute-paths future incompatibility info #55231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2018
Merged

pick a reference issue for absolute-paths future incompatibility info #55231

merged 1 commit into from
Oct 23, 2018

Conversation

zackmdavis
Copy link
Member

It would be kind of embarrassing to ship with the "issue TBD" message!

@rust-highfive
Copy link
Contributor

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2018
@rust-highfive
Copy link
Contributor

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:49:37] .................................................................................................... 2200/4658
[00:49:41] ....................................i............................................................... 2300/4658
[00:49:45] .................................................................................................... 2400/4658
[00:49:48] .................................................................................................... 2500/4658
[00:49:52] ...................................................iiiiiiiii........................................ 2600/4658
[00:49:58] .................................................................................................... 2800/4658
[00:50:02] .................................................................................................... 2900/4658
[00:50:05] .................................................................................i.................. 3000/4658
[00:50:08] .................................................................................................... 3100/4658
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:02:50] 
[01:02:50] running 111 tests
[01:02:53] i..ii...iii.......i...i.........i..iii...........i.....i.....ii...i.i.ii..............i...ii..ii.i.. 100/111
[01:02:53] ..iiii.....
[01:02:53] 
[01:02:53]  finished in 3.434
[01:02:53] travis_fold:end:test_codegen

---
[01:04:11] 25 
[01:04:11] 
[01:04:11] 
[01:04:11] The actual stderr differed from the expected stderr.
[01:04:11] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/rust-2018/suggestions-not-always-applicable/suggestions-not-always-applicable.stderr
[01:04:11] To update references, rerun the tests and pass the `--bless` flag
[01:04:11] To only update this specific test, also pass `--test-args rust-2018/suggestions-not-always-applicable.rs`
[01:04:11] error: 1 errors occurred comparing output.
[01:04:11] status: exit code: 0
[01:04:11] status: exit code: 0
[01:04:11] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/rust-2018/suggestions-not-always-applicable.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/rust-2018/suggestions-not-always-applicable/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2015" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/rust-2018/suggestions-not-always-applicable/auxiliary" "-A" "unused"
[01:04:11] ------------------------------------------
[01:04:11] 
[01:04:11] ------------------------------------------
[01:04:11] stderr:

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@zackmdavis
pick a reference issue for absolute-paths future incompatibility info
1ddbd81 
It would be kind of embarrassing to ship with the "issue TBD" message!
@oli-obk
Copy link
Contributor

oli-obk commented Oct 22, 2018

@bors r+

@oli-obk oli-obk added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 22, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Oct 22, 2018

Nominating for beta due to concerns about shipping with TBD in an error message

@bors
Copy link
Collaborator

bors commented Oct 22, 2018

📌 Commit 1ddbd81 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2018
@Mark-Simulacrum
Copy link
Member

@bors p=5 beta

@Mark-Simulacrum Mark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 23, 2018
@Mark-Simulacrum
Copy link
Member

Accepting for beta due to close release deadline

@bors
Copy link
Collaborator

bors commented Oct 23, 2018

⌛ Testing commit 1ddbd81 with merge 979fb16...

bors added a commit that referenced this pull request Oct 23, 2018
@bors
Auto merge of #55231 - zackmdavis:determinate, r=oli-obk
979fb16 
pick a reference issue for absolute-paths future incompatibility info

It would be kind of embarrassing to ship with the "issue TBD" message!
@bors
Copy link
Collaborator

bors commented Oct 23, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing 979fb16 to master...

@bors bors merged commit 1ddbd81 into rust-lang:master Oct 23, 2018
@pietroalbini pietroalbini mentioned this pull request Oct 23, 2018
Merged
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 23, 2018
bors added a commit that referenced this pull request Oct 23, 2018
@bors
Auto merge of #55289 - pietroalbini:beta-backports, r=pietroalbini
c977fb2 
[beta] Rollup backports

Merged and approved:

* #55231: pick a reference issue for absolute-paths future incompatibility info
* #55224: Use a keyword in raw identifier example

r? @ghost
bors added a commit that referenced this pull request Oct 23, 2018
@bors
Auto merge of #55289 - pietroalbini:beta-backports, r=pietroalbini
f33946f 
[beta] Rollup backports

Merged and approved:

* #55231: pick a reference issue for absolute-paths future incompatibility info
* #55224: Use a keyword in raw identifier example

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zackmdavis @rust-highfive @oli-obk @bors @Mark-Simulacrum @pietroalbini