Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the ICE from #55223 to a hard error #55262

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Change the ICE from #55223 to a hard error #55262

merged 1 commit into from
Nov 7, 2018

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Oct 22, 2018 •
edited
Loading

@oli-obk oli-obk force-pushed the dangling_alloc_id_ice branch from 4978e7f to 9f0a352 Compare October 22, 2018 13:45
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 22, 2018
@RalfJung
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 23, 2018

📌 Commit 2d960a5 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2018
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Oct 23, 2018
@pietroalbini
Rollup merge of rust-lang#55262 - oli-obk:dangling_alloc_id_ice, r=Ra…
1197831 
…lfJung

Change the ICE from rust-lang#55223 to a hard error

cc @SimonSapin

r? @RalfJung
@pietroalbini pietroalbini mentioned this pull request Oct 23, 2018
Closed
@RalfJung RalfJung mentioned this pull request Oct 24, 2018
Closed
@kennytm kennytm mentioned this pull request Oct 24, 2018
Closed
@RalfJung
Copy link
Member

@bors r+

(You are playing with fire, this PR is part of a rollup which might not pick up your typo fix. Let's see.^^)

@bors
Copy link
Contributor

bors commented Oct 24, 2018

📌 Commit c2463af has been approved by RalfJung

kennytm added a commit to kennytm/rust that referenced this pull request Oct 25, 2018
@kennytm
Rollup merge of rust-lang#55262 - oli-obk:dangling_alloc_id_ice, r=Ra…
bff4637 
…lfJung

Change the ICE from rust-lang#55223 to a hard error
@oli-obk oli-obk mentioned this pull request Oct 25, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Oct 26, 2018
@kennytm
Rollup merge of rust-lang#55262 - oli-obk:dangling_alloc_id_ice, r=Ra…
2a7fff1 
…lfJung

Change the ICE from rust-lang#55223 to a hard error

cc @SimonSapin

r? @RalfJung
@kennytm kennytm mentioned this pull request Oct 26, 2018
Closed
@RalfJung RalfJung mentioned this pull request Oct 26, 2018
Closed
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 26, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Oct 27, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#55262 - oli-obk:dangling_alloc_id_ice, r=Ra…
805fcb6 
…lfJung

Change the ICE from rust-lang#55223 to a hard error

cc @SimonSapin

r? @RalfJung
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Oct 27, 2018
Closed
@kennytm kennytm mentioned this pull request Oct 28, 2018
Merged
@bors

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 29, 2018
@rust-highfive

This comment has been minimized.

Sign in to view
@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2018
@oli-obk oli-obk force-pushed the dangling_alloc_id_ice branch from 599eb12 to e70b634 Compare October 29, 2018 12:14
@TimNN TimNN added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 6, 2018
@TimNN
Copy link
Contributor

TimNN commented Nov 6, 2018

Ping from triage @RalfJung: It looks like this PR is ready to be reviewed again.

@estebank
Copy link
Contributor

estebank commented Nov 6, 2018

Looking at the ICE fix commit, it is small enough that I feel confident giving my r+, assigning the approval to @RalfJung as he reviewed the other commits.

@bors r=RalfJung

@bors
Copy link
Contributor

bors commented Nov 6, 2018

📌 Commit e70b634 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2018
@RalfJung
Copy link
Member

RalfJung commented Nov 6, 2018 •
edited
Loading

Ah, sorry for that. GitHub doesn't send emails when you change labels and also not for all kinds of force-pushes, so I had no idea this was waiting for me.

@bors
Copy link
Contributor

bors commented Nov 6, 2018

⌛ Testing commit e70b634 with merge ddd4b19...

bors added a commit that referenced this pull request Nov 6, 2018
@bors
Auto merge of #55262 - oli-obk:dangling_alloc_id_ice, r=RalfJung
ddd4b19 
Change the ICE from #55223 to a hard error

cc @SimonSapin

r? @RalfJung

fixes #55287
@bors
Copy link
Contributor

bors commented Nov 7, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: RalfJung
Pushing ddd4b19 to master...

@bors bors merged commit e70b634 into rust-lang:master Nov 7, 2018
@oli-obk oli-obk deleted the dangling_alloc_id_ice branch June 15, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebank estebank estebank left review comments

@RalfJung RalfJung RalfJung left review comments

@kennytm kennytm kennytm left review comments

Assignees

@RalfJung RalfJung

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

const-eval ICE: allocation missing in dead_alloc_map
7 participants
@oli-obk @RalfJung @bors @kennytm @rust-highfive @estebank @TimNN