-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial implementation of uniform paths 2.0 to land before beta #55297
Conversation
Beta/nightly promotion is what I think matters here and that'll happen early next week so I don't think there's a super big rush here? |
Changes look good modulo some tests though I'm not super familiar with this area if code - r=me if you don't think we need them |
Oh, that's great, I thought it's supposed to be Oct 26 (same day as stable release). |
We're delaying beta/nightly promotion due to RC2. |
@petrochenkov are you planning on doing further revision to this PR, e.g. adding tests? Or do you just want to copy over the r+ marker from @Mark-Simulacrum ? |
@pnkfelix |
☔ The latest upstream changes (presumably #54145) made this pull request unmergeable. Please resolve the merge conflicts. |
due to macro-expanded `extern crate` items adding names to extern prelude.
Slightly simplify `fn build_reduced_graph_for_use_tree`
so that they are correctly resolved on 2018 edition
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@Mark-Simulacrum All the commits are refactorings except for b45b4da (bug-fix), acdbd06 (drive-by diagnostics improvement) and c57f0a7 (which is somewhat essential and fixes imports with empty groups ( |
@bors r+ p=5 Beta promotion has already happened so I'll prepare a beta backport as well. |
📌 Commit c57f0a7 has been approved by |
Partial implementation of uniform paths 2.0 to land before beta Reimplementation of uniform paths using in-scope resolution rather than canaries is a minor breaking change due to stricter future-proofing, so it needs to be landed before beta or backported later. I hope to implement at least something until beta so we have less to backport. r? @Mark-Simulacrum
☀️ Test successful - status-appveyor, status-travis |
[beta]: Prepare the 1.31.0 beta release * Update to Cargo's branched 1.31.0 branch * Update the channel to `beta` Rolled up beta-accepted PRs: * #55362: Remove `cargo new --edition` from release notes. * #55325: Fix link to macros chapter * #55358: Remove redundant clone (2) * #55346: Shrink `Statement`. * #55274: Handle bindings in substructure of patterns with type ascriptions * #55297: Partial implementation of uniform paths 2.0 to land before beta * #55192: Fix ordering of nested modules in non-mod.rs mods * #55185: path suggestions in Rust 2018 should point out the change in semantics * #55423: back out bogus `Ok`-wrapping suggestion on `?` arm type mismatch Note that **this does not update the bootstrap compiler** due to #55404
Reimplementation of uniform paths using in-scope resolution rather than canaries is a minor breaking change due to stricter future-proofing, so it needs to be landed before beta or backported later.
I hope to implement at least something until beta so we have less to backport.
r? @Mark-Simulacrum