Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

back out bogus Ok-wrapping suggestion on ? arm type mismatch #55423

Merged

Commits on Oct 27, 2018

  1. back out bogus Ok-wrapping suggestion on ? arm type mismatch

    This suggestion was introduced in rust-lang#51938 / 6cc78bf (while
    introducing different language for type errors coming from `?` rather
    than a `match`), but it has a lot of false-positives (as repeatedly
    reported in Issues rust-lang#52537, rust-lang#52598, rust-lang#54578, rust-lang#55336), and incorrect
    suggestions carry more badness than marginal good suggestions do
    goodness. Just get rid of it (unless and until someone figures out how
    to do it correctly).
    
    Resolves rust-lang#52537, resolves rust-lang#54578.
    zackmdavis committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    b754615 View commit details
    Browse the repository at this point in the history