Rollup of 12 pull requests #55502
Merged
Rollup of 12 pull requests #55502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR rust-lang#51953 enabled the Atomic*.{load,store} API on MSP430. Unfortunately, the LLVM backend doesn't currently support those atomic operations, so this commit removes the API and leaves instructions on how and when to enable it in the future.
Don't lint 'unused_parens` on `if (break _) { .. }`
This fixes rust-lang#54704
…ion, r=estebank Improve a few cases of collecting to an FxHash(Map/Set) Either use `collect` or procure specified capacity when possible.
msp430: remove the whole Atomic* API PR rust-lang#51953 enabled the Atomic*.{load,store} API on MSP430. Unfortunately, the LLVM backend doesn't currently support those atomic operations, so this commit removes the API and leaves instructions on how and when to enable it in the future. the second fixes compiling liballoc for msp430 closes rust-lang#54511 r? @alexcrichton cc @chernomor @awygle @cr1901 @pftbest
Add UI test for rust-lang#49296 Closes rust-lang#49296 r? @oli-obk
Use opt.take() instead of mem::replace(opt, None) It's easier to read.
…impl_iterator, r=estebank Take advantage of impl Iterator in (transitive/elaborate)_bounds Other than for `debug!`ging purposes, `bounds` are only iterated over, so they don't need to be collected into vectors.
…Jung Fix validation false positive Fixes rust-lang#55454 r? @RalfJung
…amertj Change a flat_map with 0/1-element vecs to a filter_map No need to use vectors in this case - `Option`s are quite sufficient.
Adjust Ids of path segments in visibility modifiers Fixes rust-lang#55376 (nightly regression) r? @petrochenkov
…isdreavus Doc fixes Fixes the bug in source code page where code was below line numbers and fixed this bug too ("Expand description" is shown whereas it shouldn't): <img width="1440" alt="screenshot 2018-10-29 at 23 11 29" src="https://user-images.githubusercontent.com/3050060/47684136-1105ad80-dbd2-11e8-9e9f-fb7f26b0f5bd.png"> r? @QuietMisdreavus
…te-must-look-at-parents-of-closures, r=davidtwco borrowck=migrate must look at parents of closures This fixes the NLL migration mode (which is the default with edition=2018) to inspect all parents of a closure in addition to the closure itself when looking to see if AST-borrowck issues an error for the given code. This should be a candidate for beta backport. Fix rust-lang#55492
Update clippy Pulls in rust-lang/rust-clippy#3382, should unbreak clippy r? @oli-obk @phansch
|
@bors r+ p=12 |
|
📌 Commit c16ff6e has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 30, 2018
Rollup of 12 pull requests Successful merges: - #54885 (Don't lint 'unused_parens` on `if (break _) { .. }`) - #55205 (Improve a few cases of collecting to an FxHash(Map/Set)) - #55450 (msp430: remove the whole Atomic* API) - #55459 (Add UI test for #49296) - #55472 (Use opt.take() instead of mem::replace(opt, None)) - #55473 (Take advantage of impl Iterator in (transitive/elaborate)_bounds) - #55474 (Fix validation false positive) - #55476 (Change a flat_map with 0/1-element vecs to a filter_map) - #55487 (Adjust Ids of path segments in visibility modifiers) - #55493 (Doc fixes) - #55494 (borrowck=migrate must look at parents of closures) - #55496 (Update clippy) Failed merges: r? @ghost
|
☀️ Test successful - status-appveyor, status-travis |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Oct 30, 2018
Tested on commit rust-lang/rust@e8aef7c. Direct link to PR: <rust-lang/rust#55502> 🎉 clippy-driver on windows: build-fail → test-pass. 🎉 clippy-driver on linux: build-fail → test-pass. 🎉 rls on windows: build-fail → test-fail. 🎉 rls on linux: build-fail → test-fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
onif (break _) { .. }` #54885 (Don't lint 'unused_parensonif (break _) { .. }`)Failed merges:
r? @ghost