Add example of using the indexing operator to HashMap docs #55519

fhartwig · 2018-10-30T22:32:21Z

rust-highfive · 2018-10-30T22:32:25Z

(rust_highfive has picked a reviewer for you, use r? to override)

TimNN · 2018-11-13T18:25:03Z

Ping from triage @Kimundi / @rust-lang/docs: This PR requires your review.

@fhartwig: #52575 mentions that the docs should also state that the HashMap can't be updated using the index notation, do you think you could include that.

frewsxcv

can you also add the same line to the BTreeMap docs? https://doc.rust-lang.org/std/collections/struct.BTreeMap.html

TimNN · 2018-11-27T18:12:12Z

Ping from triage @fhartwig: it looks like some changes have been requested to this PR.

TimNN · 2018-12-04T18:09:30Z

Ping from triage @fhartwig: It looks like your PR needs to be updated.

frewsxcv · 2018-12-04T19:50:28Z

I just pushed a commit w/ my suggestion, hope that's okay @fhartwig! Thanks for your contribution!

@bors r+ rollup

bors · 2018-12-04T19:50:30Z

📌 Commit 4bddb76 has been approved by frewsxcv

rust-highfive · 2018-12-04T20:58:02Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:2e195da0:start=1543953065982088445,finish=1543953138489016061,duration=72506927616
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:54:54] 
[00:54:54] running 120 tests
[00:54:57] i..ii...iii...iiii....i...i..........i..iii.............i.....i.....ii...i..i.ii..............i...ii 100/120
[00:54:57] ..ii.i.....iiii.....
[00:54:57] 
[00:54:57]  finished in 3.374
[00:54:57] travis_fold:end:test_codegen

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:55:11] 
[00:55:11] running 118 tests
[00:55:34] .iiiii...i.....i..i...i..i.i..i.i..i.....i..i....i..........iiii.........i.i....i...i.......ii.i.i.i 100/118
[00:55:38] ......iii.i.....ii
[00:55:38] 
[00:55:38]  finished in 26.892
[00:55:38] travis_fold:end:test_debuginfo

---
[01:04:36] error: no global memory allocator found but one is required; link to std or add #[global_allocator] to a static item that implements the GlobalAlloc trait.
[01:04:36] 
[01:04:36] 
[01:04:36] running 408 tests
[01:04:53] .............................................F...................................................... 100/408
[01:05:16] .................................................................................................... 300/408
[01:05:27] .................................................................................................... 400/408
' failed
' failed
[01:05:28] make: *** [check] Error 1
58684 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/release/deps
56896 ./src/llvm/test/MC
56108 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/release/build
55740 ./obj/build/x86_64-unknown-linux-gnu/test/run-pass/proc-macro
---
travis_time:end:2d0bca8d:start=1543957078483039607,finish=1543957078486971550,duration=3931943
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:122cfb59
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

…rewsxcv Add example of using the indexing operator to HashMap docs Fixes rust-lang#52575

GuillaumeGomez · 2018-12-05T10:09:59Z

@bors: r-

rust-highfive · 2018-12-05T17:44:06Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0e0cc0ac:start=1544027612572084932,finish=1544027675108760406,duration=62536675474
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:57:56] 
[00:57:56] running 120 tests
[00:57:59] i..ii...iii..iiii.....i...i..........i..iii.............i.....i.....ii...i..i.ii..............i...ii 100/120
[00:58:00] ..ii.i.....iiii.....
[00:58:00] 
[00:58:00]  finished in 3.525
[00:58:00] travis_fold:end:test_codegen

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:58:16] 
[00:58:16] running 118 tests
[00:58:40] .iiiii...i.....i..i...i..i.i..i.i..i.....i..i....i..........iiii.........i.i....i...i.......ii.i.i.i 100/118
[00:58:44] ......iii.i.....ii
[00:58:44] 
[00:58:44]  finished in 28.661
[00:58:44] travis_fold:end:test_debuginfo

---
[01:08:16] error: no global memory allocator found but one is required; link to std or add #[global_allocator] to a static item that implements the GlobalAlloc trait.
[01:08:16] 
[01:08:16] 
[01:08:16] running 408 tests
[01:08:34] ...............................................F.................................................... 100/408
[01:09:02] .................................................................................................... 300/408
[01:09:14] .................................................................................................... 400/408
[01:09:15] ........
[01:09:15] failures:
[01:09:15] failures:
[01:09:15] 
[01:09:15] ---- collections/btree/map.rs - collections::btree::map::BTreeMap (line 69) stdout ----
[01:09:15] thread 'collections/btree/map.rs - collections::btree::map::BTreeMap (line 69)' panicked at 'test executable failed:
[01:09:15] We've got 4 reviews, but Les Misérables ain't one.
[01:09:15] Up! is unreviewed.
[01:09:15] Office Space: Deals with real issues in the workplace.
[01:09:15] 
[01:09:15] thread 'main' panicked at 'no entry found for key', src/libcore/option.rs:1008:5
[01:09:15] 
[01:09:15] ', src/librustdoc/test.rs:358:17
[01:09:15] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:09:15] 
---
[01:09:15] 
[01:09:15] error: test failed, to rerun pass '--doc'
[01:09:15] 
[01:09:15] 
[01:09:15] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "alloc" "--" "--quiet"
[01:09:15] 
[01:09:15] 
[01:09:15] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:09:15] Build completed unsuccessfully in 0:22:26
[01:09:15] Build completed unsuccessfully in 0:22:26
[01:09:15] make: *** [check] Error 1
[01:09:15] Makefile:58: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:021cc3f0
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Wed Dec  5 17:44:00 UTC 2018
---
travis_time:end:020925b6:start=1544031842064199093,finish=1544031842070011407,duration=5812314
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:08b40f82
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Centril · 2018-12-24T17:11:32Z

@bors r+

bors · 2018-12-24T17:11:33Z

📌 Commit adfc066 has been approved by Centril

bors · 2018-12-25T18:52:01Z

⌛ Testing commit adfc066 with merge 7e0cf3069ebda9f9259502a225e4eda7102dc4e9...

bors · 2018-12-25T20:38:26Z

💔 Test failed - status-appveyor

kennytm · 2018-12-27T16:20:21Z

@bors retry

bors · 2018-12-28T06:52:23Z

⌛ Testing commit adfc066 with merge ee49bf8...

Add example of using the indexing operator to HashMap docs Fixes #52575

bors · 2018-12-28T09:29:28Z

☀️ Test successful - status-appveyor, status-travis
Approved by: Centril
Pushing ee49bf8 to master...

Add example of using the indexing operator to HashMap docs

51fdc2b

rust-highfive assigned Kimundi Oct 30, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 30, 2018

frewsxcv reviewed Nov 14, 2018

View reviewed changes

TimNN added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2018

Add example of using the indexing operator to BTreeMap docs

4bddb76

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 4, 2018

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 4, 2018

Rollup merge of rust-lang#55519 - fhartwig:hashmap-index-example, r=f…

a380bee

…rewsxcv Add example of using the indexing operator to HashMap docs Fixes rust-lang#52575

GuillaumeGomez mentioned this pull request Dec 4, 2018

Rollup of 15 pull requests #56521

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 5, 2018

Fix typo in variable name

439ecf9

Fix broken doc test

adfc066

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 8, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 25, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2018

bors added a commit that referenced this pull request Dec 28, 2018

Auto merge of #55519 - fhartwig:hashmap-index-example, r=Centril

ee49bf8

Add example of using the indexing operator to HashMap docs Fixes #52575

bors merged commit adfc066 into rust-lang:master Dec 28, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add example of using the indexing operator to HashMap docs #55519

Add example of using the indexing operator to HashMap docs #55519

fhartwig commented Oct 30, 2018

rust-highfive commented Oct 30, 2018

TimNN commented Nov 13, 2018

frewsxcv left a comment

TimNN commented Nov 27, 2018

TimNN commented Dec 4, 2018

frewsxcv commented Dec 4, 2018

bors commented Dec 4, 2018

rust-highfive commented Dec 4, 2018

GuillaumeGomez commented Dec 5, 2018

rust-highfive commented Dec 5, 2018

Centril commented Dec 24, 2018

bors commented Dec 24, 2018

bors commented Dec 25, 2018

bors commented Dec 25, 2018

kennytm commented Dec 27, 2018

bors commented Dec 28, 2018

bors commented Dec 28, 2018

Add example of using the indexing operator to HashMap docs #55519

Add example of using the indexing operator to HashMap docs #55519

Conversation

fhartwig commented Oct 30, 2018

rust-highfive commented Oct 30, 2018

TimNN commented Nov 13, 2018

frewsxcv left a comment

Choose a reason for hiding this comment

TimNN commented Nov 27, 2018

TimNN commented Dec 4, 2018

frewsxcv commented Dec 4, 2018

bors commented Dec 4, 2018

rust-highfive commented Dec 4, 2018

GuillaumeGomez commented Dec 5, 2018

rust-highfive commented Dec 5, 2018

Centril commented Dec 24, 2018

bors commented Dec 24, 2018

bors commented Dec 25, 2018

bors commented Dec 25, 2018

kennytm commented Dec 27, 2018

bors commented Dec 28, 2018

bors commented Dec 28, 2018