Stabilize allow irrefutable if-let patterns #55639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Closed
3 tasks
Centril
reviewed
Nov 3, 2018
Centril
reviewed
Nov 9, 2018
src/test/ui/rfc-2086-irrefutable_let_patterns/deny-irrefutable-if-let.stderr
Show resolved
Hide resolved
|
|
||
| #[deny(irrefutable_let_patterns)] | ||
| fn main() { | ||
| if let _ = 5 { |
There was a problem hiding this comment.
Put an error check ~ error: irrefutable if-let pattern or so here so that the test is more robust.
estebank
requested changes
Nov 9, 2018
|
r? @estebank |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Also, please keep the commit log clean of merges. Rebase on top of latest master instead. |
Mark-Simulacrum
added
S-waiting-on-author
|
I should be able to do it. |
|
@estebank I am trying to implement your recommendations (including the rebase which doesn't seem to have gone very well) but I am getting compiling panics locally with build |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
You will need to fix the rebase. It seems like your best choice at this point might be to just compare against your local master to get the appropriate changes, as it might be easier to do correctly. Alternatively, you can try following https://medium.com/@jeffreymmeyers/recovering-a-bad-git-rebase-with-git-reflog-e6ddedf02329. You will also have to update the E0162 error cases and text in the index at |
|
☔ The latest upstream changes (presumably #56032) made this pull request unmergeable. Please resolve the merge conflicts. |
Centril
added
the
relnotes
|
Ping from triage @Nokel81: It looks like your PR needs to be rebased. |
|
Hey @Nokel81; do you think you can get this into a ready state by Monday (2018-12-03)? |
|
@Centril I think I will be able to. |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
cc @eddyb, can you help out here? |
|
You're seeing doctest failures in rust/src/librustc_mir/diagnostics.rs Line 347 in 8ec22e7 rust/src/librustc_mir/diagnostics.rs Line 374 in 8ec22e7 |
|
@Nokel81 Search for the error codes, |
estebank
changed the title
|
I will do a rebase later today |
estebank
reviewed
Dec 3, 2018
Centril
reviewed
Dec 4, 2018
src/test/ui/rfc-2086-irrefutable_let_patterns/allow_irrefutable_let_patterns.stderr
Outdated
Show resolved
Hide resolved
File: allow_irrefutable_let_patterns.rs
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
☔ The latest upstream changes (presumably #56557) made this pull request unmergeable. Please resolve the merge conflicts. |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Centril
reviewed
Dec 10, 2018
| @@ -686,6 +683,9 @@ declare_features! ( | |||
| (accepted, extern_crate_item_prelude, "1.31.0", Some(55599), None), | |||
| // Allows use of the `:literal` macro fragment specifier (RFC 1576). | |||
| (accepted, macro_literal_matcher, "1.31.0", Some(35625), None), | |||
| // Allows irrefutable patterns in if-let and while-let statements (RFC 2086) | |||
| (accepted, irrefutable_let_patterns, "1.32.0", Some(44495), None), | |||
There was a problem hiding this comment.
Suggested change
| (accepted, irrefutable_let_patterns, "1.32.0", Some(44495), None), | |
| (accepted, irrefutable_let_patterns, "1.33.0", Some(44495), None), |
It slipped so you'll have to bump the version.
|
☔ The latest upstream changes (presumably #57063) made this pull request unmergeable. Please resolve the merge conflicts. |
|
ping from triage @Nokel81 you need to address the changes requested and the conflicts |
Centril
added
the
T-lang
|
#response_container_BBPPID{font-family: initial; font-size:initial; color: initial;} Thanks, I just haven't had enough time. Sorry! But thank you very much. Sebastian Malton From: notifications@github.comSent: January 11, 2019 10:15 PMTo: rust@noreply.github.comReply to: reply@reply.github.comCc: sebastian@malton.name; mention@noreply.github.comSubject: Re: [rust-lang/rust] Stabilize allow irrefutable if-let patterns (#55639) I've opened #57535 to stabilise if-let patterns, as we want to get it in before the beta cut-off. Thanks for your work, @Nokel81! You're a coauthor on the change, so your work didn't go to waste.
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
|
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 12, 2019
…rns, r=Centril Stabilise irrefutable if-let and while-let patterns This stabilises RFC 2086 (rust-lang#44495). This replaces rust-lang#55639, as we want to stabilise this in time for the beta cut-off. Closes rust-lang#55639. r? @Centril
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for the stabilization of RFC 2086