Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #31076 #55694

Merged
merged 5 commits into from
Nov 6, 2018
Merged

Fixes #31076 #55694

merged 5 commits into from
Nov 6, 2018

Commits on Nov 5, 2018

  1. Add test 

    Add test for incompleately implemented add trait, see issue rust-lang#31076
    @jsirs
    jsirs authored Nov 5, 2018
    Configuration menu
    Copy the full SHA
    2a1dc1e View commit details
    Browse the repository at this point in the history

  2. self.associated_item can return none 

    self.associated_item can return none, replace unwrap with '?' and bubble up None value instead of panicking
    @jsirs
    jsirs authored Nov 5, 2018
    Configuration menu
    Copy the full SHA
    4a08333 View commit details
    Browse the repository at this point in the history

  3. update test to include concrete type (i32)

    @jsirs
    jsirs authored Nov 5, 2018
    Configuration menu
    Copy the full SHA
    9fb2e06 View commit details
    Browse the repository at this point in the history

  4. add test for i32, fix incorrect location

    @jsirs
    jsirs authored Nov 5, 2018
    Configuration menu
    Copy the full SHA
    87c22f2 View commit details
    Browse the repository at this point in the history

  5. add call to tcx.sess.delay_span_bug 

    add call to tcx.sess.delay_span_bug before returning none to make sure error is presented to user
    @jsirs
    jsirs authored Nov 5, 2018
    Configuration menu
    Copy the full SHA
    3063977 View commit details
    Browse the repository at this point in the history