Bubble up an overflow error so that rustdoc can ignore it #55717

oli-obk · 2018-11-06T12:07:10Z

Idk how to write a test for this, other than trying to minimize the entire diesel crate. If desirable I will do that.

Note that there are many other such overflow errors hiding out there. Should we try to proactively eliminate them or do we just whack-a-mole them?

cc @GuillaumeGomez

r? @nikomatsakis

pnkfelix · 2018-11-06T21:36:09Z

@bors r+

bors · 2018-11-06T21:36:10Z

📌 Commit 69c80f4 has been approved by pnkfelix

pnkfelix · 2018-11-06T21:36:20Z

(I personally vote for whack-a-mole, but what do I know...)

Mark-Simulacrum · 2018-11-07T02:45:28Z

@bors p=10

bors · 2018-11-07T06:03:38Z

⌛ Testing commit 69c80f4 with merge 9426cbd...

@GuillaumeGomez

Bubble up an overflow error so that rustdoc can ignore it fixes #54524 Idk how to write a test for this, other than trying to minimize the entire diesel crate. If desirable I will do that. Note that there are many other such overflow errors hiding out there. Should we try to proactively eliminate them or do we just whack-a-mole them? cc @GuillaumeGomez r? @nikomatsakis

bors · 2018-11-07T06:40:20Z

💔 Test failed - status-travis

rust-highfive · 2018-11-07T06:40:21Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

 97 1071M   97 1041M    0     0  8135k      0  0:02:14  0:02:11  0:00:03 12.9M
 98 1071M   98 1054M    0     0  8171k      0  0:02:14  0:02:12  0:00:02 12.8M
 99 1071M   99 1067M    0     0  8211k      0  0:02:13  0:02:13 --:--:-- 12.8M
100 1071M  100 1071M    0     0  8222k      0  0:02:13  0:02:13 --:--:-- 12.9M
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk · 2018-11-07T07:04:16Z

@bors retry got stuck during initial checkout

bors · 2018-11-07T07:14:21Z

⌛ Testing commit 69c80f4 with merge da812b05151db5bbf3e69f455ebdcfdf9e203a51...

bors · 2018-11-07T09:14:09Z

💔 Test failed - status-travis

bors · 2018-11-09T05:46:19Z

⌛ Testing commit 69c80f4 with merge 1a1374bb6d7e3ce453d9e216da3b16ac35c6f201...

bors · 2018-11-09T06:56:20Z

💔 Test failed - status-travis

rust-highfive · 2018-11-09T06:56:23Z

The job dist-various-1 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:06:26] CC_armebv7r_none_eabi=arm-none-eabi-gcc
[01:06:26] S=/checkout
[01:06:26] _=/bin/sh
[01:06:26] TOOLSTATE_REPO_ACCESS_TOKEN=[secure]
[01:06:26] TRAVIS=true
[01:06:26] RUST_RELEASE_CHANNEL=nightly
[01:06:26] PATH=/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[01:06:26] RUN_MAKE_TARGETS=thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf
[01:06:26] RUSTC=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc
[01:06:26] RUST_BUILD_STAGE=stage2-thumbv6m-none-eabi
[01:06:26] BOOTSTRAP_PYTHON=/usr/bin/python2.7
[01:06:26] SCRIPT=python2.7 ../x.py test --target thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf src/test/run-make &&       python2.7 ../x.py dist --target asmjs-unknown-emscripten,wasm32-unknown-emscripten,x86_64-rumprun-netbsd,mips-unknown-linux-musl,mipsel-unknown-linux-musl,arm-unknown-linux-musleabi,arm-unknown-linux-musleabihf,armv5te-unknown-linux-gnueabi,armv5te-unknown-linux-musleabi,armv7-unknown-linux-musleabihf,aarch64-unknown-linux-musl,sparc64-unknown-linux-gnu,x86_64-unknown-redox,thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf,riscv32imc-unknown-none-elf,riscv32imac-unknown-none-elf,armebv7r-none-eabi,armebv7r-none-eabihf,armv7r-none-eabi,armv7r-none-eabihf
[01:06:26] AR=ar
[01:06:26] TRAVIS_BRANCH=auto
[01:06:26] RUSTC_BOOTSTRAP=1
[01:06:26] HOST_RPATH_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib
[01:06:26] SCCACHE_BUCKET=rust-lang-ci-sccache2
[01:06:26] PWD=/checkout/obj
[01:06:26] CI_JOB_NAME=dist-various-1
[01:06:26] TARGET_RPATH_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/thumbv6m-none-eabi/lib
[01:06:26] LD_LIB_PATH_ENVVAR=LD_LIBRARY_PATH
[01:06:26] PYTHON=/usr/bin/python2.7
[01:06:26] HOME=/home/user
[01:06:26] LD_LIBRARY_PATH=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib
[01:06:26] HOSTNAME=a853fd2aae68
[01:06:26] CC_mipsel_unknown_linux_musl=mipsel-openwrt-linux-gcc
[01:06:26] SHLVL=2
[01:06:26] CC= 
[01:06:26] BUILD_DIR=/checkout/obj/build
[01:06:26] BUILD_DIR=/checkout/obj/build
[01:06:26] RUST_TEST_TMPDIR=/checkout/obj/build/tmp
[01:06:26] LLVM_CXXFLAGS=
[01:06:26] RUSTFLAGS=--cap-lints=allow
[01:06:26] STAGING_DIR=/tmp
[01:06:26] TMPDIR=/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m
[01:06:26] TARGETS=asmjs-unknown-emscripten,wasm32-unknown-emscripten,x86_64-rumprun-netbsd,mips-unknown-linux-musl,mipsel-unknown-linux-musl,arm-unknown-linux-musleabi,arm-unknown-linux-musleabihf,armv5te-unknown-linux-gnueabi,armv5te-unknown-linux-musleabi,armv7-unknown-linux-musleabihf,aarch64-unknown-linux-musl,sparc64-unknown-linux-gnu,x86_64-unknown-redox,thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf,riscv32imc-unknown-none-elf,riscv32imac-unknown-none-elf,armebv7r-none-eabi,armebv7r-none-eabihf,armv7r-none-eabi,armv7r-none-eabihf
[01:06:26] RUST_CONFIGURE_ARGS=--musl-root-armv5te=/musl-armv5te       --musl-root-arm=/musl-arm       --musl-root-armhf=/musl-armhf       --musl-root-armv7=/musl-armv7       --musl-root-aarch64=/musl-aarch64       --musl-root-mips=/musl-mips       --musl-root-mipsel=/musl-mipsel       --enable-emscripten       --disable-docs --set build.print-step-timings --enable-verbose-tests --enable-sccache --disable-manage-submodules --enable-locked-deps --enable-cargo-native-static --set rust.codegen-units-std=1 --disable-dist-src --release-channel=nightly --enable-llvm-static-stdcpp --set rust.remap-debuginfo --enable-missing-tools
[01:06:26] MAKEFLAGS=
[01:06:26] MFLAGS=
[01:06:26] BOOTSTRAP_PARENT_ID=1058
[01:06:26] BOOTSTRAP_PARENT_ID=1058
[01:06:26] __COMPAT_LAYER=RunAsInvoker
[01:06:26] CC_x86_64_unknown_redox=x86_64-unknown-redox-gcc
[01:06:26] BUILD=x86_64-unknown-linux-gnu
[01:06:26] CXX= 
[01:06:26] AWS_ACCESS_KEY_ID=[secure]
[01:06:26] CC_sparc64_unknown_linux_gnu=sparc64-linux-gnu-gcc
[01:06:26] CC_sparc64_unknown_linux_gnu=sparc64-linux-gnu-gcc
[01:06:26] CARGO_HOME=/cargo
[01:06:26] RUSTC_LINKER=arm-none-eabi-gcc
[01:06:26] SCCACHE_REGION=us-west-1
[01:06:26] CC_mips_unknown_linux_musl=mips-openwrt-linux-gcc
[01:06:26] LLVM_COMPONENTS=
[01:06:26] TERM=xterm
[01:06:26] MAKELEVEL=1
[01:06:26] mkdir -p /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m
[01:06:26] cd /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m && rm -rf cortex-m
[01:06:26] cd /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m && bash -x /checkout/src/test/run-make/thumb-none-cortex-m/../git_clone_sha1.sh cortex-m https://github.com/rust-embedded/cortex-m a448e9156e2cb1e556e5441fd65426952ef4b927 
[01:06:26] Makefile:31: recipe for target 'all' failed
[01:06:26] 
[01:06:26] ------------------------------------------
[01:06:26] stderr:
[01:06:26] stderr:
[01:06:26] ------------------------------------------
[01:06:26] + PROJECT_NAME=cortex-m
[01:06:26] + URL=https://github.com/rust-embedded/cortex-m
[01:06:26] + SHA1=a448e9156e2cb1e556e5441fd65426952ef4b927
[01:06:26] + git clone https://github.com/rust-embedded/cortex-m cortex-m
[01:06:26] Cloning into 'cortex-m'...
[01:06:26] fatal: unable to access 'https://github.com/rust-embedded/cortex-m/': Could not resolve host: github.com
[01:06:26] + err_exit
[01:06:26] + echo ERROR:
[01:06:26] + exit 1
[01:06:26] make: *** [all] Error 1
[01:06:26] ------------------------------------------
[01:06:26] 
[01:06:26] thread '[run-make] run-make/thumb-none-cortex-m' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3284:9
[01:06:26] note: Run with `RUST_BACKTRACE=1` for a backtrace.
---
[01:06:26] status: exit code: 2
[01:06:26] command: "make"
[01:06:26] stdout:
[01:06:26] ------------------------------------------
[01:06:26] bash script.sh
[01:06:26] AWS_ACCESS_KEY_ID=[secure]
[01:06:26] AWS_SECRET_ACCESS_KEY=[secure]
[01:06:26] BOOTSTRAP_PARENT_ID=1058
[01:06:26] BOOTSTRAP_PYTHON=/usr/bin/python2.7
[01:06:26] BUILD_DIR=/checkout/obj/build
[01:06:26] CARGO=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo
[01:06:26] CARGO_HOME=/cargo
[01:06:26] CC_armebv7r_none_eabi=arm-none-eabi-gcc
[01:06:26] CC_armebv7r_none_eabi=arm-none-eabi-gcc
[01:06:26] CC_mips_unknown_linux_musl=mips-openwrt-linux-gcc
[01:06:26] CC_mipsel_unknown_linux_musl=mipsel-openwrt-linux-gcc
[01:06:26] CC_sparc64_unknown_linux_gnu=sparc64-linux-gnu-gcc
[01:06:26] CC_x86_64_unknown_redox=x86_64-unknown-redox-gcc
[01:06:26] CI_JOB_NAME=dist-various-1
[01:06:26] DEPLOY=1
[01:06:26] HERE=/checkout/src/test/run-make/thumb-none-qemu
[01:06:26] HOME=/home/user
[01:06:26] HOSTNAME=a853fd2aae68
[01:06:26] HOST_RPATH_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib
[01:06:26] LD_LIBRARY_PATH=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib
[01:06:26] LD_LIB_PATH_ENVVAR=LD_LIBRARY_PATH
[01:06:26] LLVM_COMPONENTS=
[01:06:26] LLVM_CXXFLAGS=
[01:06:26] MAKEFLAGS=
[01:06:26] MAKELEVEL=1
[01:06:26] MFLAGS=
[01:06:26] PWD=/checkout/src/test/run-make/thumb-none-qemu
[01:06:26] PYTHON=/usr/bin/python2.7
[01:06:26] PYTHON=/usr/bin/python2.7
[01:06:26] RUN_MAKE_TARGETS=thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf
[01:06:26] RUSTC=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc
[01:06:26] RUST_CONFIGURE_ARGS=--musl-root-armv5te=/musl-armv5te       --musl-root-arm=/musl-arm       --musl-root-armhf=/musl-armhf       --musl-root-armv7=/musl-armv7       --musl-root-aarch64=/musl-aarch64       --musl-root-mips=/musl-mips       --musl-root-mipsel=/musl-mipsel       --enable-emscripten       --disable-docs --set build.print-step-timings --enable-verbose-tests --enable-sccache --disable-manage-submodules --enable-locked-deps --enable-cargo-native-static --set rust.codegen-units-std=1 --disable-dist-src --release-channel=nightly --enable-llvm-static-stdcpp --set rust.remap-debuginfo --enable-missing-tools
[01:06:26] RUST_RELEASE_CHANNEL=nightly
[01:06:26] S=/checkout
[01:06:26] SCCACHE_BUCKET=rust-lang-ci-sccache2
[01:06:26] SCCACHE_REGION=us-west-1
[01:06:26] SCRIPT=python2.7 ../x.py test --target thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf src/test/run-make &&       python2.7 ../x.py dist --target asmjs-unknown-emscripten,wasm32-unknown-emscripten,x86_64-rumprun-netbsd,mips-unknown-linux-musl,mipsel-unknown-linux-musl,arm-unknown-linux-musleabi,arm-unknown-linux-musleabihf,armv5te-unknown-linux-gnueabi,armv5te-unknown-linux-musleabi,armv7-unknown-linux-musleabihf,aarch64-unknown-linux-musl,sparc64-unknown-linux-gnu,x86_64-unknown-redox,thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf,riscv32imc-unknown-none-elf,riscv32imac-unknown-none-elf,armebv7r-none-eabi,armebv7r-none-eabihf,armv7r-none-eabi,armv7r-none-eabihf
[01:06:26] SHLVL=3
[01:06:26] SRC=/checkout
[01:06:26] STAGING_DIR=/tmp
[01:06:26] TARGET=thumbv6m-none-eabi
[01:06:26] TARGETS=asmjs-unknown-emscripten,wasm32-unknown-emscripten,x86_64-rumprun-netbsd,mips-unknown-linux-musl,mipsel-unknown-linux-musl,arm-unknown-linux-musleabi,arm-unknown-linux-musleabihf,armv5te-unknown-linux-gnueabi,armv5te-unknown-linux-musleabi,armv7-unknown-linux-musleabihf,aarch64-unknown-linux-musl,sparc64-unknown-linux-gnu,x86_64-unknown-redox,thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf,riscv32imc-unknown-none-elf,riscv32imac-unknown-none-elf,armebv7r-none-eabi,armebv7r-none-eabihf,armv7r-none-eabi,armv7r-none-eabihf
[01:06:26] TARGET_RPATH_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/thumbv6m-none-eabi/lib
[01:06:26] TERM=xterm
[01:06:26] TMPDIR=/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu
[01:06:26] TRAVIS=true
[01:06:26] TRAVIS_BRANCH=auto
[01:06:26] TRAVIS_BRANCH=auto
[01:06:26] WORK_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu
[01:06:26] _=/usr/bin/env
[01:06:26] __COMPAT_LAYER=RunAsInvoker
[01:06:26] /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu /checkout/src/test/run-make/thumb-none-qemu
[01:06:26] /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu/example /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu /checkout/src/test/run-make/thumb-none-qemu
[01:06:26] Makefile:27: recipe for target 'all' failed
[01:06:26] ------------------------------------------
[01:06:26] stderr:
[01:06:26] ------------------------------------------
[01:06:26] ------------------------------------------
[01:06:26] + CRATE=example
[01:06:26] + env
[01:06:26] + sort
[01:06:26] + mkdir -p /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu
[01:06:26] + pushd /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu
[01:06:26] + rm -rf example
[01:06:26] + cp -a /checkout/src/test/run-make/thumb-none-qemu/example .
[01:06:26] + pushd example
[01:06:26] + env 'RUSTFLAGS=-C linker=arm-none-eabi-ld -C link-arg=-Tlink.x' /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo run --target thumbv6m-none-eabi
[01:06:26] + grep 'x = 42'
[01:06:26] warning: spurious network error (2 tries remaining): curl error: Could not resolve host: github.com
[01:06:26] ; class=Net (12)
[01:06:26] warning: spurious network error (1 tries remaining): curl error: Could not resolve host: github.com
[01:06:26] ; class=Net (12)
[01:06:26] ; class=Net (12)
[01:06:26] error: failed to load source for a dependency on `cortex-m`
[01:06:26] Caused by:
[01:06:26]   Unable to update registry `https://github.com/rust-lang/crates.io-index`
[01:06:26] 
[01:06:26] Caused by:
[01:06:26] Caused by:
[01:06:26]   failed to fetch `https://github.com/rust-lang/crates.io-index`
[01:06:26] 
[01:06:26] Caused by:
[01:06:26]   curl error: Could not resolve host: github.com
[01:06:26] ; class=Net (12)
[01:06:26] make: *** [all] Error 1
[01:06:26] ------------------------------------------
[01:06:26] 
[01:06:26] thread '[run-make] run-make/thumb-none-qemu' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3284:9
[01:06:26] 
---
[01:06:26] test result: FAILED. 7 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out
[01:06:26] 
[01:06:26] 
[01:06:26] 
[01:06:26] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/thumbv6m-none-eabi/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-make" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make" "--stage-id" "stage2-thumbv6m-none-eabi" "--mode" "run-make" "--target" "thumbv6m-none-eabi" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--linker" "arm-none-eabi-gcc" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/thumbv6m-none-eabi/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--llvm-version" "8.0.0svn\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:06:26] 
[01:06:26] 
[01:06:26] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:503:22
[01:06:26] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf src/test/run-make
---
travis_time:end:2f0aaf58:start=1541746478971808840,finish=1541746478978821866,duration=7013026
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:01860800
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:251dd9aa
travis_time:start:251dd9aa
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1c492200
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-11-09T08:01:08Z

@bors retry 9696

bors · 2018-11-09T09:43:49Z

⌛ Testing commit 69c80f4 with merge 1c953cdf998080d5457b3453ad1f0ee5636539b4...

bors · 2018-11-09T12:45:52Z

💔 Test failed - status-appveyor

kennytm · 2018-11-09T15:17:07Z

@rust-timer build 1c953cdf998080d5457b3453ad1f0ee5636539b4

I find it strange this keeps timing out.

@bors retry

rust-timer · 2018-11-09T15:17:09Z

Success: Queued 1c953cdf998080d5457b3453ad1f0ee5636539b4 with parent 36a50c2, comparison URL.

rust-timer · 2018-11-09T18:34:54Z

Finished benchmarking try commit 1c953cdf998080d5457b3453ad1f0ee5636539b4

bors · 2018-11-10T07:03:12Z

⌛ Testing commit 69c80f4 with merge 0366cca...

@GuillaumeGomez

Bubble up an overflow error so that rustdoc can ignore it fixes #54524 Idk how to write a test for this, other than trying to minimize the entire diesel crate. If desirable I will do that. Note that there are many other such overflow errors hiding out there. Should we try to proactively eliminate them or do we just whack-a-mole them? cc @GuillaumeGomez r? @nikomatsakis

bors · 2018-11-10T09:38:05Z

☀️ Test successful - status-appveyor, status-travis
Approved by: pnkfelix
Pushing 0366cca to master...

@ghost

[beta] Rollup backports Merged and approved: * #55831: [beta]: Update Cargo's submodule * #55717: Bubble up an overflow error so that rustdoc can ignore it * #55637: Do not attempt to ascribe projections out of a ty var * #55378: rustbuild: use configured linker to build bootstrap r? @ghost

Bubble up an overflow error so that rustdoc can ignore it

69c80f4

rust-highfive assigned nikomatsakis Nov 6, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 6, 2018

jonas-schievink mentioned this pull request Nov 6, 2018

1.30.1 point release tracking issue #55594

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2018

Mark-Simulacrum added stable-nominated Nominated for backporting to the compiler in the stable channel. stable-accepted Accepted for backporting to the compiler in the stable channel. labels Nov 7, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 7, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2018

pietroalbini added stable-accepted Accepted for backporting to the compiler in the stable channel. and removed stable-accepted Accepted for backporting to the compiler in the stable channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Nov 7, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 7, 2018

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 9, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 9, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 9, 2018

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 9, 2018

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 9, 2018

bors merged commit 69c80f4 into rust-lang:master Nov 10, 2018

pietroalbini mentioned this pull request Nov 10, 2018

[beta] Rollup backports #55849

Merged

pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 10, 2018

kennytm mentioned this pull request Nov 11, 2018

"died due to signal 11" in collectionstests on arm-android #55861

Closed

kennytm mentioned this pull request Nov 20, 2018

Spurious 30 minutes timeout on Travis CI #56112

Closed

oli-obk deleted the rustdoc_overflow branch June 15, 2020 15:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bubble up an overflow error so that rustdoc can ignore it #55717

Bubble up an overflow error so that rustdoc can ignore it #55717

oli-obk commented Nov 6, 2018

pnkfelix commented Nov 6, 2018

bors commented Nov 6, 2018

pnkfelix commented Nov 6, 2018

Mark-Simulacrum commented Nov 7, 2018

bors commented Nov 7, 2018

bors commented Nov 7, 2018

rust-highfive commented Nov 7, 2018

oli-obk commented Nov 7, 2018

bors commented Nov 7, 2018

bors commented Nov 7, 2018

bors commented Nov 9, 2018

bors commented Nov 9, 2018

rust-highfive commented Nov 9, 2018

kennytm commented Nov 9, 2018

bors commented Nov 9, 2018

bors commented Nov 9, 2018

kennytm commented Nov 9, 2018

rust-timer commented Nov 9, 2018

rust-timer commented Nov 9, 2018

bors commented Nov 10, 2018

bors commented Nov 10, 2018

Bubble up an overflow error so that rustdoc can ignore it #55717

Bubble up an overflow error so that rustdoc can ignore it #55717

Conversation

oli-obk commented Nov 6, 2018

pnkfelix commented Nov 6, 2018

bors commented Nov 6, 2018

pnkfelix commented Nov 6, 2018

Mark-Simulacrum commented Nov 7, 2018

bors commented Nov 7, 2018

bors commented Nov 7, 2018

rust-highfive commented Nov 7, 2018

oli-obk commented Nov 7, 2018

bors commented Nov 7, 2018

bors commented Nov 7, 2018

bors commented Nov 9, 2018

bors commented Nov 9, 2018

rust-highfive commented Nov 9, 2018

kennytm commented Nov 9, 2018

bors commented Nov 9, 2018

bors commented Nov 9, 2018

kennytm commented Nov 9, 2018

rust-timer commented Nov 9, 2018

rust-timer commented Nov 9, 2018

bors commented Nov 10, 2018

bors commented Nov 10, 2018