Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate mpsc channel selection #55783

Merged
merged 1 commit into from Nov 9, 2018
Merged

Deprecate mpsc channel selection #55783

merged 1 commit into from Nov 9, 2018

Conversation

ghost
Copy link

@ghost ghost commented Nov 8, 2018

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 8, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
travis_time:end:0832e7ad:start=1541683819506719552,finish=1541683882212720476,duration=62706000924
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:04:21]    Compiling alloc v0.0.0 (/checkout/src/liballoc)
[00:04:22]    Compiling alloc_system v0.0.0 (/checkout/src/liballoc_system)
[00:04:22]    Compiling panic_abort v0.0.0 (/checkout/src/libpanic_abort)
[00:04:26]    Compiling panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
[00:04:27] error: `#[deprecated]` cannot be used in staged api, use `#[rustc_deprecated]` instead
[00:04:27]    |
[00:04:27]    |
[00:04:27] 71 | / pub struct Select {
[00:04:27] 72 | |     inner: UnsafeCell<SelectInner>,
[00:04:27] 73 | |     next_id: Cell<usize>,
[00:04:27]    | |_^
[00:04:27] 
[00:04:27] 
[00:04:27] error: `#[deprecated]` cannot be used in staged api, use `#[rustc_deprecated]` instead
[00:04:27]     |
[00:04:27] 403 | / macro_rules! select {
[00:04:27] 404 | |     (
[00:04:27] 404 | |     (
[00:04:27] 405 | |         $($name:pat = $rx:ident.$meth:ident() => $code:expr),+
[00:04:27] 406 | |     ) => ({
[00:04:27] 416 | |     })
[00:04:27] 417 | | }
[00:04:27]     | |_^
[00:04:27] 
---
travis_time:end:00045a02:start=1541684163684422453,finish=1541684163690039770,duration=5617317
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:006a711b
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0035813a
travis_time:start:0035813a
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:st

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
travis_time:end:098878d4:start=1541686039113725837,finish=1541686096391108453,duration=57277382616
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:20:05]    Compiling alloc v0.0.0 (/checkout/src/liballoc)
[00:20:06]    Compiling alloc_system v0.0.0 (/checkout/src/liballoc_system)
[00:20:06]    Compiling panic_abort v0.0.0 (/checkout/src/libpanic_abort)
[00:20:11]    Compiling panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Select': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 286 | pub use self::select::{Select, Handle};
[00:20:13]     |
[00:20:13]     = note: `-D deprecated` implied by `-D warnings`
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Handle': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 286 | pub use self::select::{Select, Handle};
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13] 287 | use self::select::StartResult;
[00:20:13]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 288 | use self::select::StartResult::*;
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::SelectInner': channel selection will be removed in a future release
[00:20:13]    |
[00:20:13]    |
[00:20:13] 73 |     inner: UnsafeCell<SelectInner>,
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Handle': channel selection will be removed in a future release
[00:20:13]    |
[00:20:13]    |
[00:20:13] 78 |     head: *mut Handle<'static, ()>,
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Handle': channel selection will be removed in a future release
[00:20:13]    |
[00:20:13]    |
[00:20:13] 79 |     tail: *mut Handle<'static, ()>,
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Select': channel selection will be removed in a future release
[00:20:13]    |
[00:20:13]    |
[00:20:13] 82 | impl !marker::Send for Select {}
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::SelectInner': channel selection will be removed in a future release
[00:20:13]    |
[00:20:13] 91 |     selector: *mut SelectInner,
[00:20:13]    |                    ^^^^^^^^^^^
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Handle': channel selection will be removed in a future release
[00:20:13]    |
[00:20:13]    |
[00:20:13] 92 |     next: *mut Handle<'static, ()>,
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Handle': channel selection will be removed in a future release
[00:20:13]    |
[00:20:13]    |
[00:20:13] 93 |     prev: *mut Handle<'static, ()>,
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Packet': channel selection will be removed in a future release
[00:20:13]    |
[00:20:13]    |
[00:20:13] 95 |     packet: &'rx (dyn Packet+'rx),
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Handle': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 102 | struct Packets { cur: *mut Handle<'static, ()> }
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Select': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13] 118 | impl Select {
[00:20:13]     |      ^^^^^^
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Handle': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 263 | impl<'rx, T: Send> Handle<'rx, T> {
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Select': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 325 | impl Drop for Select {
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Handle': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 334 | impl<'rx, T: Send> Drop for Handle<'rx, T> {
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Packets': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13] 340 | impl Iterator for Packets {
[00:20:13]     |                   ^^^^^^^
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Select': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 354 | impl fmt::Debug for Select {
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Handle': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 360 | impl<'rx, T:Send+'rx> fmt::Debug for Handle<'rx, T> {
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult': channel selection will be removed in a future release
[00:20:13]   --> libstd/sync/mpsc/shared.rs:32:5
[00:20:13] 32 | use sync::mpsc::select::StartResult::*;
[00:20:13]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult': channel selection will be removed in a future release
[00:20:13]   --> libstd/sync/mpsc/shared.rs:33:5
[00:20:13] 33 | use sync::mpsc::select::StartResult;
[00:20:13]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult': channel selection will be removed in a future release
[00:20:13]   --> libstd/sync/mpsc/sync.rs:46:39
[00:20:13]    |
[00:20:13] 46 | use sync::mpsc::select::StartResult::{self, Installed, Abort};
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult::Installed': channel selection will be removed in a future release
[00:20:13]   --> libstd/sync/mpsc/sync.rs:46:45
[00:20:13]    |
[00:20:13] 46 | use sync::mpsc::select::StartResult::{self, Installed, Abort};
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult::Abort': channel selection will be removed in a future release
[00:20:13]   --> libstd/sync/mpsc/sync.rs:46:56
[00:20:13]    |
[00:20:13] 46 | use sync::mpsc::select::StartResult::{self, Installed, Abort};
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Packet': channel selection will be removed in a future release
[00:20:13]      |
[00:20:13]      |
[00:20:13] 1520 | impl<T> select::Packet for Receiver<T> {
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 114 |     fn start_selection(&self, token: SignalToken) -> StartResult;
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Select': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 133 |     pub fn new() -> Select {
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Select': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13] 134 |         Select {
[00:20:13]     |         ^^^^^^
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::SelectInner': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 135 |             inner: UnsafeCell::new(SelectInner {
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Handle': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 146 |     pub fn handle<'a, T: Send>(&'a self, rx: &'a Receiver<T>) -> Handle<'a, T> {
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Handle': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13] 149 |         Handle {
[00:20:13]     |         ^^^^^^
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult::Installed': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13] 210 |                     StartResult::Installed => {}
[00:20:13]     |                     ^^^^^^^^^^^^^^^^^^^^^^
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult::Abort': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 211 |                     StartResult::Abort => {
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Packets': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 260 |     fn iter(&self) -> Packets { Packets { cur: unsafe { &*self.inner.get() }.head } }
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Packets': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 260 |     fn iter(&self) -> Packets { Packets { cur: unsafe { &*self.inner.get() }.head } }
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Handle': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 282 |         let me = self as *mut Handle<'rx, T> as *mut Handle<'static, ()>;
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Handle': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 282 |         let me = self as *mut Handle<'rx, T> as *mut Handle<'static, ()>;
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Handle': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 303 |         let me = self as *mut Handle<'rx, T> as *mut Handle<'static, ()>;
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Handle': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 303 |         let me = self as *mut Handle<'rx, T> as *mut Handle<'static, ()>;
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Handle': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 341 |     type Item = *mut Handle<'static, ()>;
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::Handle': channel selection will be removed in a future release
[00:20:13]     |
[00:20:13]     |
[00:20:13] 343 |     fn next(&mut self) -> Option<*mut Handle<'static, ()>> {
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult::Installed': channel selection will be removed in a future release
[00:20:13]    --> libstd/sync/mpsc/shared.rs:232:44
[00:20:13]     |
[00:20:13] 232 |         if self.decrement(signal_token) == Installed {
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult': channel selection will be removed in a future release
[00:20:13]    --> libstd/sync/mpsc/shared.rs:251:48
[00:20:13]     |
[00:20:13] 251 |     fn decrement(&self, token: SignalToken) -> StartResult {
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult::Installed': channel selection will be removed in a future release
[00:20:13]    --> libstd/sync/mpsc/shared.rs:265:49
[00:20:13]     |
[00:20:13] 265 |                     if n - steals <= 0 { return Installed }
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult::Abort': channel selection will be removed in a future release
[00:20:13]    --> libstd/sync/mpsc/shared.rs:271:13
[00:20:13] 271 |             Abort
[00:20:13]     |             ^^^^^
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult': channel selection will be removed in a future release
[00:20:13]    --> libstd/sync/mpsc/shared.rs:433:58
[00:20:13]     |
[00:20:13] 433 |     pub fn start_selection(&self, token: SignalToken) -> StartResult {
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult::Installed': channel selection will be removed in a future release
[00:20:13]    --> libstd/sync/mpsc/shared.rs:435:13
[00:20:13] 435 |             Installed => Installed,
[00:20:13]     |             ^^^^^^^^^
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult::Installed': channel selection will be removed in a future release
[00:20:13]    --> libstd/sync/mpsc/shared.rs:435:26
[00:20:13] 435 |             Installed => Installed,
[00:20:13]     |                          ^^^^^^^^^
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult::Abort': channel selection will be removed in a future release
[00:20:13]    --> libstd/sync/mpsc/shared.rs:436:13
[00:20:13] 436 |             Abort => {
[00:20:13]     |             ^^^^^
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult::Abort': channel selection will be removed in a future release
[00:20:13]    --> libstd/sync/mpsc/shared.rs:439:17
[00:20:13] 439 |                 Abort
[00:20:13]     |                 ^^^^^
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult': channel selection will be removed in a future release
[00:20:13]    --> libstd/sync/mpsc/sync.rs:433:58
[00:20:13]     |
[00:20:13] 433 |     pub fn start_selection(&self, token: SignalToken) -> StartResult {
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult::Abort': channel selection will be removed in a future release
[00:20:13]    --> libstd/sync/mpsc/sync.rs:436:13
[00:20:13] 436 |             Abort
[00:20:13]     |             ^^^^^
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult::Installed': channel selection will be removed in a future release
[00:20:13]    --> libstd/sync/mpsc/sync.rs:443:13
[00:20:13] 443 |             Installed
[00:20:13]     |             ^^^^^^^^^
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult': channel selection will be removed in a future release
[00:20:13]      |
[00:20:13]      |
[00:20:13] 1546 |     fn start_selection(&self, mut token: SignalToken) -> StartResult {
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult::Installed': channel selection will be removed in a future release
[00:20:13]      |
[00:20:13]      |
[00:20:13] 1551 |                         oneshot::SelSuccess => return Installed,
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult::Abort': channel selection will be removed in a future release
[00:20:13]      |
[00:20:13]      |
[00:20:13] 1552 |                         oneshot::SelCanceled => return Abort,
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult::Installed': channel selection will be removed in a future release
[00:20:13]      |
[00:20:13]      |
[00:20:13] 1558 |                         stream::SelSuccess => return Installed,
[00:20:13] 
[00:20:13] 
[00:20:13] error: use of deprecated item 'sync::mpsc::select::StartResult::Abort': channel selection will be removed in a future release
[00:20:13]      |
[00:20:13]      |
[00:20:13] 1559 |                         stream::SelCanceled => return Abort,
[00:20:13] 
el selection will be removed in a future release
[00:20:15]    --> libstd/sync/mpsc/select.rs:137:17
[00:20:15]     |
[00:20:15]     |
[00:20:15] 137 |                 tail: ptr::null_mut(),
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::Select::next_id': channel selection will be removed in a future release
[00:20:15]     |
[00:20:15]     |
[00:20:15] 139 |             next_id: Cell::new(1),
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::Select::next_id': channel selection will be removed in a future release
[00:20:15]     |
[00:20:15]     |
[00:20:15] 147 |         let id = self.next_id.get();
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::Select::next_id': channel selection witd/sync/mpsc/select.rs:154:13
[00:20:15] 154 |             added: false,
[00:20:15]     |             ^^^^^^^^^^^^
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::Handle::rx': channel selection will be removed in a future release
[00:20:15]     |
[00:20:15] 155 |             rx,
[00:20:15]     |             ^^
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::Handle::packet': channel selection will be removed in a future release
[00:20:15]     |
[00:20:15] 156 |             packet: rx,
[00:20:15]     |             ^^^^^^^^^^
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::Select::wait2': channel selection will be removed in a future release
[00:20:15]     |
[00:20:15]     |
[00:20:15] 167 |         self.wait2(true)
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::Select::iter': channel selection will be removed in a future release
[00:20:15]     |
[00:20:15]     |
[00:20:15] 195 |                 for handle in self.iter() {
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::Handle::packet': channel selection will be removed in a future release
[00:20:15]     |
[00:20:15]     |
[00:20:15] 196 |                     if (*handle).packet.can_recv() {
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::Packet::can_recv': channel selection will be removed in a future release
[00:20:15]     |
[00:20:15] 196|
[00:20:15] 196|
[00:20:15] 209 |                 match (*handle).packet.start_selection(signal_token.clone()) {
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::Packet::start_selection': channel selection will be removed in a future release
[00:20:15]     |
[00:20:15]     |
[00:20:15] 209 |                 match (*handle).packet.start_selection(signal_token.clone()) {
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::Select::iter': channel selection will be removed in a future release
[00:20:15]     |
[00:20:15]     |
[00:20:15] 213 |                         for handle in self.iter().take(i) {
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::Handle::packet': channel selection will be remove1m: use of deprecated item 'sync::mpsc::select::Select::iter': channel selection will be removed in a future release
[00:20:15]     |
[00:20:15]     |
[00:20:15] 248 |             for handle in self.iter() {
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::Handle::packet': channel selection will be removed in a future release
[00:20:15]     |
[00:20:15]     |
[00:20:15] 249 |                 if (*handle).packet.abort_selection() {
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::Packet::abort_selection': channel selection will be removed in a future release
[00:20:15]     |
[00:20:15]     |
[00:20:15] 249 |                 if (*handle).packet.abort_selection() {
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::Handle::id': channel selection will be removed in a future release
[00:20:15]     |
[00:20:15]     |
[00:20:15] 250 |                     ready_id = (*handle).id;
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::Packets::cur': channel selection will be removed in a future release
[00:20:15]     |
[00:20:15]     |
[00:20:15] 260 |     fn iter(&self) -> Packets { Packets { cur: unsafe { &*self.inner.get() }.head } }
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::Select::inner': channel selection will be removed in a future release
[00:20:15]     |
[00:20:15]     |
[00:20:15] 260 |     fn iter(&self) -> Packets { Packets { cur: unsafe { &*self.inner.get() }.head } }
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::SelectInner::head': channel selection will be removed in a future release
[00:20:15]     |
[00:20:15]     |
[00:20:15] 260 |     fn iter(&self) -> Packets { Packets { cur: unsafe { &*self.inner.get() }.head } }
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::Handle::id': channel selection will be removed in a future release
[00:20:15]     |
[00:20:15]     |
[00:20:15] 266 |     pub fn id(&self) -> usize { self.id }
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::Handle::rx': channel selection will be removed in a future release
[00:20:15]     |
[00:20:15]     |
[00:20:15] 271 |     pub fn recv(&mut self) -> Result<T, RecvError> { self.rx.recv() }
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::Handle::added': channel selection will be removed in a future release
[00:20:15]     |
[00:20:15]     |
[00:20:15] 280 |         if self.added { return }
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::Handle::selector': channel selection will be removed in a future release
[00:20:15]     |
[00:20:15]     |
[00:20:15] 281 |         let selector = &mut *self.selector;
[00:20:15] 
[00:20:15] 
[00:20:15] error: use of deprecated item 'sync::mpsc::select::SelectInner::head': channel selection will be removed in a future release
[00:20:15]     |
---
151412 ./src/tools/clang
150256 ./obj/build/bootstrap/debug/incremental
149132 ./src/llvm-emscripten/test
134668 ./obj/build/bootstrap/debug/incremental/bootstrap-zemjd6kcyh2u
134664 ./obj/build/bootstrap/debug/incremental/bootstrap-zemjd6kcyh2u/s-f6hcvr5b8j-19nko52-22tmsi8iacpi9
107892 ./obj/build/x86_64-unknown-linux-gnu/stage0/lib/rustlib/x86_64-unknown-linux-gnu/codegen-backends
104700 ./src/tools/lldb
94924 ./obj/build/x86_64-unknown-linux-gnu/stage1
94904 ./obj/build/x86_64-unknown-linux-gnu/stage1/lib
---
travis_time:end:1390bb14:start=1541687323133653347,finish=1541687323139325252,duration=5671905
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:08f95c35
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:2b0f1432
travis_time:start:2b0f1432
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@SimonSapin
Copy link
Contributor

This probably needs #[allow(deprecated)] in a few places. (Likely including some tests, so consider running a full ./x.py test if practical. --stage 1 might work too.)

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
travis_time:end:1618a93e:start=1541694684574630381,finish=1541694685736809147,duration=1162178766
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:54:03] .................................................................................................... 100/4999
[00:54:07] .................................................................................................... 200/4999
[00:54:09] ........................................................................ii...................ii..... 300/4999
[00:54:12] ...........................................................................................iii...... 400/4999
[00:54:15] ..iiiiiiii.iii...........................iii...........................................i...........i 500/4999
[00:54:22] .................................................................................................... 700/4999
[00:54:29] .....................................................................i...........i.................. 800/4999
[00:54:32] ........................................................................................iiii.i...... 900/4999
[00:54:35] ...........ii.iiii.................................................................................. 1000/4999
---
[00:55:12] .................................................................................................... 2200/4999
[00:55:16] .................................................................................................... 2300/4999
[00:55:20] .................................................................................................... 2400/4999
[00:55:24] .................................................................................................... 2500/4999
[00:55:28] ...................................................................iiiiiiiii........................ 2600/4999
[00:55:35] ...............................ii................................................................... 2800/4999
[00:55:38] .................................................................................................... 2900/4999
[00:55:42] .................................................................................................... 3000/4999
[00:55:45] ..........................i......................................................................... 3100/4999
---
[00:58:02] .................................................................................................... 700/2881
[00:58:13] .................................................................................................... 800/2881
[00:58:23] .................................................................................................... 900/2881
[00:58:38] .................................................................................................... 1000/2881
[00:58:51] ......................................................F............................................. 1100/2881
[00:59:09] .................................................................................................... 1300/2881
[00:59:22] ............................................................................i....................... 1400/2881
[00:59:34] .................................................................................................... 1500/2881
[00:59:47] .............................................i...................................................... 1600/2881
---
[01:02:57] failures:
[01:02:57] 
[01:02:57] ---- [run-pass] run-pass/issues/issue-13494.rs stdout ----
[01:02:57] normalized stderr:
[01:02:57] warning: use of deprecated item 'std::sync::mpsc::Select': channel selection will be removed in a future release
[01:02:57]    |
[01:02:57]    |
[01:02:57] LL | /         select! {
[01:02:57] LL | |             _ = rx2.recv() => (),
[01:02:57] LL | |             _ = rcv.recv() => ()
[01:02:57] LL | |         }
[01:02:57]    |
[01:02:57]    = note: #[warn(deprecated)] on by default
[01:02:57]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[01:02:57] 
[01:02:57] 
[01:02:57] warning: use of deprecated item 'std::sync::mpsc::Select': channel selection will be removed in a future release
[01:02:57]    |
[01:02:57]    |
[01:02:57] LL | /         select! {
[01:02:57] LL | |             _ = rx2.recv() => (),
[01:02:57] LL | |             _ = rcv.recv() => ()
[01:02:57] LL | |         }
[01:02:57]    |
[01:02:57]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[01:02:57] 
[01:02:57] 
[01:02:57] warning: use of deprecated item 'std::sync::mpsc::Select::new': channel selection will be removed in a future release
[01:02:57]    |
[01:02:57]    |
[01:02:57] LL | /         select! {
[01:02:57] LL | |             _ = rx2.recv() => (),
[01:02:57] LL | |             _ = rcv.recv() => ()
[01:02:57] LL | |         }
[01:02:57]    |
[01:02:57]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[01:02:57] 
[01:02:57] 
[01:02:57] warning: use of deprecated item 'std::sync::mpsc::Select::handle': channel selection will be removed in a future release
[01:02:57]    |
[01:02:57]    |
[01:02:57] LL | /         select! {
[01:02:57] LL | |             _ = rx2.recv() => (),
[01:02:57] LL | |             _ = rcv.recv() => ()
[01:02:57] LL | |         }
[01:02:57]    |
[01:02:57]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[01:02:57] 
[01:02:57] 
[01:02:57] warning: use of deprecated item '<std::sync::mpsc::Handle<'rx, T>>::add': channel selection will be removed in a future release
[01:02:57]    |
[01:02:57]    |
[01:02:57] LL | /         select! {
[01:02:57] LL | |             _ = rx2.recv() => (),
[01:02:57] LL | |             _ = rcv.recv() => ()
[01:02:57] LL | |         }
[01:02:57]    |
[01:02:57]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[01:02:57] 
[01:02:57] 
[01:02:57] warning: use of deprecated item 'std::sync::mpsc::Select::wait': channel selection will be removed in a future release
[01:02:57]    |
[01:02:57]    |
[01:02:57] LL | /         select! {
[01:02:57] LL | |             _ = rx2.recv() => (),
[01:02:57] LL | |             _ = rcv.recv() => ()
[01:02:57] LL | |         }
[01:02:57]    |
[01:02:57]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[01:02:57] 
[01:02:57] 
[01:02:57] warning: use of deprecated item '<std::sync::mpsc::Handle<'rx, T>>::id': channel selection will be removed in a future release
[01:02:57]    |
[01:02:57]    |
[01:02:57] LL | /         select! {
[01:02:57] LL | |             _ = rx2.recv() => (),
[01:02:57] LL | |             _ = rcv.recv() => ()
[01:02:57] LL | |         }
[01:02:57]    |
[01:02:57]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[01:02:57] 
[01:02:57] 
[01:02:57] warning: use of deprecated item '<std::sync::mpsc::Handle<'rx, T>>::recv': channel selection will be removed in a future release
[01:02:57]    |
[01:02:57]    |
[01:02:57] LL |             _ = rx2.recv() => (),
[01:02:57] 
[01:02:57] 
[01:02:57] warning: use of deprecated item '<std::sync::mpsc::Handle<'rx, T>>::recv': channel selection will be removed in a future release
[01:02:57]    |
[01:02:57]    |
[01:02:57] LL |             _ = rcv.recv() => ()
[01:02:57] 
[01:02:57] 
[01:02:57] 
[01:02:57] 
[01:02:57] 
[01:02:57] The actual stderr differed from the expected stderr.
[01:02:57] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/issues/issue-13494/issue-13494.stderr
[01:02:57] To update references, rerun the tests and pass the `--bless` flag
[01:02:57] To only update this specific test, also pass `--test-args issues/issue-13494.rs`
[01:02:57] error: 1 errors occurred comparing output.
[01:02:57] status: exit code: 0
[01:02:57] status: exit code: 0
[01:02:57] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/run-pass/issues/issue-13494.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/issues/issue-13494/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/issues/issue-13494/auxiliary"
[01:02:57] ------------------------------------------
[01:02:57] 
[01:02:57] ------------------------------------------
[01:02:57] stderr:
[01:02:57] stderr:
[01:02:57] ------------------------------------------
[01:02:57] {"message":"use of deprecated item 'std::sync::mpsc::Select': channel selection will be removed in a future release","code":{"code":"deprecated","explanation":null},"level":"warning","spans":[{"file_name":"<::std::macros::select macros>","byte_start":138,"byte_end":151,"line_start":4,"line_end":4,"column_start":51,"column_end":64,"is_primary":true,"text":[{"text":"use $ crate :: sync :: mpsc :: Select ; let sel = Select :: new (  ) ; $ (","highlight_start":51,"highlight_end":64}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":{"span":{"file_name":"/checkout/src/test/run-pass/issues/issue-13494.rs","byte_start":1117,"byte_end":1203,"line_start":37,"line_end":40,"column_start":9,"column_end":10,"is_primary":false,"text":[{"text":"        select! {","highlight_start":9,"highlight_end":18},{"text":"            _ = rx2.recv() => (),","highlight_start":1,"highlight_end":34},{"text":"            _ = rcv.recv() => ()","highlight_start":1,"highlight_end":33},{"text":"        }","highlight_start":1,"highlight_end":10}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null},"macro_decl_name":"select!","def_site_span":{"file_name":"<::std::macros::select macros>","byte_start":0,"byte_end":382,"line_start":1,"line_end":8,"column_start":1,"column_end":27,"is_primary":false,"text":[{"text":"( $ ( $ name : pat = $ rx : ident . $ meth : ident (  ) => $ code : expr ) , +","highlight_start":1,"highlight_end":79},{"text":") => (","highlight_start":1,"highlight_end":7},{"text":"{","highlight_start":1,"highlight_end":2},{"text":"use $ crate :: sync :: mpsc :: Select ; let sel = Select :: new (  ) ; $ (","highlight_start":1,"highlight_end":75},{"text":"let mut $ rx = sel . handle ( & $ rx ) ; ) + unsafe {","highlight_start":1,"highlight_end":54},{"text":"$ ( $ rx . add (  ) ; ) + } let ret = sel . wait (  ) ; $ (","highlight_start":1,"highlight_end":60},{"text":"if ret == $ rx . id (  ) { let $ name = $ rx . $ meth (  ) ; $ code } else ) +","highlight_start":1,"highlight_end":79},{"text":"{ unreachable ! (  ) } } )","highlight_start":1,"highlight_end":27}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}}}],"children":[{"message":"#[warn(deprecated)] on by default","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"warning: use of deprecated item 'std::sync::mpsc::Select': channel selection will be removed in a future release\n  --> /checkout/src/test/run-pass/issues/issue-13494.rs:37:9\n   |\nLL | /         select! {\nLL | |             _ = rx2.recv() => (),\nLL | |             _ = rcv.recv() => ()\nLL | |         }\n   | |_________^\n   |\n   = note: #[warn(deprecated)] on by default\n   = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)\n\n"}
[01:02:57] {"message":"use of deprecated item 'std::sync::mpsc::Select': channel selection will be removed in a future release","code":{"code":"deprecated","explanation":null},"level":"warning","spans":[{"file_name":"<::std::macros::select macros>","byte_start":92,"byte_end":125,"line_start":4,"line_end":4,"column_start":5,"column_end":38,"is_primary":true,"text":[{"text":"use $ crate :: sync :: mpsc :: Select ; let sel = Select :: new (  ) ; $ (","highlight_start":5,"highlight_end":38}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":{"span":{"file_name":"/checkout/src/test/run-pass/issues/issue-13494.rs","byte_start":1117,"byte_end":1203,"line_start":37,"line_end":40,"column_start":9,"column_end":10,"is_primary":false,"text":[{"text":"        select! {","highlight_start":9,"highlight_end":18},{"text":"            _ = rx2.recv() => (),","highlight_start":1,"highlight_end":34},{"text":"            _ = rcv.recv() => ()","highlight_start":1,"highlight_end":33},{"text":"        }","highlight_start":1,"highlight_end":10}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null},"macro_decl_name":"select!","def_site_span":{"file_name":"<::std::macros::select macros>","byte_start":0,"byte_end":382,"line_start":1,"line_end":8,"column_start":1,"column_end":27,"is_primary":false,"text":[{"text":"( $ ( $ name : pat = $ rx : ident . $ meth : ident (  ) => $ code : expr ) , +","highlight_start":1,"highlight_end":79},{"text":") => (","highlight_start":1,"highlight_end":7},{"text":"{","highlight_start":1,"highlight_end":2},{"text":"use $ crate :: sync :: mpsc :: Select ; let sel = Select :: new (  ) ; $ (","highlight_start":1,"highlight_end":75},{"text":"let mut $ rx = sel . handle ( & $ rx ) ; ) + unsafe {","highlight_start":1,"highlight_end":54},{"text":"$ ( $ rx . add (  ) ; ) + } let ret = sel . wait (  ) ; $ (","highlight_start":1,"highlight_end":60},{"text":"if ret == $ rx . id (  ) { let $ name = $ rx . $ meth (  ) ; $ code } else ) +","highlight_start":1,"highlight_end":79},{"text":"{ unreachable ! (  ) } } )","highlight_start":1,"highlight_end":27}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}}}],"children":[],"rendered":"warning: use of deprecated item 'std::sync::mpsc::Select': channel selection will be removed in a future release\n  --> /checkout/src/test/run-pass/issues/issue-13494.rs:37:9\n   |\nLL | /         select! {\nLL | |             _ = rx2.recv() => (),\nLL | |             _ = rcv.recv() => ()\nLL | |         }\n   | |_________^\n   |\n   = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)\n\n"}
[01:02:57] {"message":"use of deprecated item 'std::sync::mpsc::Select::new': channel selection will be removed in a future release","code":{"code":"deprecated","explanation":null},"level":"warning","spans":[{"file_name":"<::std::macros::select macros>","byte_start":138,"byte_end":151,"line_start":4,"line_end":4,"column_start":51,"column_end":64,"is_primary":true,"text":[{"text":"use $ crate :: sync :: mpsc :: Select ; let sel = Select :: new (  ) ; $ (","highlight_start":51,"highlight_end":64}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":{"span":{"file_name":"/checkout/src/test/run-pass/issues/issue-13494.rs","byte_start":1117,"byte_end":1203,"line_start":37,"line_end":40,"column_start":9,"column_end":10,"is_primary":false,"text":[{"text":"        select! {","highlight_start":9,"highlight_end":18},{"text":"            _ = rx2.recv() => (),","highlight_start":1,"highlight_end":34},{"text":"            _ = rcv.recv() => ()","highlight_start":1,"highlight_end":33},{"text":"        }","highlight_start":1,"highlight_end":10}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null},"macro_decl_name":"select!","def_site_span":{"file_name":"<::std::macros::select macros>","byte_start":0,"byte_end":382,"line_start":1,"line_end":8,"column_start":1,"column_end":27,"is_primary":false,"text":[{"text":"( $ ( $ name : pat = $ rx : ident . $ meth : ident (  ) => $ code : expr ) , +","highlight_start":1,"highlight_end":79},{"text":") => (","highlight_start":1,"highlight_end":7},{"text":"{","highlight_start":1,"highlight_end":2},{"text":"use $ crate :: sync :: mpsc :: Select ; let sel = Select :: new (  ) ; $ (","highlight_start":1,"highlight_end":75},{"text":"let mut $ rx = sel . handle ( & $ rx ) ; ) + unsafe {","highlight_start":1,"highlight_end":54},{"text":"$ ( $ rx . add (  ) ; ) + } let ret = sel . wait (  ) ; $ (","highlight_start":1,"highlight_end":60},{"text":"if ret == $ rx . id (  ) { let $ name = $ rx . $ meth (  ) ; $ code } else ) +","highlight_start":1,"highlight_end":79},{"text":"{ unreachable ! (  ) } } )","highlight_start":1,"highlight_end":27}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}}}],"children":[],"rendered":"warning: use of deprecated item 'std::sync::mpsc::Select::new': channel selection will be removed in a future release\n  --> /checkout/src/test/run-pass/issues/issue-13494.rs:37:9\n   |\nLL | /         select! {\nLL | |             _ = rx2.recv() => (),\nLL | |             _ = rcv.recv() => ()\nLL | |         }\n   | |_________^\n   |\n   = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)\n\n"}
[01:02:57] {"message":"use of deprecated item 'std::sync::mpsc::Select::handle': channel selection will be removed in a future release","code":{"code":"deprecated","explanation":null},"level":"warning","spans":[{"file_name":"<::std::macros::select macros>","byte_start":184,"byte_end":190,"line_start":5,"line_end":5,"column_start":22,"column_end":28,"is_primary":true,"text":[{"text":"let mut $ rx = sel . handle ( & $ rx ) ; ) + unsafe {","highlight_start":22,"highlight_end":28}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":{"span":{"file_name":"/checkout/src/test/run-pass/issues/issue-13494.rs","byte_start":1117,"byte_end":1203,"line_start":37,"line_end":40,"column_start":9,"column_end":10,"is_primary":false,"text":[{"text":"        select! {","highlight_start":9,"highlight_end":18},{"text":"            _ = rx2.recv() => (),","highlight_start":1,"highlight_end":34},{"text":"            _ = rcv.recv() => ()","highlight_start":1,"highlight_end":33},{"text":"        }","highlight_start":1,"highlight_end":10}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null},"macro_decl_name":"select!","def_site_span":{"file_name":"<::std::macros::select macros>","byte_start":0,"byte_end":382,"line_start":1,"line_end":8,"column_start":1,"column_end":27,"is_primary":false,"text":[{"text":"( $ ( $ name : pat = $ rx : ident . $ meth : ident (  ) => $ code : expr ) , +","highlight_start":1,"highlight_end":79},{"text":") => (","highlight_start":1,"highlight_end":7},{"text":"{","highlight_start":1,"highlight_end":2},{"text":"use $ crate :: sync :: mpsc :: Select ; let sel = Select :: new (  ) ; $ (","highlight_start":1,"highlight_end":75},{"text":"let mut $ rx = sel . handle ( & $ rx ) ; ) + unsafe {","highlight_start":1,"highlight_end":54},{"text":"$ ( $ rx . add (  ) ; ) + } let ret = sel . wait (  ) ; $ (","highlight_start":1,"highlight_end":60},{"text":"if ret == $ rx . id (  ) { let $ name = $ rx . $ meth (  ) ; $ code } else ) +","highlight_start":1,"highlight_end":79},{"text":"{ unreachable ! (  ) } } )","highlight_start":1,"highlight_end":27}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}}}],"children":[],"rendered":"warning: use of deprecated item 'std::sync::mpsc::Select::handle': channel selection will be removed in a future release\n  --> /checkout/src/test/run-pass/issues/issue-13494.rs:37:9\n   |\nLL | /         select! {\nLL | |             _ = rx2.recv() => (),\nLL | |             _ = rcv.recv() => ()\nLL | |         }\n   | |_________^\n   |\n   = note: this> (","highlight_start":1,"highlight_end":7},{"text":"{","highlight_start":1,"highlight_end":2},{"text":"use $ crate :: sync :: mpsc :: Select ; let sel = Select :: new (  ) ; $ (","highlight_start":1,"highlight_end":75},{"text":"let mut $ rx = sel . handle ( & $ rx ) ; ) + unsafe {","highlight_start":1,"highlight_end":54},{"text":"$ ( $ rx . add (  ) ; ) + } let ret = sel . wait (  ) ; $ (","highlight_start":1,"highlight_end":60},{"text":"if ret == $ rx . id (  ) { let $ name = $ rx . $ meth (  ) ; $ code } else ) +","highlight_start":1,"highlight_end":79},{"text":"{ unreachable ! (  ) } } )","highlight_start":1,"highlight_end":27}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}}}],"children":[],"rendered":"warning: use of deprecated item '<std::sync::mpsc::Handle<'rx, T>>::add': channel selection will be removed in a future release\n  --> /checkout/src/test/run-pass/issues/issue-13494.rs:37:9\n   |\nLL | /         select! {\nLL | |             _ = rx2.recv() => (),\nLL | |             _ = rcv.recv() => ()\nLL | |         }\n   | |_________^\n   |\n   = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)\n\n"}
[01:02:57] {"message":"use of deprecated item 'std::sync::mpsc::Select::wait': channel selection will be removed in a future release","code":{"code":"deprecated","explanation":null},"level":"warning","spans":[{"file_name":"<::std::macros::select macros>","byte_start":261,"byte_end":265,"line_start":6,"line_end":6,"column_start":45,"column_end":49,"is_primary":true,"text":[{"text":"$ ( $ rx . add (  ) ; ) + } let ret = sel . wait (  ) ; $ (","highlight_start":45,"highlight_end":49}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":{"span":{"file_name":"/checkout/src/test/run-pass/issues/issue-13494.rs","byte_start":1117,"byte_end":1203,"line_start":37,"line_end":40,"column_start":9,"column_end":10,"is_primary":false,"text":[{"text":"        select! {","highlight_start":9,"highlight_end":18},{"text":"            _ = rx2.recv() => (),","highlight_start":1,"highlight_end":34},{"text":"            _ = rcv.recv() => ()","highlight_start":1,"highlight_end":33},{"text":"        }","highlight_start":1,"highlight_end":10}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null},"macro_decl_name":"select!","def_site_span":{"file_name":"<::std::macros::select macros>","byte_start":0,"byte_end":382,"line_start":1,"line_end":8,"column_start":1,"column_end":27,"is_primary":false,"text":[{"text":"( $ ( $ name : pat = $ rx : ident . $ meth : ident (  ) => $ code : expr ) , +","highlight_start":1,"highlight_end":79},{"text":") => (","highlight_start":1,"highlight_end":7},{"text":"{","highlight_start":1,"highlight_end":2},{"text":"use $ crate :: sync :: mpsc :: Select ; let sel = Select :: new (  ) ; $ (","highlight_start":1,"highlight_end":75},{"text":"let mut $ rx = sel . handle ( & $ rx ) ; ) + unsafe {","highlight_start":1,"highlight_end":54},{"text":"$ ( $ rx . add (  ) ; ) + } let ret = sel . wait (  ) ; $ (","highlight_start":1,"highlight_end":60},{"text":"if ret == $ rx . id (  ) { let $ name = $ rx . $ meth (  ) ; $ code } else ) +","highlight_start":1,"highlight_end":79},{"text":"{ unreachable ! (  ) } } )","highlight_start":1,"highlight_end":27}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}}}],"children":[],"rendered":"warning: use of deprecated item 'std::sync::mpsc::Select::wait': channel selection will be removed in a future release\n  --> /checkout/src/test/run-pass/issues/issue-13494.rs:37:9\n   |\nLL | /         select! {\nLL | |             _ = rx2.recv() => (),\nLL | |             _ = rcv.recv() => ()\nLL | |         }\n   | |_________^\n   |\n   = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)\n\n"}
[01:02:57] {"message":"use of deprecated item '<std::sync::mpsc::Handle<'rx, T>>::id': channel selection will be removed in a future release","code":{"code":"deprecated","explanation":null},"level":"warning","spans":[{"file_name":"<::std::macros::select macros>","byte_start":294,"byte_end":296,"line_start":7,"line_end":7,"column_start":18,"column_end":20,"is_primary":true,"text":[{"text":"if ret == $ rx . id (  ) { let $ name = $ rx . $ meth (  ) ; $ code } else ) +","highlight_start":18,"highlight_end":20}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":{"span":{"file_name":"/checkout/src/test/run-pass/issues/issue-13494.rs","byte_start":1117,"byte_end":1203,"line_start":37,"line_end":40,"column_start":9,"column_end":10,"is_primary":false,"text":[{"text":"        select! {","highlight_start":9,"highlight_end":18},{"text":"            _ = rx2.recv() => (),","highlight_start":1,"highlight_end":34},{"text":"            _ = rcv.recv() => ()","highlight_start":1,"highlight_end":33},{"text":"        }","highlight_start":1,"highlight_end":10}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null},"macro_decl_name":"select!","def_site_span":{"file_name":"<::std::macros::select macros>","byte_start":0,"byte_end":382,"line_start":1,"line_end":8,"column_start":1,"column_end":27,"is_primary":false,"text":[{"text":"( $ ( $ name : pat = $ rx : ident . $ meth : ident (  ) => $ code : expr ) , +","highlight_start":1,"highlight_end":79},{"text":") => (","highlight_start":1,"highlight_end":7},{"text":"{","highlight_start":1,"highlight_end":2},{"text":"use $ crate :: sync :: mpsc :: Select ; let sel = Select :: new (  ) ; $ (","highlight_start":1,"highlight_end":75},{"text":"let mut $ rx = sel . handle ( & $ rx ) ; ) + unsafe {","highlight_start":1,"highlight_end":54},{"text":"$ ( $ rx . add (  ) ; ) + } let ret = sel . wait (  ) ; $ (","highlight_start":1,"highlight_end":60},{"text":"if ret == $ rx . id (  ) { let $ name = $ rx . $ meth (  ) ; $ code } else ) +","highlight_start":1,"highlight_end":79},{"text":"{ unreachable ! (  ) } } )","highlight_start":1,"highlight_end":27}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}}}],"children":[],"rendered":"warning: use of deprecated item '<std::sync::mpsc::Handle<'rx, T>>::id': channel selection will be removed in a future release\n  --> /checkout/src/test/run-pass/issues/issue-13494.rs:37:9\n   |\nLL | /         select! {\nLL | |             _ = rx2.recv() => (),\nLL | |             _ = rcv.recv() => ()\nLL | |         }\n   | |_________^\n   |\n   = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)\n\n"}
[01:02:57] {"message":"use of deprecated item '<std::sync::mpsc::Handle<'rx, T>>::recv': channel selection will be removed in a future release","code":{"code":"deprecated","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/run-pass/issues/issue-13494.rs","byte_start":1147,"byte_end":1151,"line_start":38,"line_end":38,"column_start":21,"column_end":25,"is_primary":true,"text":[{"text":"            _ = rx2.recv() => (),","highlight_start":21,"highlight_end":25}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: use of deprecated item '<std::sync::mpsc::Handle<'rx, T>>::recv': channel selection will be removed in a future release\n  --> /checkout/src/test/run-pass/issues/issue-13494.rs:38:21\n   |\nLL |             _ = rx2.recv() => (),\n   |                     ^^^^\n\n"}
[01:02:57] {"message":"use of deprecated item '<std::sync::mpsc::Handle<'rx, T>>::recv': channel selection will be removed in a future release","code":{"code":"deprecated","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/run-pass/issues/issue-13494.rs","byte_start":1181,"byte_end":1185,"line_start":39,"line_end":39,"column_start":21,"column_end":25,"is_primary":true,"text":[{"text":"            _ = rcv.recv() => ()","highlight_start":21,"highlight_end":25}],"label":null,"suggested_replacement":null,"suggestion_applicabilit-5.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "5.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:02:57] 
[01:02:57] 
[01:02:57] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:02:57] Build completed unsuccessfully in 0:12:44
[01:02:57] Build completed unsuccessfully in 0:12:44
[01:02:57] make: *** [check] Error 1
[01:02:57] Makefile:58: recipe for target 'check' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:04ee27b8
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:29b34506:start=1541698475994947291,finish=1541698476001096399,duration=6149108
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:00686318
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:167049cb
travis_time:start:167049cb
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:23377320
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@SimonSapin
Copy link
Contributor

Looks good, thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Nov 8, 2018

📌 Commit d75dae3 has been approved by SimonSapin

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2018
@Mark-Simulacrum
Copy link
Member

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Nov 9, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#55783 - stjepang:deprecate-select, r=SimonS…
667904f 
…apin

Deprecate mpsc channel selection

Rationale: rust-lang#27800 (comment)

r? @SimonSapin
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Nov 9, 2018
Merged
bors added a commit that referenced this pull request Nov 9, 2018
@bors
Auto merge of #55803 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
36a50c2 
Rollup of 17 pull requests

Successful merges:

 - #55576 (Clarify error message for -C opt-level)
 - #55633 (Support memcpy/memmove with differing src/dst alignment)
 - #55638 (Fix ICE in msg_span_from_free_region on ReEmpty)
 - #55659 (rustc: Delete grouping logic from the musl target)
 - #55719 (Sidestep link error from rustfix'ed code by using a *defined* static.)
 - #55736 (Elide anon lifetimes in conflicting impl note)
 - #55739 (Consume optimization fuel from the MIR inliner)
 - #55742 (Avoid panic when matching function call)
 - #55753 (borrow_set: remove a helper function and a clone it uses)
 - #55755 (Improve creation of 3 IndexVecs)
 - #55758 ([regression - rust2018]: unused_mut lint false positives on nightly)
 - #55760 (Remove intermediate font specs)
 - #55761 (mir: remove a hacky recursive helper function)
 - #55774 (wasm32-unknown-emscripten expects the rust_eh_personality symbol)
 - #55777 (Use `Lit` rather than `P<Lit>` in `ast::ExprKind`.)
 - #55783 (Deprecate mpsc channel selection)
 - #55788 (rustc: Request ansi colors if stderr isn't a tty)

Failed merges:

r? @ghost
@bors bors merged commit d75dae3 into rust-lang:master Nov 9, 2018
@ghost ghost deleted the deprecate-select branch November 9, 2018 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rust-highfive @SimonSapin @bors @Mark-Simulacrum