Add Armv8-M Mainline targets #56000
Add Armv8-M Mainline targets #56000
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @zackmdavis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
CC #55041 - which I think does the same |
|
Ah sorry, now I've read the text, I missed the distinction between baseline and mainline :) |
|
(I don't think I'm the most qualified reviewer for this one.) |
|
|
||
| pub fn target() -> TargetResult { | ||
| Ok(Target { | ||
| llvm_target: "thumbv8m.main-none-eabi".to_string(), |
There was a problem hiding this comment.
Just noticed this one should be eabihf.
|
I think it's best to hold off on merging until rust-lang/cargo#6255 is sorted out (and #55041), but can get back to this after those! |
Dylan-DPC-zz
added
S-blocked
|
Cargo PR has been merged. |
|
☔ The latest upstream changes (presumably #55041) made this pull request unmergeable. Please resolve the merge conflicts. |
This commit enables the Armv8-M Mainline architecture profile. It adds two targets: - thumbv8m.main-none-eabi - thumbv8m.main-none-eabihf The second one uses the Floating Point Unit for floating point operations. It mainly targets the Cortex-M33 processor, which can have the optional Floating Point Unit extension.
|
@alexcrichton This one is now ready to be reviewed, if you have time |
|
@bors: r+ rollup |
|
📌 Commit 0f47c2a has been approved by |
bors
added
S-waiting-on-bors
Add Armv8-M Mainline targets This commit enables the Armv8-M Mainline architecture profile. It adds two targets: - `thumbv8m.main-none-eabi` - `thumbv8m.main-none-eabihf` The second one uses the Floating Point Unit for floating point operations. It mainly targets the Cortex-M33 processor, which can have the optional Floating Point Unit extension. It follows rust-lang#55041 which does it for Baseline. I will rebase this branch on top of it when it is merged to not create conflicts as we have some files in common. To make it work, it still relies on the Cargo change to be merged (accepting "." in target names, rust-lang/cargo#6255). The goal would also be to add this target in the CI so that the `core` library is available for everybody. To do this, some changes will be needed to compile successfully the needed libraries: * `cc-rs` needs to be updated to allow compiling C code for Armv8-M architectures profiles. It is only a few lines to add [here](https://github.com/alexcrichton/cc-rs/blob/a76611ad9836fa8c44fa8220a1d2a96dd3b7d4b6/src/lib.rs#L1299). * Some assembly files in `builtins` in `compiler-rt` were not assembling for Armv8-M Mainline. I sent changes [upstream](https://reviews.llvm.org/D51854) to that project to fix that. The Rust version of `compiler-rt` will have to be updated to contain [that commit](llvm-mirror/compiler-rt@a34cdf8). I tested it using the [Musca-A Test Chip board](https://developer.arm.com/products/system-design/development-boards/iot-test-chips-and-boards/musca-a-test-chip-board) but more intensively on the [Armv8-M FVP](https://developer.arm.com/products/system-design/fixed-virtual-platforms) (emulation platform). I am going to try to release my test code soon, once I tidy it up 👍
Rollup of 7 pull requests Successful merges: - #56000 (Add Armv8-M Mainline targets) - #56250 (Introduce ptr::hash for references) - #56434 (Improve query cycle errors for parallel queries) - #56516 (Replace usages of `..i + 1` ranges with `..=i`.) - #56555 (Send textual profile data to stderr, not stdout) - #56561 (Fix bug in from_key_hashed_nocheck) - #56574 (Fix a stutter in the docs for slice::exact_chunks) Failed merges: r? @ghost
This commit enables the Armv8-M Mainline architecture profile.
It adds two targets:
thumbv8m.main-none-eabithumbv8m.main-none-eabihfThe second one uses the Floating Point Unit for floating point
operations. It mainly targets the Cortex-M33 processor, which
can have the optional Floating Point Unit extension.
It follows #55041 which does it for Baseline. I will rebase this branch on top of it when it is merged to not create conflicts as we have some files in common. To make it work, it still relies on the Cargo change to be merged (accepting "." in target names, rust-lang/cargo#6255).
The goal would also be to add this target in the CI so that the
corelibrary is available for everybody. To do this, some changes will be needed to compile successfully the needed libraries:cc-rsneeds to be updated to allow compiling C code for Armv8-M architectures profiles. It is only a few lines to add here.builtinsincompiler-rtwere not assembling for Armv8-M Mainline. I sent changes upstream to that project to fix that. The Rust version ofcompiler-rtwill have to be updated to contain that commit.I tested it using the Musca-A Test Chip board but more intensively on the Armv8-M FVP (emulation platform). I am going to try to release my test code soon, once I tidy it up 👍