Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to rustc guide #56079

Merged
merged 2 commits into from
Jan 5, 2019
Merged

Link to rustc guide #56079

merged 2 commits into from
Jan 5, 2019

Conversation

mark-i-m
Copy link
Member

@rust-highfive
Copy link
Collaborator

r? @GuillaumeGomez

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 19, 2018
@mark-i-m
Copy link
Member Author

cc @gnzlbg

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 20, 2018

@mark-i-m Thanks!

I would just call this the "Rust Compiler Guide" (at least in the title), we want to advertise this for people that might be interested in contributing, but not be familiar with rust, and they might not make the jump that rustc stands for "rust compiler".

Also, the Rust Compiler Guide explains, for example, how to build Rust from source, run the tests, install it in a location that can be picked by rustup, etc. This is not the focus of the guide, but this is very useful information for people that want to build Rust from source for whatever reason, e.g., because rustup does not support their platform, because they are packaging Rust for a linux distribution, etc.

It might well be that this group of people deserves their own guide (How to Build, Test, and Package Rust? :D), but in the meantime the Rust Compiler Guide is all we got, and I think it is worth it to emphasize that it also covers these things (it already mentions them, but it might be worth it to address these more directly somehow).

@mark-i-m
Copy link
Member Author

I'm honestly a bit torn about the naming. There is also a "rustc book" linked in the same page. It is a user guide of how to use the compiler.

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 20, 2018

Yeah, that's definitely confusing. Maybe "Rust Compiler User Guide" vs "Rust Compiler Developer Guide" ?

@steveklabnik
Copy link
Member

This isn't ready to go yet; the plan is to uplift that repo as a submodule in this one, and then do this.

We also discussed the naming at the time. #49707

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 20, 2018

@steveklabnik is there an open issue tracking that ? Adding the rustc book as a submodule is pretty straightforward, is there anything blocking this?

@mark-i-m
Copy link
Member Author

Oh, yeah, I forgot about that.

Do we need to wait for it to become a submodule first?

@steveklabnik
Copy link
Member

@steveklabnik is there an open issue tracking that ? Adding the rustc book as a submodule is pretty straightforward, is there anything blocking this?

There is no issue; the only think blocking it is @nikomatsakis saying that it's ready to go.

Do we need to wait for it to become a submodule first?

Yes.

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 27, 2018

@nikomatsakis what do you think ? Is the rustc guide "good enough" to be linked in the docs website ? It's a bit hard to discover right now, and it contains information that's useful for non-rustc developers like how to build the Rust toolchain from source and test it etc.

@mark-i-m
Copy link
Member Author

We now have a submodule :)

@Dylan-DPC-zz
Copy link

ping from triage @nikomatsakis @steveklabnik any updates on this?

@steveklabnik
Copy link
Member

r=me if @nikomatsakis agrees

thank you! sorry for the delay.

@dwijnand
Copy link
Member

(ah, the if let of r=me's :P)

@mark-i-m
Copy link
Member Author

Ping @nikomatsakis ?

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 4, 2019

📌 Commit 980cc6d has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2019
@bors
Copy link
Contributor

bors commented Jan 4, 2019

⌛ Testing commit 980cc6d with merge bf6bb14...

bors added a commit that referenced this pull request Jan 4, 2019
@bors
Copy link
Contributor

bors commented Jan 5, 2019

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing bf6bb14 to master...

@bors bors merged commit 980cc6d into rust-lang:master Jan 5, 2019
@mark-i-m mark-i-m deleted the patch-1 branch May 25, 2019 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants