-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to rustc guide #56079
Link to rustc guide #56079
Conversation
As proposed in rust-lang/rustc-dev-guide#239
(rust_highfive has picked a reviewer for you, use r? to override) |
cc @gnzlbg |
@mark-i-m Thanks! I would just call this the "Rust Compiler Guide" (at least in the title), we want to advertise this for people that might be interested in contributing, but not be familiar with rust, and they might not make the jump that Also, the Rust Compiler Guide explains, for example, how to build Rust from source, run the tests, install it in a location that can be picked by rustup, etc. This is not the focus of the guide, but this is very useful information for people that want to build Rust from source for whatever reason, e.g., because rustup does not support their platform, because they are packaging Rust for a linux distribution, etc. It might well be that this group of people deserves their own guide (How to Build, Test, and Package Rust? :D), but in the meantime the Rust Compiler Guide is all we got, and I think it is worth it to emphasize that it also covers these things (it already mentions them, but it might be worth it to address these more directly somehow). |
I'm honestly a bit torn about the naming. There is also a "rustc book" linked in the same page. It is a user guide of how to use the compiler. |
Yeah, that's definitely confusing. Maybe "Rust Compiler User Guide" vs "Rust Compiler Developer Guide" ? |
This isn't ready to go yet; the plan is to uplift that repo as a submodule in this one, and then do this. We also discussed the naming at the time. #49707 |
@steveklabnik is there an open issue tracking that ? Adding the rustc book as a submodule is pretty straightforward, is there anything blocking this? |
Oh, yeah, I forgot about that. Do we need to wait for it to become a submodule first? |
There is no issue; the only think blocking it is @nikomatsakis saying that it's ready to go.
Yes. |
@nikomatsakis what do you think ? Is the |
We now have a submodule :) |
ping from triage @nikomatsakis @steveklabnik any updates on this? |
r=me if @nikomatsakis agrees thank you! sorry for the delay. |
(ah, the if let of r=me's :P) |
Ping @nikomatsakis ? |
@bors r+ |
📌 Commit 980cc6d has been approved by |
Link to rustc guide As proposed in rust-lang/rustc-dev-guide#239
☀️ Test successful - status-appveyor, status-travis |
As proposed in rust-lang/rustc-dev-guide#239