Suggest an appropriate token when encountering pub Ident<'a>
#56248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Nov 26, 2018
|
r? @Centril (you seem to have already taken a look at this) |
|
I primarily had a look at the test files; but I'd like someone else to look at the implementation bits so I'll give r? back to you. :) |
estebank
force-pushed
the
suggest-bare-pub
branch
from
4ca31f6
to
f091124
Compare
estebank
force-pushed
the
suggest-bare-pub
branch
from
f091124
to
2645871
Compare
|
There's a case that isn't handled by this PR (filed #56473): |
|
ping @michaelwoerister |
|
Hm, I don't know the parser very well. r? @petrochenkov maybe? Do we have a parser expert among the reviewers? |
|
@bors r+ |
|
📌 Commit 2645871 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 8, 2018
…henkov Suggest an appropriate token when encountering `pub Ident<'a>` Fix rust-lang#55403. Follow up to rust-lang#45997.
bors
added a commit
that referenced
this pull request
Dec 8, 2018
Rollup of 6 pull requests Successful merges: - #56248 (Suggest an appropriate token when encountering `pub Ident<'a>`) - #56597 (Improve the usage message for `-Z dump-mir`.) - #56599 (codegen: Fix va_list - aarch64 iOS/Windows) - #56602 (Fix the just-introduced ptr::hash docs) - #56620 (resolve: Reduce some clutter in import ambiguity errors) - #56621 (Add missing comma in Generators) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #55403. Follow up to #45997.