Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abiset #5631

Closed
wants to merge 1 commit into from
Closed

Abiset #5631

wants to merge 1 commit into from

Conversation

brson
Copy link
Contributor

@brson brson commented Mar 30, 2013

Continuing #5421

@brson brson mentioned this pull request Mar 30, 2013
Closed
@nikomatsakis @brson
Add AbiSet and integrate it into the AST.
6965fe4 
I believe this patch incorporates all expected syntax changes from extern
function reform (rust-lang#3678). You can now write things like:

    extern "<abi>" fn foo(s: S) -> T { ... }
    extern "<abi>" mod { ... }
    extern "<abi>" fn(S) -> T

The ABI for foreign functions is taken from this syntax (rather than from an
annotation).  We support the full ABI specification I described on the mailing
list.  The correct ABI is chosen based on the target architecture.

Calls by pointer to C functions are not yet supported, and the Rust type of
crust fns is still *u8.
bors added a commit that referenced this pull request Mar 30, 2013
@bors
auto merge of #5631 : brson/rust/abiset, r=brson,brson
fbd8eae 
Continuing #5421
@bors bors closed this Mar 30, 2013
@nikomatsakis
Copy link
Contributor

@brson thanks, I was just sitting down to do this exact thing.

@klutzy klutzy mentioned this pull request Oct 13, 2013
Merged
flip1995 pushed a commit to flip1995/rust that referenced this pull request May 27, 2020
@bors
Auto merge of rust-lang#5631 - ThibsG:ExtendUselessConversion, r=matt…
ee3088f 
…hiaskrgr

Extend useless conversion

This PR extends `useless_conversion` lint with `TryFrom` and `TryInto`

fixes: rust-lang#5344

changelog: Extend `useless_conversion` with `TryFrom` and `TryInto`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brson @nikomatsakis @bors