-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build when using clang and libunwind is installed #5646
Conversation
@graydon How do you feel about this change to |
Regardless of whether |
@brson: gcc and clang both come with their own |
I am not sure this is the right approach. If libunwind is a requirement on platforms where it works (and it is, right?) then surely we should be detecting and failing during configure, not detecting and compiling a broken binary, no? |
Clang doesn't expose the full unwinding interface in the fallback |
What do we need from unwind.h if we don't link against it? Maybe we can just remove the dependency? |
Yeah, we only need a few declarations just to pass some values through _UnwindResume. Maybe we can forget about unwind.h completely and use our own typedefs. |
Hey, so I just removed all the imports from I just copied the declarations of the types that upcall uses and it seems to work at the moment. Since this both solves the problem and removes the dependency on I'll push the commit to the branch when everything has finished compiling. |
Adds the required definitions in the correct place.
@Aatch thanks! |
@bors still hasn't picked this up, is there a way that I can get the build bots to do it myself? |
Rustup r? @phansch changelog: none
This fixes issue #5641