-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 19 pull requests #56531
Rollup of 19 pull requests #56531
Conversation
This commit improves the calculation of code spans for intra-doc resolution failures. All sugared doc comments should now have the correct spans, including those where the comment is longer than the docs. It also fixes an issue where the spans were calculated incorrectly for certain unsugared doc comments. The diagnostic will now always use the span of the attributes, as originally intended. Fixes rust-lang#55964.
* Create output directories for crates beforehand so rustdoc uses relative links * Readd rustc_codegen_ssa * Don't build out of tree dependencies for rustdoc like we don't for rustc
📌 Commit 77db179a2a73c5a2cc097e986442dd84ea43a37f has been approved by |
⌛ Testing commit 77db179a2a73c5a2cc097e986442dd84ea43a37f with merge a2a47995defbe446dc85381fb5fae9d9ca184f29... |
💔 Test failed - status-appveyor |
Introduce ptr::hash for references The RHS is what I used, which wasn't as convenient as `ptr::eq`, so I wondered: should `ptr::hash` exist? My first Rust PR, so I'm going to need some guidance. :)
…alexcrichton rustbuild: Fix issues with compiler docs * Create output directories for crates beforehand so rustdoc uses relative links (fixes rust-lang#56107) * Readd rustc_codegen_ssa (fixes rust-lang#56196) * Don't build out of tree dependencies for rustdoc like we don't for rustc
…ichton Avoid extra copy and syscall in std::env::current_exe
…reavus fix intra-link resolution spans in block comments This commit improves the calculation of code spans for intra-doc resolution failures. All sugared doc comments should now have the correct spans, including those where the comment is longer than the docs. It also fixes an issue where the spans were calculated incorrectly for certain unsugared doc comments. The diagnostic will now always use the span of the attributes, as originally intended. Fixes rust-lang#55964.
📌 Commit f0fbfe2 has been approved by |
⌛ Testing commit f0fbfe2 with merge 2821765995361088ebf2e87cd2d34f54bc0d1c65... |
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Successful merges:
From
implementations #51753 (DocumentFrom
implementations)?
instead ofreturn None
. #56119 (Utilize?
instead ofreturn None
.)