Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rt: regression patch for ARM assembly code #5654

Closed
wants to merge 1 commit into from
Closed

rt: regression patch for ARM assembly code #5654

wants to merge 1 commit into from

Conversation

yichoi
Copy link
Contributor

@yichoi yichoi commented Apr 1, 2013

Regression Path for ARM build failure on #5647

no need to add extra header for ARM assmebly code. already "RW" not "RWX"

readelf -lW arm-linux-androideabi/lib/libcore-c3ca5d77d81b46c1-0.6.so arm-linux-androideabi/lib/librustrt.so arm-linux-androideabi/lib/libstd-4782a756585a81-0.6.so | grep GNU_STACK

GNU_STACK 0x000000 0x00000000 0x00000000 0x00000 0x00000 RW 0
GNU_STACK 0x000000 0x00000000 0x00000000 0x00000 0x00000 RW 0
GNU_STACK 0x000000 0x00000000 0x00000000 0x00000 0x00000 RW 0

@thestinger
Copy link
Contributor

@yichoi: could you switch it to %progbits instead? I didn't realize @ would be invalid on ARM.

I think whether the header is needed depends heavily on the toolchain version.

@thestinger
Copy link
Contributor

Closing in favour of #5655 which fixes the syntax - https://github.com/mirrors/gcc/blob/master/gcc/config/arm/linux-elf.h#L113 seems to indicate that this is needed on at least some ARM platforms/toolchains.

I don't think there's any harm in having it when it's redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants