codegen_utils, driver: fix clippy errors #56566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 0142126160ce9ee50de426606379c466f4380845 has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
ljedrz
force-pushed
the
fix_clippy_errors
branch
from
0142126 to
adaeb10
Compare
|
Fixed the test. |
|
@bors r=cramertj |
|
📌 Commit adaeb10 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 7, 2018
codegen_utils, driver: fix clippy errors - remove a superfluous conversion - remove an explicit `return` - rename `MetadataOnlyCodegenBackend::new` to `::boxed` - single-arm `match` > `if let`
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
returnMetadataOnlyCodegenBackend::newto::boxedmatch>if let