-
Notifications
You must be signed in to change notification settings - Fork 13.3k
[do not merge] Test parallel queries #56765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bors try |
⌛ Trying commit 0e76967 with merge 2d8164662e3f939d63469888bc4d6ed57fa8a8bc... |
I was able to do a local perf.rlo run last we week. I'll post the results here if this doesn't succeed. |
💔 Test failed - status-travis |
This comment has been minimized.
This comment has been minimized.
@bors retry |
[do not merge] Test parallel queries Let's see if I have more luck r? @michaelwoerister
💔 Test failed - status-travis |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@bors try |
⌛ Trying commit 435a68446759a648b0225d10bd45ecf646ea32a8 with merge 83824a5cd486f61d87acc3bbe0a05601de2e4d4b... |
💔 Test failed - status-travis |
This comment has been minimized.
This comment has been minimized.
@bors try |
⌛ Trying commit 16d6920 with merge 4c48bb457450129a1852f945ac7a254d2b91fef8... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - status-travis |
This comment has been minimized.
This comment has been minimized.
@bors try |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
☀️ Test successful - status-travis |
@rust-timer build f471219 |
Success: Queued f471219 with parent ddab10a, comparison URL. |
Finished benchmarking try commit f471219 |
@bors try |
⌛ Trying commit b78525821fb0ae940405b041c3d2a387c0856119 with merge 89874d865056c6dbdbfc37d09e0e195108cb83d7... |
|
I'm confused. Those tests look like they actually improved by 5-10% Or am I looking at the wrong link? #56765 (comment) |
@oli-obk The default view sorts by instructions, sort by wall-time instead and the ctfe tests get much slower |
☀️ Test successful - status-travis |
I would have expected incremental to be slower, as decoding large constants can happen to duplicate the work with parallel decoding and then throw away all results but the first one to finish. I don't know why the non-incremental case is slower. It's not like we're evaluating queries twice, right? Especially weird that wall time would go down. Maybe it's just because evaluating those large constants will run a lot of queries (one or two for all the temporary locals that are written to) and I presume that a single query's evaluation time will be slower than before due to extra synchronizations? Also note that these tests are know to fluctuate by 2-5% all the time. Maybe that fluctuation gets way worse with parallel queries? |
@rust-timer build 89874d865056c6dbdbfc37d09e0e195108cb83d7 |
Success: Queued 89874d865056c6dbdbfc37d09e0e195108cb83d7 with parent ddab10a, comparison URL. |
Finished benchmarking try commit 89874d865056c6dbdbfc37d09e0e195108cb83d7 |
@bors try |
[do not merge] Test parallel queries Let's see if I have more luck r? @michaelwoerister
☀️ Test successful - checks-travis |
@rust-timer build 18d646d |
Success: Queued 18d646d with parent f001287, comparison URL. |
Finished benchmarking try commit 18d646d |
Let's see if I have more luck
r? @michaelwoerister