Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue with using Self ctor in typedefs #56850

Merged
merged 4 commits into from
Dec 16, 2018
Merged

Fixed issue with using Self ctor in typedefs #56850

merged 4 commits into from
Dec 16, 2018

Conversation

alexreg
Copy link
Contributor

@alexreg alexreg commented Dec 15, 2018 •
edited by pnkfelix
Loading

Added two regression tests.

This is definitely suitable for a beta backport.

CC @Centril

Includes regression tests labelled with issues #56199, #56835, #56611

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 15, 2018
@petrochenkov
Copy link
Contributor

c39a642 is missing

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2018
@petrochenkov
Copy link
Contributor

r=me with error message wording updated (#56850 (comment))

@alexreg
Copy link
Contributor Author

alexreg commented Dec 15, 2018

@petrochenkov Done.

@rust-highfive

This comment has been minimized.

Sign in to view
@alexreg alexreg force-pushed the fix-self-in-typedefs branch 2 times, most recently from d620d88 to bf5c5e3 Compare December 15, 2018 17:21
@alexreg
Copy link
Contributor Author

alexreg commented Dec 15, 2018

@petrochenkov AppVeyor is borked. Could you r+ this anyway please?

@petrochenkov
Copy link
Contributor

Error wording is updated, but tests are not.

@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-lang rust-lang deleted a comment from rust-highfive Dec 15, 2018
@alexreg
Copy link
Contributor Author

alexreg commented Dec 15, 2018 •
edited
Loading

@petrochenkov LGTM! :-)

@petrochenkov
Copy link
Contributor

@bors r+
@bors delegate+

@bors
Copy link
Contributor

bors commented Dec 16, 2018

✌️ @alexreg can now approve this pull request

@bors
Copy link
Contributor

bors commented Dec 16, 2018

📌 Commit 0211856 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 16, 2018
@petrochenkov
Copy link
Contributor

@alexreg
Could you squash commits into one if you have time?

@petrochenkov petrochenkov added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 16, 2018
@Centril Centril mentioned this pull request Dec 16, 2018
Closed
Centril added a commit to Centril/rust that referenced this pull request Dec 16, 2018
@Centril
Rollup merge of rust-lang#56850 - alexreg:fix-self-in-typedefs, r=pet…
8662946 
…rochenkov

Fixed issue with using `Self` ctor in typedefs

Added two regression tests.

This is definitely suitable for a beta backport.

CC @Centril
@Centril Centril mentioned this pull request Dec 16, 2018
Merged
bors added a commit that referenced this pull request Dec 16, 2018
@bors
Auto merge of #56875 - Centril:rollup, r=Centril
a8a2a88 
Rollup of 20 pull requests

Successful merges:

 - #53506 (Documentation for impl From for AtomicBool and other Atomic types)
 - #56343 (Remove not used mod)
 - #56439 (Clearer error message for dead assign)
 - #56640 (Add FreeBSD unsigned char platforms to std::os::raw)
 - #56648 (Fix BTreeMap UB)
 - #56672 (Document time of back operations of a Linked List)
 - #56706 (Make `const unsafe fn` bodies `unsafe`)
 - #56742 (infer: remove Box from a returned Iterator)
 - #56761 (Suggest using `.display()` when trying to print a `Path`)
 - #56781 (Update LLVM submodule)
 - #56789 (rustc: Add an unstable `simd_select_bitmask` intrinsic)
 - #56790 (Make RValue::Discriminant a normal Shallow read)
 - #56793 (rustdoc: look for comments when scraping attributes/crates from doctests)
 - #56826 (rustc: Add the `cmpxchg16b` target feature on x86/x86_64)
 - #56832 (std: Use `rustc_demangle` from crates.io)
 - #56844 (Improve CSS rule)
 - #56850 (Fixed issue with using `Self` ctor in typedefs)
 - #56855 (Remove u8 cttz hack)
 - #56857 (Fix a small mistake regarding NaNs in a deprecation message)
 - #56858 (Fix doc of `std::fs::canonicalize`)

Failed merges:

 - #56741 (treat ref-to-raw cast like a reborrow: do a special kind of retag)

r? @ghost
@bors bors merged commit 0211856 into rust-lang:master Dec 16, 2018
@pnkfelix pnkfelix added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 20, 2018
@pnkfelix pnkfelix mentioned this pull request Dec 20, 2018
Closed
@pnkfelix
Copy link
Member

discussed at T-compiler meeting. beta-accepted.

@pnkfelix pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Dec 20, 2018
@pietroalbini pietroalbini mentioned this pull request Dec 31, 2018
Merged
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 31, 2018
bors added a commit that referenced this pull request Dec 31, 2018
@bors
Auto merge of #57236 - pietroalbini:beta-backports, r=pietroalbini
bab921d 
[beta] Rollup backports

* #56919: Remove a wrong multiplier on relocation offset computation
* #56916: Fix mutable references in `static mut`
* #56863: fix trait objects with a Self-containing projection values
* #56850: Fixed issue with using `Self` ctor in typedefs

r? @ghost
bors added a commit that referenced this pull request Jan 1, 2019
@bors
Auto merge of #57236 - pietroalbini:beta-backports, r=pietroalbini
fa64cc8 
[beta] Rollup backports

* #56919: Remove a wrong multiplier on relocation offset computation
* #56916: Fix mutable references in `static mut`
* #56863: fix trait objects with a Self-containing projection values
* #56850: Fixed issue with using `Self` ctor in typedefs

r? @ghost
@davidtwco davidtwco mentioned this pull request Jan 20, 2019
Closed
@memoryruins memoryruins mentioned this pull request Jan 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexreg @petrochenkov @rust-highfive @bors @pnkfelix @pietroalbini