Fix i686 struct returning in some scenarios #5726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feel free to r+ it once the (minor) comments are resolved |
bors
added a commit
that referenced
this pull request
Apr 18, 2013
r? @nikomatsakis This doesn't completely fix the x86 ABI for structs, but it does fix some cases. On linux, structs appear to be returned correctly now. On windows, structs are only returned by pointer when they are greater than 8 bytes. That scenario works now. In the case where the struct is less than 8 bytes our generated code looks peculiar. When returning a pair of u16, C packs both variables into %eax to return them. Our generated code though expects to find one of the pair in %ax and the other in %dx. Similar for u8. I haven't looked into it yet. There appears to also be struct passing problems on linux, where my `extern-pass-TwoU8s` and `extern-pass-TwoU16s` tests are failing.
flip1995
added a commit
to flip1995/rust
that referenced
this pull request
Jun 23, 2020
Fix typo changelog: extending it's lifetime -> extending its lifetime
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 23, 2020
Rollup of 9 pull requests Successful merges: - rust-lang#5178 (clippy-driver: pass all args to rustc if --rustc is present) - rust-lang#5705 (Downgrade unnested_or_patterns to pedantic) - rust-lang#5709 (Fix ICE in consts::binop) - rust-lang#5710 (typo) - rust-lang#5712 (Remove `bar` from blacklisted names) - rust-lang#5713 (Use lints in Clippy that are enabled in rustc bootstrap) - rust-lang#5716 (Fix typo in wildcard_imports) - rust-lang#5724 (redundant_pattern_matching: avoid non-`const fn` calls in const contexts) - rust-lang#5726 (Fix typo) Failed merges: r? @ghost changelog: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis
This doesn't completely fix the x86 ABI for structs, but it does fix some cases. On linux, structs appear to be returned correctly now. On windows, structs are only returned by pointer when they are greater than 8 bytes. That scenario works now.
In the case where the struct is less than 8 bytes our generated code looks peculiar. When returning a pair of u16, C packs both variables into %eax to return them. Our generated code though expects to find one of the pair in %ax and the other in %dx. Similar for u8. I haven't looked into it yet.
There appears to also be struct passing problems on linux, where my
extern-pass-TwoU8sandextern-pass-TwoU16stests are failing.