Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update compiler_builtins 0.1.2 -> 0.1.4 #57327

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Update compiler_builtins 0.1.2 -> 0.1.4 #57327

merged 1 commit into from
Jan 7, 2019

Conversation

akash-fortanix
Copy link
Contributor

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 4, 2019
@kennytm
Copy link
Member

kennytm commented Jan 4, 2019

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jan 4, 2019

📌 Commit 66a4687ad7306696e00cfb423f6659f39d4e9edc has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2019
@kennytm kennytm mentioned this pull request Jan 4, 2019
Closed
@dingelish dingelish mentioned this pull request Jan 4, 2019
Closed
@dingelish
Copy link
Contributor

Thank you @akash-fortanix !

@bors
Copy link
Contributor

bors commented Jan 6, 2019

☔ The latest upstream changes (presumably #57121) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 6, 2019
@akash-fortanix akash-fortanix force-pushed the aa/update-compiler_builtins branch from 66a4687 to 3033304 Compare January 6, 2019 16:46
@akash-fortanix
Copy link
Contributor Author

Rebased. @kennytm @jethrogb

@kennytm
Copy link
Member

kennytm commented Jan 7, 2019

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jan 7, 2019

📌 Commit 3033304 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 7, 2019
@bors
Copy link
Contributor

bors commented Jan 7, 2019

⌛ Testing commit 3033304 with merge 474a3a9...

bors added a commit that referenced this pull request Jan 7, 2019
@bors
Auto merge of #57327 - akash-fortanix:aa/update-compiler_builtins, r=…
474a3a9 
…kennytm

Update compiler_builtins 0.1.2 -> 0.1.4

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Jan 7, 2019

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 474a3a9 to master...

@bors bors merged commit 3033304 into rust-lang:master Jan 7, 2019
@bors bors mentioned this pull request Jan 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@akash-fortanix @rust-highfive @kennytm @bors @dingelish @alexcrichton