htmldocck: don't let HTMLParser convert charrefs #57371
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With python 3.5, the default value for
convert_charrefs
became True. This broke nbsp conversion for@matches
XPATH PATTERN tests.My distro has python 3.7 as
python
, so I came across this failure:Putting a breakpoint on this method:
shows that it was not called. I suspect this is due to the change in behaviour between python3.4 and 3.5 documented in the constructor and the method: https://docs.python.org/3/library/html.parser.html#html.parser.HTMLParser.handle_entityref